From: Go MAEDA Date: Sun, 5 May 2019 01:37:57 +0000 (+0000) Subject: Merged r18126 from trunk to 3.4-stable (#31125). X-Git-Tag: 3.4.11~7 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=bf39410402486a427642aea8e939c0c1f2aa31fd;p=redmine.git Merged r18126 from trunk to 3.4-stable (#31125). git-svn-id: http://svn.redmine.org/redmine/branches/3.4-stable@18128 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- diff --git a/lib/redmine/thumbnail.rb b/lib/redmine/thumbnail.rb index 5779551da..e4ae768fe 100644 --- a/lib/redmine/thumbnail.rb +++ b/lib/redmine/thumbnail.rb @@ -49,7 +49,12 @@ module Redmine def self.convert_available? return @convert_available if defined?(@convert_available) - @convert_available = system("#{shell_quote CONVERT_BIN} -version") rescue false + begin + `#{shell_quote CONVERT_BIN} -version` + @convert_available = $?.success? + rescue + @convert_available = false + end logger.warn("Imagemagick's convert binary (#{CONVERT_BIN}) not available") unless @convert_available @convert_available end