From: Florian Zschocke <f.zschocke+git@gmail.com>
Date: Mon, 21 Nov 2022 20:14:56 +0000 (+0100)
Subject: Remove clippy.swf and update documentation
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=c04ddf554f3f2c77e268468a43dd645a8b565074;p=gitblit.git

Remove clippy.swf and update documentation

The `clippy.swf` Flash program is no longer needed and can be deleted.
The configuration property is now incorrectly named, but we keep the
name and update the documentation. Maybe it could be completely deleted
one day, when the clipboard.js solution is known to work and be universally
supported.
---

diff --git a/releases.moxie b/releases.moxie
index 05ac21e8..4e8006ff 100644
--- a/releases.moxie
+++ b/releases.moxie
@@ -7,6 +7,11 @@ r34: {
     date: ${project.buildDate}
     note: ''
           From 1.10.0 on Gitblit requires Java 8 as minimum Java version.
+
+          Should you have disabled the Flash-based copy-to-clipboard function because it wasn't working anymore
+          (web.allowFlashCopyToClipboard = false), you may want to rethink this and enable it again. The configuration
+          property has the same name, but the mechanism was exchanged. Flash is gone, and a modern JavaScript solution
+          is now used to copy text directly to the clipboard (via clipboard.js).
           ''
     html: ~
     text: ~
@@ -14,7 +19,8 @@ r34: {
     fixes:
       - Fix crash in Gitblit Authority when users were deleted from Gitblit but still had entries (certificates) in the Authority.
     changes:
-      - Minimum Java required increased to Java 8
+      - Minimum Java required increased to Java 8.
+      - Replaced the Flash-based approach to copy text to the clipboard with a modern JavaScript solution. (issue-1241)
     additions: ~
     dependencyChanges:
       - update to JavaMail 1.5.6 (pr-1217 by @paladox)
@@ -24,6 +30,7 @@ r34: {
       - update to Apache commons-io 2.11.0
       - update to Apache commons-compress 1.22
       - update to libpam4j 1.11
+      - added clipboard.js, replacing clippy.swf
     contributors:
       - paladox
 }
diff --git a/src/main/distrib/data/defaults.properties b/src/main/distrib/data/defaults.properties
index 0d072b58..b62285fd 100644
--- a/src/main/distrib/data/defaults.properties
+++ b/src/main/distrib/data/defaults.properties
@@ -1076,7 +1076,11 @@ web.allowForking = true
 # SINCE 1.2.0
 web.shortCommitIdLength = 6
 
-# Use Clippy (Flash solution) to provide a copy-to-clipboard button.
+# Use a JavaScript browser API to provide a copy-to-clipboard button.
+# The clipboard.js library is used to copy text directly to the browser's
+# clipboard.
+# (This used to be done with a Flash based solution, but has been replaced
+# with a modern JavaScript approach, since Flash support is dying out.)
 # If false, a button with a more primitive JavaScript-based prompt box will
 # offer a 3-step (click, ctrl+c, enter) copy-to-clipboard alternative.
 #
diff --git a/src/main/resources/clippy.swf b/src/main/resources/clippy.swf
deleted file mode 100644
index e46886cd..00000000
Binary files a/src/main/resources/clippy.swf and /dev/null differ