From: Vsevolod Stakhov <vsevolod@highsecure.ru>
Date: Sun, 12 Nov 2017 23:15:33 +0000 (+0000)
Subject: [Fix] Plug another possible memory leak
X-Git-Tag: 1.7.0~441
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=c10f4cf4169a8d0ad9709f8c7b6b187edc207b1f;p=rspamd.git

[Fix] Plug another possible memory leak

MFH: rspamd-1.6
---

diff --git a/src/libmime/content_type.c b/src/libmime/content_type.c
index f115bcb31..946a9b838 100644
--- a/src/libmime/content_type.c
+++ b/src/libmime/content_type.c
@@ -470,6 +470,8 @@ rspamd_content_disposition_add_param (rspamd_mempool_t *pool,
 	else {
 		cd->attrs = g_hash_table_new (rspamd_ftok_icase_hash,
 				rspamd_ftok_icase_equal);
+		rspamd_mempool_add_destructor (pool,
+				(rspamd_mempool_destruct_t)g_hash_table_unref, cd->attrs);
 	}
 
 	nparam = rspamd_mempool_alloc (pool, sizeof (*nparam));
@@ -507,11 +509,6 @@ rspamd_content_disposition_parse (const gchar *in,
 	if (rspamd_content_disposition_parser (in, len, &val, pool)) {
 		res = rspamd_mempool_alloc (pool, sizeof (val));
 		memcpy (res, &val, sizeof (val));
-
-		if (res->attrs) {
-			rspamd_mempool_add_destructor (pool,
-					(rspamd_mempool_destruct_t)g_hash_table_unref, res->attrs);
-		}
 	}
 	else {
 		msg_warn_pool ("cannot parse content disposition: %*s",