From: Arthur Schiwon <blizzz@owncloud.com>
Date: Tue, 19 Mar 2013 10:52:35 +0000 (+0100)
Subject: LDAP: check first whether group exists in this backend before doing other operations
X-Git-Tag: v5.0.1~24^2~2
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=c12b30f7a2a6fe05e826e827cd6c610f1fa728ec;p=nextcloud-server.git

LDAP: check first whether group exists in this backend before doing other operations
---

diff --git a/apps/user_ldap/group_ldap.php b/apps/user_ldap/group_ldap.php
index efa5f8b4fe3..3dbc5e7d895 100644
--- a/apps/user_ldap/group_ldap.php
+++ b/apps/user_ldap/group_ldap.php
@@ -139,6 +139,9 @@ class GROUP_LDAP extends lib\Access implements \OCP\GroupInterface {
 		if(!$this->enabled) {
 			return array();
 		}
+		if(!$this->groupExists($gid)) {
+			return false;
+		}
 		$cachekey = 'usersInGroup-'.$gid.'-'.$search.'-'.$limit.'-'.$offset;
 		// check for cache of the exact query
 		$groupUsers = $this->connection->getFromCache($cachekey);
@@ -214,6 +217,12 @@ class GROUP_LDAP extends lib\Access implements \OCP\GroupInterface {
 	 * @returns array with display names (value) and user ids(key)
 	 */
 	public function displayNamesInGroup($gid, $search, $limit, $offset) {
+		if(!$this->enabled) {
+			return array();
+		}
+		if(!$this->groupExists($gid)) {
+			return false;
+		}
 		$users = $this->usersInGroup($gid, $search, $limit, $offset);
 		$displayNames = array();
 		foreach($users as $user) {