From: Eric Davis <edavis@littlestreamsoftware.com>
Date: Mon, 21 Dec 2009 02:24:44 +0000 (+0000)
Subject: Extract method
X-Git-Tag: 0.9.0~53
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=c478fa7f907ea8a0df118dfedfc26f4c1a6d886d;p=redmine.git

Extract method

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3209 e93f8b46-1217-0410-a6f0-8f06a7374b81
---

diff --git a/app/controllers/account_controller.rb b/app/controllers/account_controller.rb
index c75f64e1b..b1500d428 100644
--- a/app/controllers/account_controller.rb
+++ b/app/controllers/account_controller.rb
@@ -137,9 +137,9 @@ class AccountController < ApplicationController
 
   def password_authentication
     user = User.try_to_login(params[:username], params[:password])
+
     if user.nil?
-      # Invalid credentials
-      flash.now[:error] = l(:notice_account_invalid_creditentials)
+      invalid_credentials
     elsif user.new_record?
       onthefly_creation_failed(user, {:login => user.login, :auth_source_id => user.auth_source_id })
     else
@@ -209,6 +209,10 @@ class AccountController < ApplicationController
     render :action => 'register'
   end
 
+  def invalid_credentials
+    flash.now[:error] = l(:notice_account_invalid_creditentials)
+  end
+
   # Register a user for email activation.
   #
   # Pass a block for behavior when a user fails to save