From: Toshi MARUYAMA <marutosijp2@yahoo.co.jp>
Date: Wed, 24 Oct 2012 09:24:30 +0000 (+0000)
Subject: fix "Page not found" on OK button in SCM "View all revisions" page (#12196)
X-Git-Tag: 2.2.0~158
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=c4ce048970c26140af98472fd0487e789d85d65d;p=redmine.git

fix "Page not found" on OK button in SCM "View all revisions" page (#12196)

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10709 e93f8b46-1217-0410-a6f0-8f06a7374b81
---

diff --git a/app/views/repositories/revisions.html.erb b/app/views/repositories/revisions.html.erb
index 0395e4b96..76ca629ae 100644
--- a/app/views/repositories/revisions.html.erb
+++ b/app/views/repositories/revisions.html.erb
@@ -1,7 +1,8 @@
 <div class="contextual">
 <%= form_tag(
        {:controller => 'repositories', :action => 'revision', :id => @project,
-        :repository_id => @repository.identifier_param}
+        :repository_id => @repository.identifier_param},
+       :method => :get
      ) do %>
   <%= l(:label_revision) %>: <%= text_field_tag 'rev', @rev, :size => 8 %>
   <%= submit_tag 'OK' %>
diff --git a/test/functional/repositories_git_controller_test.rb b/test/functional/repositories_git_controller_test.rb
index e7337b2e6..5dedf6e86 100644
--- a/test/functional/repositories_git_controller_test.rb
+++ b/test/functional/repositories_git_controller_test.rb
@@ -542,6 +542,21 @@ class RepositoriesGitControllerTest < ActionController::TestCase
       end
     end
 
+    def test_revisions
+      assert_equal 0, @repository.changesets.count
+      @repository.fetch_changesets
+      @project.reload
+      assert_equal NUM_REV, @repository.changesets.count
+      get :revisions, :id => PRJ_ID
+      assert_response :success
+      assert_template 'revisions'
+      assert_tag :tag => 'form',
+                 :attributes => {
+                   :method => 'get',
+                   :action => '/projects/subproject1/repository/revision'
+                 }
+    end
+
     def test_revision
       assert_equal 0, @repository.changesets.count
       @repository.fetch_changesets