From: Marius Balteanu <marius.balteanu@zitec.com>
Date: Sun, 3 Mar 2024 22:34:44 +0000 (+0000)
Subject: Fix rubocop warnings on 5.1-stable branch.
X-Git-Tag: 5.1.2~2
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=c7fb4dbad4e2683afd6b92ddfd36d814944c92b4;p=redmine.git

Fix rubocop warnings on 5.1-stable branch.

git-svn-id: https://svn.redmine.org/redmine/branches/5.1-stable@22762 e93f8b46-1217-0410-a6f0-8f06a7374b81
---

diff --git a/test/functional/issues_controller_test.rb b/test/functional/issues_controller_test.rb
index 1aa0446d0..cce8ddc62 100644
--- a/test/functional/issues_controller_test.rb
+++ b/test/functional/issues_controller_test.rb
@@ -1199,7 +1199,7 @@ class IssuesControllerTest < Redmine::ControllerTest
       create!(
         :name => 'Long text', :field_format => 'text',
         :full_width_layout => '1',
-        :tracker_ids => [1,3], :is_for_all => true
+        :tracker_ids => [1, 3], :is_for_all => true
       )
     issue = Issue.find(1)
     issue.custom_field_values = {field.id => 'This is a long text'}
diff --git a/test/functional/messages_controller_test.rb b/test/functional/messages_controller_test.rb
index ffb0c7e25..85f45f1d7 100644
--- a/test/functional/messages_controller_test.rb
+++ b/test/functional/messages_controller_test.rb
@@ -318,7 +318,7 @@ class MessagesControllerTest < Redmine::ControllerTest
       :params => {
         :board_id => 1,
         :id => 3
-      },
+      }
     )
 
     assert_response 404
diff --git a/test/integration/api_test/users_test.rb b/test/integration/api_test/users_test.rb
index 5f5c65ff0..995dc689f 100644
--- a/test/integration/api_test/users_test.rb
+++ b/test/integration/api_test/users_test.rb
@@ -139,7 +139,7 @@ class Redmine::ApiTest::UsersTest < Redmine::ApiTest::Base
     assert_response :success
     json = ActiveSupport::JSON.decode(response.body)
     assert json.key?('users')
-    users = User.where(status: [1,3])
+    users = User.where(status: [1, 3])
     assert_equal users.size, json['users'].size
   end
 
diff --git a/test/integration/routing/plugins_test.rb b/test/integration/routing/plugins_test.rb
index 48792b1aa..ddbf415a1 100644
--- a/test/integration/routing/plugins_test.rb
+++ b/test/integration/routing/plugins_test.rb
@@ -75,8 +75,8 @@ class RoutingPluginsTest < Redmine::RoutingTest
     assert_equal("/bar_plugin_articles", plugin_articles_path)
     should_route(
       'GET /attachments/plugin_articles/12/edit' => 'attachments#edit_all',
-      object_id: '12',
-      object_type: 'plugin_articles'
+      :object_id => '12',
+      :object_type => 'plugin_articles'
     )
   end
 
diff --git a/test/unit/lib/redmine/acts/mentionable_test.rb b/test/unit/lib/redmine/acts/mentionable_test.rb
index b04f12954..8cc86057f 100644
--- a/test/unit/lib/redmine/acts/mentionable_test.rb
+++ b/test/unit/lib/redmine/acts/mentionable_test.rb
@@ -29,7 +29,7 @@ class Redmine::Acts::MentionableTest < ActiveSupport::TestCase
          :issues
 
   def test_mentioned_users_with_user_mention
-    to_test = %w(@dlopper @dlopper! @dlopper? @dlopper. @dlopper,)
+    to_test = %w(@dlopper @dlopper! @dlopper? @dlopper. @dlopper)
 
     to_test.each do |item|
       issue = Issue.generate!(project_id: 1, description: item)