From: Nick Burch <nick@apache.org>
Date: Wed, 13 Jan 2010 14:25:31 +0000 (+0000)
Subject: Tweak the generics definition on workbook so that method signatures on hssf and xssf... 
X-Git-Tag: REL_3_7_BETA1~141
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=c8f8a1d8a062a1f902e8cabeebd06f34023a41f2;p=poi.git

Tweak the generics definition on workbook so that method signatures on hssf and xssf won't need to change

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@898769 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/src/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java b/src/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java
index d71d62dbd9..5c8c30eed7 100644
--- a/src/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java
+++ b/src/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java
@@ -1569,10 +1569,10 @@ public final class HSSFWorkbook extends POIDocument implements org.apache.poi.ss
      *
      * @return the list of pictures (a list of {@link HSSFPictureData} objects.)
      */
-    public List<PictureData> getAllPictures()
+    public List<HSSFPictureData> getAllPictures()
     {
         // The drawing group record always exists at the top level, so we won't need to do this recursively.
-        List<PictureData> pictures = new ArrayList<PictureData>();
+        List<HSSFPictureData> pictures = new ArrayList<HSSFPictureData>();
         Iterator<Record> recordIter = workbook.getRecords().iterator();
         while (recordIter.hasNext())
         {
@@ -1593,7 +1593,7 @@ public final class HSSFWorkbook extends POIDocument implements org.apache.poi.ss
      * @param escherRecords the escher records.
      * @param pictures the list to populate with the pictures.
      */
-    private void searchForPictures(List escherRecords, List<PictureData> pictures)
+    private void searchForPictures(List escherRecords, List<HSSFPictureData> pictures)
     {
         Iterator recordIter = escherRecords.iterator();
         while (recordIter.hasNext())
diff --git a/src/java/org/apache/poi/ss/usermodel/Workbook.java b/src/java/org/apache/poi/ss/usermodel/Workbook.java
index 53ddb8fa53..5967d8dedb 100644
--- a/src/java/org/apache/poi/ss/usermodel/Workbook.java
+++ b/src/java/org/apache/poi/ss/usermodel/Workbook.java
@@ -405,7 +405,7 @@ public interface Workbook {
      *
      * @return the list of pictures (a list of {@link PictureData} objects.)
      */
-    List<PictureData> getAllPictures();
+    List<? extends PictureData> getAllPictures();
 
     /**
      * Returns an object that handles instantiating concrete