From: Simon Brandhof <simon.brandhof@gmail.com>
Date: Wed, 24 Jul 2013 07:27:26 +0000 (+0200)
Subject: Fix some quality flaws
X-Git-Tag: 3.7~20
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=cbf3d9e2720d0a05a9c5f334f74df90e8b777618;p=sonarqube.git

Fix some quality flaws
---

diff --git a/sonar-core/src/test/java/org/sonar/core/persistence/DryRunDatabaseFactoryTest.java b/sonar-core/src/test/java/org/sonar/core/persistence/DryRunDatabaseFactoryTest.java
index f430aa71771..46be722f497 100644
--- a/sonar-core/src/test/java/org/sonar/core/persistence/DryRunDatabaseFactoryTest.java
+++ b/sonar-core/src/test/java/org/sonar/core/persistence/DryRunDatabaseFactoryTest.java
@@ -37,10 +37,9 @@ import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
 public class DryRunDatabaseFactoryTest extends AbstractDaoTestCase {
-  private DryRunDatabaseFactory localDatabaseFactory;
-
-  private ServerFileSystem serverFileSystem = mock(ServerFileSystem.class);
-  private BasicDataSource dataSource;
+  DryRunDatabaseFactory localDatabaseFactory;
+  ServerFileSystem serverFileSystem = mock(ServerFileSystem.class);
+  BasicDataSource dataSource;
 
   @Rule
   public TemporaryFolder temporaryFolder = new TemporaryFolder();
diff --git a/sonar-core/src/test/resources/logback-test.xml b/sonar-core/src/test/resources/logback-test.xml
index 9c0d4b1c3ba..5ff4cdd214e 100644
--- a/sonar-core/src/test/resources/logback-test.xml
+++ b/sonar-core/src/test/resources/logback-test.xml
@@ -24,6 +24,11 @@
     <level value="WARN"/>
   </logger>
 
+  <!-- required for DryRunDatabaseFactoryTest -->
+  <logger name="org.sonar.core.persistence.DryRunDatabaseFactory">
+    <level value="DEBUG"/>
+  </logger>
+
   <root>
     <level value="INFO"/>
     <appender-ref ref="STDOUT"/>
diff --git a/sonar-server/src/main/java/org/sonar/server/startup/RegisterRules.java b/sonar-server/src/main/java/org/sonar/server/startup/RegisterRules.java
index 2078f996fd4..6679e13aa11 100644
--- a/sonar-server/src/main/java/org/sonar/server/startup/RegisterRules.java
+++ b/sonar-server/src/main/java/org/sonar/server/startup/RegisterRules.java
@@ -75,8 +75,6 @@ public final class RegisterRules {
     disableDeprecatedRepositories(existingRules, session);
 
     session.commit();
-
-    //notifyForRemovedRules(existingRules);
   }
 
   private List<Rule> findAllRules(DatabaseSession session) {