From: Morlinest <Morlinest@users.noreply.github.com>
Date: Wed, 27 Sep 2017 12:41:52 +0000 (+0200)
Subject: Remove redudant issue LoadAttributes() calls (#2614)
X-Git-Tag: v1.3.0-rc1~153
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=cc84ca40d787d853186af6c16d328daa37d543da;p=gitea.git

Remove redudant issue LoadAttributes() calls (#2614)
---

diff --git a/models/issue.go b/models/issue.go
index 7884507a27..0c68275d41 100644
--- a/models/issue.go
+++ b/models/issue.go
@@ -984,12 +984,7 @@ func GetIssueByRef(ref string) (*Issue, error) {
 		return nil, err
 	}
 
-	issue, err := GetIssueByIndex(repo.ID, index)
-	if err != nil {
-		return nil, err
-	}
-
-	return issue, issue.LoadAttributes()
+	return GetIssueByIndex(repo.ID, index)
 }
 
 // GetRawIssueByIndex returns raw issue without loading attributes by index in a repository.
diff --git a/routers/api/v1/repo/issue.go b/routers/api/v1/repo/issue.go
index 9f51022f35..2debe67c3b 100644
--- a/routers/api/v1/repo/issue.go
+++ b/routers/api/v1/repo/issue.go
@@ -39,12 +39,6 @@ func ListIssues(ctx *context.APIContext) {
 		return
 	}
 
-	err = models.IssueList(issues).LoadAttributes()
-	if err != nil {
-		ctx.Error(500, "LoadAttributes", err)
-		return
-	}
-
 	apiIssues := make([]*api.Issue, len(issues))
 	for i := range issues {
 		apiIssues[i] = issues[i].APIFormat()