From: Mathieu Suen <mathieu.suen@sonarsource.com>
Date: Tue, 29 Mar 2022 14:26:12 +0000 (+0200)
Subject: SONAR-16158 Fix duplication block displaying wrong block
X-Git-Tag: 9.4.0.54424~22
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=cc891bbeb8c26a4f2e75c96919d26f90419e60bf;p=sonarqube.git

SONAR-16158 Fix duplication block displaying wrong block
---

diff --git a/server/sonar-web/src/main/js/api/rules.ts b/server/sonar-web/src/main/js/api/rules.ts
index 6a39950ed35..0ab2ad21c44 100644
--- a/server/sonar-web/src/main/js/api/rules.ts
+++ b/server/sonar-web/src/main/js/api/rules.ts
@@ -39,7 +39,7 @@ export function takeFacet(response: SearchRulesResponse, property: string) {
 export function getRuleRepositories(parameters: {
   q: string;
 }): Promise<Array<{ key: string; language: string; name: string }>> {
-  return getJSON('api/rules/repositories', parameters).then(
+  return getJSON('/api/rules/repositories', parameters).then(
     ({ repositories }) => repositories,
     throwGlobalError
   );
diff --git a/server/sonar-web/src/main/js/components/SourceViewer/components/Line.tsx b/server/sonar-web/src/main/js/components/SourceViewer/components/Line.tsx
index 6a8cbac14eb..590160f141b 100644
--- a/server/sonar-web/src/main/js/components/SourceViewer/components/Line.tsx
+++ b/server/sonar-web/src/main/js/components/SourceViewer/components/Line.tsx
@@ -131,6 +131,7 @@ export default class Line extends React.PureComponent<Props> {
     });
 
     const bottomPadding = verticalBuffer ? verticalBuffer * LINE_HEIGHT : undefined;
+    const blocksLoaded = duplicationsCount > 0;
 
     // default is true
     const displayOptions = displayLineNumberOptions !== false;
@@ -153,8 +154,8 @@ export default class Line extends React.PureComponent<Props> {
 
         {displayDuplications && (
           <LineDuplicationBlock
-            blocksLoaded={duplicationsCount > 0}
-            duplicated={Boolean(line.duplicated)}
+            blocksLoaded={blocksLoaded}
+            duplicated={!blocksLoaded ? Boolean(line.duplicated) : duplications.includes(0)}
             index={0}
             key={0}
             line={this.props.line}
@@ -163,17 +164,19 @@ export default class Line extends React.PureComponent<Props> {
           />
         )}
 
-        {duplicationsCount > 1 &&
-          times(duplicationsCount - 1, index => (
-            <LineDuplicationBlock
-              blocksLoaded={true}
-              duplicated={duplications.includes(index + 1)}
-              index={index + 1}
-              key={index + 1}
-              line={this.props.line}
-              renderDuplicationPopup={this.props.renderDuplicationPopup}
-            />
-          ))}
+        {blocksLoaded &&
+          times(duplicationsCount - 1, index => {
+            return (
+              <LineDuplicationBlock
+                blocksLoaded={blocksLoaded}
+                duplicated={duplications.includes(index + 1)}
+                index={index + 1}
+                key={index + 1}
+                line={this.props.line}
+                renderDuplicationPopup={this.props.renderDuplicationPopup}
+              />
+            );
+          })}
 
         {displayCoverage && (
           <LineCoverage
diff --git a/server/sonar-web/src/main/js/components/SourceViewer/components/__tests__/Line-test.tsx b/server/sonar-web/src/main/js/components/SourceViewer/components/__tests__/Line-test.tsx
index ab8dff7f3e8..35766221657 100644
--- a/server/sonar-web/src/main/js/components/SourceViewer/components/__tests__/Line-test.tsx
+++ b/server/sonar-web/src/main/js/components/SourceViewer/components/__tests__/Line-test.tsx
@@ -96,7 +96,7 @@ function shallowRender(props: Partial<Line['props']> = {}) {
       displayDuplications={false}
       displayIssues={false}
       displayLocationMarkers={false}
-      duplications={[]}
+      duplications={[0]}
       duplicationsCount={0}
       firstLineNumber={1}
       highlighted={false}
diff --git a/server/sonar-web/src/main/js/components/SourceViewer/components/__tests__/__snapshots__/Line-test.tsx.snap b/server/sonar-web/src/main/js/components/SourceViewer/components/__tests__/__snapshots__/Line-test.tsx.snap
index 784b30a9192..13ea52d94d8 100644
--- a/server/sonar-web/src/main/js/components/SourceViewer/components/__tests__/__snapshots__/Line-test.tsx.snap
+++ b/server/sonar-web/src/main/js/components/SourceViewer/components/__tests__/__snapshots__/Line-test.tsx.snap
@@ -478,7 +478,7 @@ exports[`should render correctly with duplication information 1`] = `
   />
   <Memo(LineDuplicationBlock)
     blocksLoaded={true}
-    duplicated={false}
+    duplicated={true}
     index={0}
     key="0"
     line={