From: Shawn Pearce <spearce@spearce.org>
Date: Tue, 10 Mar 2015 00:30:08 +0000 (-0700)
Subject: PushCertificateParser: Fix check for blank line after header
X-Git-Tag: v4.0.0.201503231230-m1~31
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=ce3997344ecb564f2af95fd366303e2c9d70143d;p=jgit.git

PushCertificateParser: Fix check for blank line after header

Reference equality (!= or ==) cannot be used to check for
String equality. String objects are not necessarily interned
to the same instance.

Use .isEmpty() since the function only cares about an empty
string and does not need to test a specific string value.

Change-Id: If530cb59666a8196d57d2348c893706a517ea541
---

diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/transport/PushCertificateParser.java b/org.eclipse.jgit/src/org/eclipse/jgit/transport/PushCertificateParser.java
index d4b11a5d40..4bb3d6bf82 100644
--- a/org.eclipse.jgit/src/org/eclipse/jgit/transport/PushCertificateParser.java
+++ b/org.eclipse.jgit/src/org/eclipse/jgit/transport/PushCertificateParser.java
@@ -158,7 +158,7 @@ public class PushCertificateParser extends PushCertificate {
 			pushee = parseNextLine(pckIn, PUSHEE);
 			receivedNonce = parseNextLine(pckIn, NONCE);
 			// an empty line
-			if (pckIn.readString() != "") { //$NON-NLS-1$
+			if (!pckIn.readString().isEmpty()) {
 				throw new IOException(MessageFormat.format(
 						JGitText.get().errorInvalidPushCert,
 						"expected empty line after header")); //$NON-NLS-1$