From: Richard Worth Date: Thu, 11 Mar 2010 02:09:45 +0000 (+0000) Subject: Checkbox must not be all the way hidden for change to fire in IE. Switched out .hide... X-Git-Tag: 1.8~63 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=cef16fdf78eab604ebe58526e58f962c60ab9bdb;p=jquery-ui.git Checkbox must not be all the way hidden for change to fire in IE. Switched out .hide() for ui-helper-hidden-accessible class instead. Fixes #5261 - button change events don't fire in IE 7/8 --- diff --git a/tests/visual/button/button_ticket_5261.html b/tests/visual/button/button_ticket_5261.html new file mode 100644 index 000000000..5f5bd19e6 --- /dev/null +++ b/tests/visual/button/button_ticket_5261.html @@ -0,0 +1,41 @@ + + + + Button Visual Test : Button ticket #5261 + + + + + + + + + + +

#5261 - button change events don't fire in IE 7/8

+ + + + + + diff --git a/ui/jquery.ui.button.js b/ui/jquery.ui.button.js index fd01cf750..9c26ba529 100644 --- a/ui/jquery.ui.button.js +++ b/ui/jquery.ui.button.js @@ -159,7 +159,7 @@ $.widget( "ui.button", { if ( this.type === "checkbox" || this.type === "radio" ) { this.buttonElement = $( "[for=" + this.element.attr("id") + "]" ); - this.element.hide(); + this.element.addClass('ui-helper-hidden-accessible'); var checked = this.element.is( ":checked" ); if ( checked ) {