From: Joonas Lehtinen <joonas.lehtinen@itmill.com>
Date: Fri, 2 Feb 2007 19:19:29 +0000 (+0000)
Subject: Fixed really well hidden logic bug (from year 2002) in core class. addComponent or... 
X-Git-Tag: 6.7.0.beta1~6712
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=d248abaa33add389846a200b4654922cd07d1bd6;p=vaadin-framework.git

Fixed really well hidden logic bug (from year 2002) in core class. addComponent or removeComponent should not call attach/detach directly. setParent does just that (as documented in the interface). This should fix those "double calls" to attach/detach. I really hope that this does not break anything.

svn changeset:428/svn branch:toolkit
---

diff --git a/src/com/itmill/toolkit/ui/AbstractComponentContainer.java b/src/com/itmill/toolkit/ui/AbstractComponentContainer.java
index 953a7f44ae..d8d86c1982 100644
--- a/src/com/itmill/toolkit/ui/AbstractComponentContainer.java
+++ b/src/com/itmill/toolkit/ui/AbstractComponentContainer.java
@@ -170,8 +170,6 @@ extends AbstractComponent implements ComponentContainer {
 	 */
 	public void addComponent(Component c) {
 		c.setParent(this);
-		if (getApplication() != null)
-			c.attach();
 		fireComponentAttachEvent(c);
 	}
 
@@ -181,8 +179,6 @@ extends AbstractComponent implements ComponentContainer {
 	 * @see com.itmill.toolkit.ui.ComponentContainer#removeComponent(Component)
 	 */
 	public void removeComponent(Component c) {
-		if (getApplication() != null)
-			c.detach();
 		c.setParent(null);
 		fireComponentDetachEvent(c);
 	}