From: Jean-Baptiste Lievremont <jean-baptiste.lievremont@sonarsource.com>
Date: Wed, 9 Oct 2013 12:35:17 +0000 (+0200)
Subject: SONAR-4724 Fix duplicate entries in ghost detection query
X-Git-Tag: 4.0~186
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=d415fda67ab74506092077a4adac53d8e24b62bc;p=sonarqube.git

SONAR-4724 Fix duplicate entries in ghost detection query
---

diff --git a/sonar-core/src/main/resources/org/sonar/core/resource/ResourceMapper.xml b/sonar-core/src/main/resources/org/sonar/core/resource/ResourceMapper.xml
index cc0fbcfe1bd..0599168ed89 100644
--- a/sonar-core/src/main/resources/org/sonar/core/resource/ResourceMapper.xml
+++ b/sonar-core/src/main/resources/org/sonar/core/resource/ResourceMapper.xml
@@ -167,7 +167,7 @@
   </sql>
 
   <select id="selectGhostsProjects" parameterType="map" resultMap="resourceResultMap">
-    select p.* from projects p
+    select distinct p.* from projects p
     inner join snapshots s1 on s1.project_id = p.id and s1.status='U'
     left join snapshots s2 on s2.project_id = p.id and s2.status='P'
     <where>
diff --git a/sonar-core/src/test/java/org/sonar/core/resource/ResourceDaoTest.java b/sonar-core/src/test/java/org/sonar/core/resource/ResourceDaoTest.java
index 57a728b7c29..25544ca8c95 100644
--- a/sonar-core/src/test/java/org/sonar/core/resource/ResourceDaoTest.java
+++ b/sonar-core/src/test/java/org/sonar/core/resource/ResourceDaoTest.java
@@ -343,6 +343,7 @@ public class ResourceDaoTest extends AbstractDaoTestCase {
     setupData("fixture-including-ghost-projects-and-technical-project");
 
     List<Component> components = dao.selectGhostsProjects(newArrayList("TRK"));
+    assertThat(components).hasSize(1);
     assertThat(getKeys(components)).containsOnly("org.apache.shindig");
 
     assertThat(dao.selectGhostsProjects(newArrayList("unknown"))).isEmpty();