From: Jean-Baptiste Lievremont <jean-baptiste.lievremont@sonarsource.com>
Date: Wed, 8 Oct 2014 13:52:45 +0000 (+0200)
Subject: SONAR-5574 Improve edition of custom rules
X-Git-Tag: 4.5.1-RC1~60
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=d517a6685d6c58e42068dbcdfa4ffbb8a5a8a9e6;p=sonarqube.git

SONAR-5574 Improve edition of custom rules
---

diff --git a/server/sonar-web/src/main/coffee/coding-rules/views/coding-rules-custom-rule-creation-view.coffee b/server/sonar-web/src/main/coffee/coding-rules/views/coding-rules-custom-rule-creation-view.coffee
index 951a224414e..810f4ccfd89 100644
--- a/server/sonar-web/src/main/coffee/coding-rules/views/coding-rules-custom-rule-creation-view.coffee
+++ b/server/sonar-web/src/main/coffee/coding-rules/views/coding-rules-custom-rule-creation-view.coffee
@@ -7,7 +7,7 @@ define [
 ) ->
 
   class CodingRulesCustomRuleCreationView extends Marionette.ItemView
-    className: 'modal'
+    className: 'modal coding-rules-modal'
     template: Templates['coding-rules-custom-rule-creation']
 
 
diff --git a/server/sonar-web/src/main/coffee/coding-rules/views/coding-rules-quality-profile-activation-view.coffee b/server/sonar-web/src/main/coffee/coding-rules/views/coding-rules-quality-profile-activation-view.coffee
index fc14043896e..785075e167f 100644
--- a/server/sonar-web/src/main/coffee/coding-rules/views/coding-rules-quality-profile-activation-view.coffee
+++ b/server/sonar-web/src/main/coffee/coding-rules/views/coding-rules-quality-profile-activation-view.coffee
@@ -7,7 +7,7 @@ define [
 ) ->
 
   class CodingRulesQualityProfileActivationView extends Marionette.ItemView
-    className: 'modal'
+    className: 'modal coding-rules-modal'
     template: Templates['coding-rules-quality-profile-activation']
 
 
diff --git a/server/sonar-web/src/main/hbs/coding-rules/coding-rules-custom-rule-creation.hbs b/server/sonar-web/src/main/hbs/coding-rules/coding-rules-custom-rule-creation.hbs
index e9db47f05eb..9f62f211344 100644
--- a/server/sonar-web/src/main/hbs/coding-rules/coding-rules-custom-rule-creation.hbs
+++ b/server/sonar-web/src/main/hbs/coding-rules/coding-rules-custom-rule-creation.hbs
@@ -23,7 +23,7 @@
         <th><h3>{{t 'key'}}{{#unless change}} <em class="mandatory">*</em>{{/unless}}</h3></th>
         <td>
           {{#if change}}
-            {{key}}
+            <span class="coding-rules-detail-custom-rule-key" title="{{key}}">{{key}}</span>
           {{else}}
             <input type="text" name="key" id="coding-rules-custom-rule-creation-key"
               class="coding-rules-name-key" value="{{internalKey}}"/>
diff --git a/server/sonar-web/src/main/less/coding-rules.less b/server/sonar-web/src/main/less/coding-rules.less
index 31488bd252b..02220f1eaab 100644
--- a/server/sonar-web/src/main/less/coding-rules.less
+++ b/server/sonar-web/src/main/less/coding-rules.less
@@ -390,6 +390,20 @@ textarea.coding-rules-markdown-description {
   font-weight: bold;
 }
 
+.coding-rules-detail-custom-rule-key {
+  display:inline-block;
+  max-width: 460px;
+  whitespace: nowrap;
+  overflow: hidden;
+  text-overflow: ellipsis;
+}
+
+.coding-rules-modal .property {
+  input, textarea {
+    width: 100%;
+  }
+}
+
 .coding-rules-subcharacteristic-more {
   display: none;
 }