From: Julien Lancelot <julien.lancelot@sonarsource.com>
Date: Tue, 27 May 2014 16:03:12 +0000 (+0200)
Subject: SONAR-5346 /api/sources?resource=MyFile return a error 500 when user have no permissi... 
X-Git-Tag: 4.4-RC1~805
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=d5e5db9f162f4863fd9b94678adac8ce50ea801e;p=sonarqube.git

SONAR-5346 /api/sources?resource=MyFile return a error 500 when user have no permission to access to the file
---

diff --git a/sonar-server/src/main/webapp/WEB-INF/app/controllers/api/sources_controller.rb b/sonar-server/src/main/webapp/WEB-INF/app/controllers/api/sources_controller.rb
index 772fbb04d17..0e5e445795e 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/controllers/api/sources_controller.rb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/controllers/api/sources_controller.rb
@@ -36,7 +36,11 @@ class Api::SourcesController < Api::RestController
         return
       end
     end
-    access_denied unless has_role?(:codeviewer, @resource)
+
+    unless has_role?(:codeviewer, @resource)
+      access_denied
+      return
+    end
 
     source = @resource.last_snapshot.source
     if !source