From: Simon Brandhof <simon.brandhof@gmail.com>
Date: Mon, 3 Feb 2014 20:50:31 +0000 (+0100)
Subject: Fix some quality flaws
X-Git-Tag: 4.2~281
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=da8f8285fe77723cf7b07c644366c86b25ca67b1;p=sonarqube.git

Fix some quality flaws
---

diff --git a/sonar-deprecated/src/main/java/org/sonar/api/batch/AbstractDirectoriesDecorator.java b/sonar-deprecated/src/main/java/org/sonar/api/batch/AbstractDirectoriesDecorator.java
index 3ccc4edae81..cf54bafecdf 100644
--- a/sonar-deprecated/src/main/java/org/sonar/api/batch/AbstractDirectoriesDecorator.java
+++ b/sonar-deprecated/src/main/java/org/sonar/api/batch/AbstractDirectoriesDecorator.java
@@ -36,7 +36,7 @@ public abstract class AbstractDirectoriesDecorator implements Decorator {
   /**
    * @param language this will be use to defined whether the decorator should be executed on a project
    */
-  public AbstractDirectoriesDecorator(Language language) {//NOSONAR this unused parameter is kept for backward-compatibility of API
+  public AbstractDirectoriesDecorator(Language language) {
   }
 
   /**
diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/batch/rule/internal/DefaultRule.java b/sonar-plugin-api/src/main/java/org/sonar/api/batch/rule/internal/DefaultRule.java
index ba3580b2093..784425b5d2a 100644
--- a/sonar-plugin-api/src/main/java/org/sonar/api/batch/rule/internal/DefaultRule.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/batch/rule/internal/DefaultRule.java
@@ -34,7 +34,7 @@ import java.util.Map;
 public class DefaultRule implements Rule {
 
   private final RuleKey key;
-  private Integer id;
+  private final Integer id;
   private final String name, severity, description, metadata;
   private final RuleStatus status;
   private final Map<String, RuleParam> params;
diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/rule/RuleStatus.java b/sonar-plugin-api/src/main/java/org/sonar/api/rule/RuleStatus.java
index 00b97edcd02..d9d95535ceb 100644
--- a/sonar-plugin-api/src/main/java/org/sonar/api/rule/RuleStatus.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/rule/RuleStatus.java
@@ -28,4 +28,4 @@ public enum RuleStatus {
   public static RuleStatus defaultStatus() {
     return READY;
   }
-}
\ No newline at end of file
+}
diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/rules/ActiveRule.java b/sonar-plugin-api/src/main/java/org/sonar/api/rules/ActiveRule.java
index 5c21e31b788..55772eac07d 100644
--- a/sonar-plugin-api/src/main/java/org/sonar/api/rules/ActiveRule.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/rules/ActiveRule.java
@@ -36,7 +36,6 @@ import java.util.List;
  */
 @Entity
 @Table(name = "active_rules")
-@Deprecated
 public class ActiveRule implements Cloneable {
 
   public static final String INHERITED = "INHERITED";