From: Eric Davis <edavis@littlestreamsoftware.com>
Date: Wed, 25 Aug 2010 14:59:16 +0000 (+0000)
Subject: Refactor: extract method in bulk_update.
X-Git-Tag: 1.1.0~418
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=daa4272c0e7f657a0070424224cabccbbeca6197;p=redmine.git

Refactor: extract method in bulk_update.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4040 e93f8b46-1217-0410-a6f0-8f06a7374b81
---

diff --git a/app/controllers/issues_controller.rb b/app/controllers/issues_controller.rb
index 29b131360..f10ba03bf 100644
--- a/app/controllers/issues_controller.rb
+++ b/app/controllers/issues_controller.rb
@@ -198,11 +198,8 @@ class IssuesController < ApplicationController
 
   def bulk_update
     @issues.sort!
+    attributes = parse_params_for_bulk_issue_attributes(params)
 
-    attributes = (params[:issue] || {}).reject {|k,v| v.blank?}
-    attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
-    attributes[:custom_field_values].reject! {|k,v| v.blank?} if attributes[:custom_field_values]
-    
     unsaved_issue_ids = []
     @issues.each do |issue|
       issue.reload
@@ -318,4 +315,11 @@ private
       return false
     end
   end
+
+  def parse_params_for_bulk_issue_attributes(params)
+    attributes = (params[:issue] || {}).reject {|k,v| v.blank?}
+    attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
+    attributes[:custom_field_values].reject! {|k,v| v.blank?} if attributes[:custom_field_values]
+    attributes
+  end
 end