From: Go MAEDA <maeda@farend.jp>
Date: Tue, 1 Nov 2022 03:24:17 +0000 (+0000)
Subject: Render all visible projects in robots.txt (including closed projects) (#37807).
X-Git-Tag: 5.1.0~355
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=dcdf27b8958606b6a6893c4b754ef2c97c3c0313;p=redmine.git

Render all visible projects in robots.txt (including closed projects) (#37807).

Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@21938 e93f8b46-1217-0410-a6f0-8f06a7374b81
---

diff --git a/app/controllers/welcome_controller.rb b/app/controllers/welcome_controller.rb
index a32a944a4..e526fe5b1 100644
--- a/app/controllers/welcome_controller.rb
+++ b/app/controllers/welcome_controller.rb
@@ -25,7 +25,7 @@ class WelcomeController < ApplicationController
   end
 
   def robots
-    @projects = Project.all_public.active
+    @projects = Project.visible(User.anonymous)
     render :layout => false, :content_type => 'text/plain'
   end
 end
diff --git a/test/integration/welcome_test.rb b/test/integration/welcome_test.rb
index 4337a5a50..ffb3e240f 100644
--- a/test/integration/welcome_test.rb
+++ b/test/integration/welcome_test.rb
@@ -24,6 +24,8 @@ class WelcomeTest < Redmine::IntegrationTest
            :projects, :enabled_modules, :members, :member_roles, :roles
 
   def test_robots
+    Project.find(3).update_attribute :status, Project::STATUS_CLOSED
+
     get '/robots.txt'
     assert_response :success
     assert_equal 'text/plain', @response.media_type
@@ -36,5 +38,8 @@ class WelcomeTest < Redmine::IntegrationTest
     assert @response.body.match(%r{^Disallow: /login\r?$})
     assert @response.body.match(%r{^Disallow: /account/register\r?$})
     assert @response.body.match(%r{^Disallow: /account/lost_password\r?$})
+
+    # closed projects are included in the list
+    assert @response.body.match(%r{^Disallow: /projects/subproject1/issues\r?$})
   end
 end