From: Artur Signell <artur.signell@itmill.com>
Date: Mon, 16 Feb 2009 08:48:58 +0000 (+0000)
Subject: Fix for #2572 - ComboBox icon aligned too low in IE6
X-Git-Tag: 6.7.0.beta1~3149
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=de615fb20a2d8ba21fc439152a6a2a6dc10f5a20;p=vaadin-framework.git

Fix for #2572 - ComboBox icon aligned too low in IE6

svn changeset:6845/svn branch:trunk
---

diff --git a/src/com/itmill/toolkit/terminal/gwt/client/ui/IFilterSelect.java b/src/com/itmill/toolkit/terminal/gwt/client/ui/IFilterSelect.java
index 450db45620..e76374cfc2 100644
--- a/src/com/itmill/toolkit/terminal/gwt/client/ui/IFilterSelect.java
+++ b/src/com/itmill/toolkit/terminal/gwt/client/ui/IFilterSelect.java
@@ -573,8 +573,8 @@ public class IFilterSelect extends Composite implements Paintable, Field,
             }
 
             public void onLoad(Widget sender) {
-                updateSelectedIconPosition();
                 updateRootWidth();
+                updateSelectedIconPosition();
             }
         });
 
@@ -769,20 +769,22 @@ public class IFilterSelect extends Composite implements Paintable, Field,
     private void setSelectedItemIcon(String iconUri) {
         if (iconUri == null) {
             selectedItemIcon.setVisible(false);
+            updateRootWidth();
         } else {
             selectedItemIcon.setUrl(iconUri);
             selectedItemIcon.setVisible(true);
+            updateRootWidth();
             updateSelectedIconPosition();
         }
-        updateRootWidth();
     }
 
     private void updateSelectedIconPosition() {
         // Position icon vertically to middle
         int availableHeight = getOffsetHeight();
         int iconHeight = Util.getRequiredHeight(selectedItemIcon);
+        int marginTop = (availableHeight - iconHeight) / 2;
         DOM.setStyleAttribute(selectedItemIcon.getElement(), "marginTop",
-                (availableHeight - iconHeight) / 2 + "px");
+                marginTop + "px");
     }
 
     public void onKeyDown(Widget sender, char keyCode, int modifiers) {