From: Javen O'Neal <onealj@apache.org>
Date: Sun, 19 Jun 2016 06:10:50 +0000 (+0000)
Subject: add unit test for bug 59719
X-Git-Tag: REL_3_15_BETA2~56
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=df3efa17b13167e1b7247a4a8c5339462f9425f7;p=poi.git

add unit test for bug 59719

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749131 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDataValidationConstraint.java b/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDataValidationConstraint.java
index a1dc762393..23c162e102 100644
--- a/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDataValidationConstraint.java
+++ b/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDataValidationConstraint.java
@@ -90,7 +90,9 @@ public class XSSFDataValidationConstraint implements DataValidationConstraint {
 		}
 	}
 
-	/* (non-Javadoc)
+	/**
+	 * If validation type is {@link ValidationType#LIST}, returns list of literal values.
+	 * Otherwise returns <code>null</code>.
 	 * @see org.apache.poi.ss.usermodel.DataValidationConstraint#getExplicitListValues()
 	 */
 	public String[] getExplicitListValues() {
diff --git a/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFDataValidationConstraint.java b/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFDataValidationConstraint.java
new file mode 100644
index 0000000000..25da754a0e
--- /dev/null
+++ b/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFDataValidationConstraint.java
@@ -0,0 +1,48 @@
+/* ====================================================================
+   Licensed to the Apache Software Foundation (ASF) under one or more
+   contributor license agreements.  See the NOTICE file distributed with
+   this work for additional information regarding copyright ownership.
+   The ASF licenses this file to You under the Apache License, Version 2.0
+   (the "License"); you may not use this file except in compliance with
+   the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+==================================================================== */
+package org.apache.poi.xssf.usermodel;
+
+import static org.junit.Assert.*;
+
+import org.apache.poi.ss.usermodel.DataValidationConstraint;
+import org.apache.poi.ss.usermodel.DataValidationConstraint.ValidationType;
+import org.apache.poi.ss.usermodel.DataValidationConstraint.OperatorType;
+import org.junit.Test;
+
+public class TestXSSFDataValidationConstraint {
+
+    // See bug 59719
+    @Test
+    public void listLiteralsQuotesAreStripped() {
+        int listType = ValidationType.LIST;
+        int ignoredType = OperatorType.IGNORED;
+        
+        String literal = "\"one, two, three\"";
+        String[] expected = new String[] { "one", "two", "three" };
+        DataValidationConstraint constraint = new XSSFDataValidationConstraint(listType, ignoredType, literal, null);
+        assertArrayEquals(expected, constraint.getExplicitListValues());
+        
+        String reference = "A1:A5";
+        constraint = new XSSFDataValidationConstraint(listType, ignoredType, reference, null);
+        assertNull(constraint.getExplicitListValues());
+        
+        String namedRange = "MyNamedRange";
+        constraint = new XSSFDataValidationConstraint(listType, ignoredType, namedRange, null);
+        assertNull(constraint.getExplicitListValues());
+    }
+
+}