From: Corey Frang Date: Sat, 20 Aug 2011 23:05:39 +0000 (-0500) Subject: Dialog: Update to 96e5c24 - keyup apparently doesn't work like I thought it would... X-Git-Tag: 1.9m6~24 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=dfe75e1b552013c440186645a7a1ae9ec3c757b5;p=jquery-ui.git Dialog: Update to 96e5c24 - keyup apparently doesn't work like I thought it would everywhere, switching back to keydown. --- diff --git a/tests/unit/dialog/dialog_tickets.js b/tests/unit/dialog/dialog_tickets.js index e65f939e0..b203ca7d5 100644 --- a/tests/unit/dialog/dialog_tickets.js +++ b/tests/unit/dialog/dialog_tickets.js @@ -14,7 +14,7 @@ asyncTest( "#3123: Prevent tabbing out of modal dialogs", function() { inputs.eq( 1 ).focus(); equal( document.activeElement, inputs[1], "Focus set on second input" ); - inputs.eq( 1 ).simulate( "keyup", { keyCode: $.ui.keyCode.TAB }); + inputs.eq( 1 ).simulate( "keydown", { keyCode: $.ui.keyCode.TAB }); setTimeout( checkTab, 2 ); diff --git a/ui/jquery.ui.dialog.js b/ui/jquery.ui.dialog.js index e8107db7c..065d640fb 100644 --- a/ui/jquery.ui.dialog.js +++ b/ui/jquery.ui.dialog.js @@ -293,7 +293,7 @@ $.widget("ui.dialog", { // prevent tabbing out of modal dialogs if ( options.modal ) { - uiDialog.bind( "keyup.ui-dialog", function( event ) { + uiDialog.bind( "keydown.ui-dialog", function( event ) { if ( event.keyCode !== $.ui.keyCode.TAB ) { return; }