From: Go MAEDA <maeda@farend.jp>
Date: Mon, 6 Feb 2023 14:08:30 +0000 (+0000)
Subject: Fix config/settings.yml not closed in Setting.load_available_settings (#38250).
X-Git-Tag: 5.1.0~246
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=e03bc47e1413a771505dcbf3fbb907d3a689e24a;p=redmine.git

Fix config/settings.yml not closed in Setting.load_available_settings (#38250).

Patch by Thomas Löber.


git-svn-id: https://svn.redmine.org/redmine/trunk@22099 e93f8b46-1217-0410-a6f0-8f06a7374b81
---

diff --git a/app/models/setting.rb b/app/models/setting.rb
index 3e3476330..1b73d7c1f 100644
--- a/app/models/setting.rb
+++ b/app/models/setting.rb
@@ -320,8 +320,10 @@ class Setting < ActiveRecord::Base
   end
 
   def self.load_available_settings
-    YAML::load(File.open("#{Rails.root}/config/settings.yml")).each do |name, options|
-      define_setting name, options
+    File.open("#{Rails.root}/config/settings.yml") do |f|
+      YAML.load(f).each do |name, options|
+        define_setting name, options
+      end
     end
   end