From: David Gageot <david@gageot.net>
Date: Tue, 29 May 2012 14:20:54 +0000 (+0200)
Subject: FIX violation
X-Git-Tag: 3.1~35
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=e05de07b50ae8fb4d86ba8f9fb8f6cf66a9095ae;p=sonarqube.git

FIX violation
---

diff --git a/sonar-server/src/main/java/org/sonar/server/startup/RegisterNewDashboards.java b/sonar-server/src/main/java/org/sonar/server/startup/RegisterNewDashboards.java
index 4bdf52b9ad9..6f7b924032e 100644
--- a/sonar-server/src/main/java/org/sonar/server/startup/RegisterNewDashboards.java
+++ b/sonar-server/src/main/java/org/sonar/server/startup/RegisterNewDashboards.java
@@ -152,11 +152,21 @@ public final class RegisterNewDashboards {
 
     @Override
     public int compare(DashboardDto d1, DashboardDto d2) {
+      if ((d1 == null) && (d2 == null)) {
+        return 0;
+      }
+      if ((d1 == null) || (d1.getName() == null)) {
+        return +1;
+      }
+      if ((d2 == null) || (d2.getName() == null)) {
+        return -1;
+      }
+
       // the default dashboard must be the first one to be activated
-      if (d1.getName().equals(DEFAULT_DASHBOARD_NAME)) {
+      if (DEFAULT_DASHBOARD_NAME.equals(d1.getName())) {
         return -1;
       }
-      if (d2.getName().equals(DEFAULT_DASHBOARD_NAME)) {
+      if (DEFAULT_DASHBOARD_NAME.equals(d2.getName())) {
         return 1;
       }
       return d1.getName().compareTo(d2.getName());