From: Jean-Philippe Lang <jp_lang@yahoo.fr>
Date: Fri, 4 Mar 2011 15:14:24 +0000 (+0000)
Subject: Fixed: Login page should not show projects link and search box if authentication... 
X-Git-Tag: 1.2.0~823
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=e41b76b459539b99208b7076decbc4534e917a0c;p=redmine.git

Fixed: Login page should not show projects link and search box if authentication is required (#3715).

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5007 e93f8b46-1217-0410-a6f0-8f06a7374b81
---

diff --git a/app/views/layouts/base.rhtml b/app/views/layouts/base.rhtml
index 017fcc173..fda4e2954 100644
--- a/app/views/layouts/base.rhtml
+++ b/app/views/layouts/base.rhtml
@@ -29,10 +29,11 @@
         <%= render_menu :account_menu -%>
     </div>
     <%= content_tag('div', "#{l(:label_logged_as)} #{link_to_user(User.current, :format => :username)}", :id => 'loggedas') if User.current.logged? %>
-    <%= render_menu :top_menu -%>
+    <%= render_menu :top_menu if User.current.logged? || !Setting.login_required? -%>
 </div>
       
 <div id="header">
+    <% if User.current.logged? || !Setting.login_required? %>
     <div id="quick-search">
         <% form_tag({:controller => 'search', :action => 'index', :id => @project}, :method => :get ) do %>
         <%= hidden_field_tag(controller.default_search_scope, 1, :id => nil) if controller.default_search_scope %>
@@ -41,6 +42,7 @@
         <% end %>
         <%= render_project_jump_box %>
     </div>
+    <% end %>
     
     <h1><%= page_header_title %></h1>
     
diff --git a/test/integration/layout_test.rb b/test/integration/layout_test.rb
index cb6371601..4e6f3d4d4 100644
--- a/test/integration/layout_test.rb
+++ b/test/integration/layout_test.rb
@@ -21,4 +21,20 @@ class LayoutTest < ActionController::IntegrationTest
     assert_response :forbidden
     assert_select "#admin-menu", :count => 0
   end
+
+  def test_top_menu_and_search_not_visible_when_login_required
+    with_settings :login_required => '1' do
+      get '/'
+      assert_select "#top-menu > ul", 0
+      assert_select "#quick-search", 0
+    end
+  end
+
+  def test_top_menu_and_search_visible_when_login_not_required
+    with_settings :login_required => '0' do
+      get '/'
+      assert_select "#top-menu > ul"
+      assert_select "#quick-search"
+    end
+  end
 end