From: Olivier Lamy <olamy@apache.org>
Date: Fri, 13 Dec 2013 04:46:45 +0000 (+0000)
Subject: add note on possible improvments
X-Git-Tag: archiva-2.0.0-RC1~127
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=e48c05fb6f04236bdb68103e9a0ae5c351d353c2;p=archiva.git

add note on possible improvments

git-svn-id: https://svn.apache.org/repos/asf/archiva/trunk@1550637 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/archiva-modules/archiva-base/archiva-filelock/src/main/java/org/apache/archiva/common/filelock/DefaultFileLockManager.java b/archiva-modules/archiva-base/archiva-filelock/src/main/java/org/apache/archiva/common/filelock/DefaultFileLockManager.java
index 4adf69b4f..d70cb775e 100644
--- a/archiva-modules/archiva-base/archiva-filelock/src/main/java/org/apache/archiva/common/filelock/DefaultFileLockManager.java
+++ b/archiva-modules/archiva-base/archiva-filelock/src/main/java/org/apache/archiva/common/filelock/DefaultFileLockManager.java
@@ -37,7 +37,10 @@ import java.util.concurrent.ConcurrentMap;
 public class DefaultFileLockManager
     implements FileLockManager
 {
-    private static final ConcurrentMap<File, Lock> lockFiles = new ConcurrentHashMap<File, Lock>( 64 );
+    // TODO currently we create lock for read and write!!
+    // the idea could be to store lock here with various clients read/write
+    // only read could be a more simple lock and acquire a write lock means waiting the end of all reading threads
+    //private static final ConcurrentMap<File, Lock> lockFiles = new ConcurrentHashMap<File, Lock>( 64 );
 
     private boolean skipLocking = false;