From: Côme Chilliet <come.chilliet@nextcloud.com>
Date: Thu, 23 Nov 2023 09:29:10 +0000 (+0100)
Subject: Missing things in database should be warning, not info
X-Git-Tag: v28.0.0rc3~32^2
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=e57d31ffb08cf247d7abbdd54089922a22c48de5;p=nextcloud-server.git

Missing things in database should be warning, not info

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
---

diff --git a/apps/settings/lib/SetupChecks/DatabaseHasMissingColumns.php b/apps/settings/lib/SetupChecks/DatabaseHasMissingColumns.php
index 946f357a04b..b062eb49372 100644
--- a/apps/settings/lib/SetupChecks/DatabaseHasMissingColumns.php
+++ b/apps/settings/lib/SetupChecks/DatabaseHasMissingColumns.php
@@ -81,7 +81,7 @@ class DatabaseHasMissingColumns implements ISetupCheck {
 			foreach ($missingColumns as $missingColumn) {
 				$list .= "\n".$this->l10n->t('Missing optional column "%s" in table "%s".', [$missingColumn['columnName'], $missingColumn['tableName']]);
 			}
-			return SetupResult::info(
+			return SetupResult::warning(
 				$this->l10n->t('The database is missing some optional columns. Due to the fact that adding columns on big tables could take some time they were not added automatically when they can be optional. By running "occ db:add-missing-columns" those missing columns could be added manually while the instance keeps running. Once the columns are added some features might improve responsiveness or usability.').$list
 			);
 		}
diff --git a/apps/settings/lib/SetupChecks/DatabaseHasMissingIndices.php b/apps/settings/lib/SetupChecks/DatabaseHasMissingIndices.php
index b19c3abb690..ccf6bbb52d0 100644
--- a/apps/settings/lib/SetupChecks/DatabaseHasMissingIndices.php
+++ b/apps/settings/lib/SetupChecks/DatabaseHasMissingIndices.php
@@ -81,7 +81,7 @@ class DatabaseHasMissingIndices implements ISetupCheck {
 			foreach ($missingIndices as $missingIndex) {
 				$list .= "\n".$this->l10n->t('Missing optional index "%s" in table "%s".', [$missingIndex['indexName'], $missingIndex['tableName']]);
 			}
-			return SetupResult::info(
+			return SetupResult::warning(
 				$this->l10n->t('The database is missing some indexes. Due to the fact that adding indexes on big tables could take some time they were not added automatically. By running "occ db:add-missing-indices" those missing indexes could be added manually while the instance keeps running. Once the indexes are added queries to those tables are usually much faster.').$list
 			);
 		}
diff --git a/apps/settings/lib/SetupChecks/DatabaseHasMissingPrimaryKeys.php b/apps/settings/lib/SetupChecks/DatabaseHasMissingPrimaryKeys.php
index 9609fe117bb..5ef65e63eff 100644
--- a/apps/settings/lib/SetupChecks/DatabaseHasMissingPrimaryKeys.php
+++ b/apps/settings/lib/SetupChecks/DatabaseHasMissingPrimaryKeys.php
@@ -81,7 +81,7 @@ class DatabaseHasMissingPrimaryKeys implements ISetupCheck {
 			foreach ($missingPrimaryKeys as $missingPrimaryKey) {
 				$list .= "\n".$this->l10n->t('Missing primary key on table "%s".', [$missingPrimaryKey['tableName']]);
 			}
-			return SetupResult::info(
+			return SetupResult::warning(
 				$this->l10n->t('The database is missing some primary keys. Due to the fact that adding primary keys on big tables could take some time they were not added automatically. By running "occ db:add-missing-primary-keys" those missing primary keys could be added manually while the instance keeps running.').$list
 			);
 		}