From: Jean-Philippe Lang <jp_lang@yahoo.fr>
Date: Sun, 23 Sep 2018 13:34:24 +0000 (+0000)
Subject: Remove unused and broken method CustomField.visibility_condition (#29160).
X-Git-Tag: 4.0.0~165
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=e978d480cd2fe774d9e34c266b6e09ad93291d39;p=redmine.git

Remove unused and broken method CustomField.visibility_condition (#29160).

Patch by Holger Just.

git-svn-id: http://svn.redmine.org/redmine/trunk@17507 e93f8b46-1217-0410-a6f0-8f06a7374b81
---

diff --git a/app/models/custom_field.rb b/app/models/custom_field.rb
index 58911b5f7..008ef49f9 100644
--- a/app/models/custom_field.rb
+++ b/app/models/custom_field.rb
@@ -224,19 +224,6 @@ class CustomField < ActiveRecord::Base
     end
   end
 
-  def self.visibility_condition
-    if user.admin?
-      "1=1"
-    elsif user.anonymous?
-      "#{table_name}.visible"
-    else
-      "#{project_key} IN (SELECT DISTINCT m.project_id FROM #{Member.table_name} m" +
-        " INNER JOIN #{MemberRole.table_name} mr ON mr.member_id = m.id" +
-        " INNER JOIN #{table_name_prefix}custom_fields_roles#{table_name_suffix} cfr ON cfr.role_id = mr.role_id" +
-        " WHERE m.user_id = #{user.id} AND cfr.custom_field_id = #{id})"
-    end
-  end
-
   def <=>(field)
     position <=> field.position
   end