From: techknowlogick Date: Sat, 24 Apr 2021 03:14:39 +0000 (-0400) Subject: Resolve panic on failed interface conversion in migration v156 (#15604) X-Git-Tag: v1.15.0-rc1~410 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=ea40eb749b9f7f238fc9bb60c4a9d455c62b75ca;p=gitea.git Resolve panic on failed interface conversion in migration v156 (#15604) go panics otherwise with `panic: interface conversion: error is git.ErrNotExist, not *git.ErrNotExist`, thanks to Codeberg/Andi for reporting this. Co-authored-by: Lunny Xiao --- diff --git a/models/migrations/v156.go b/models/migrations/v156.go index 9b63691a0f..1e7cf28277 100644 --- a/models/migrations/v156.go +++ b/models/migrations/v156.go @@ -119,7 +119,7 @@ func fixPublisherIDforTagReleases(x *xorm.Engine) error { commit, err := gitRepo.GetTagCommit(release.TagName) if err != nil { if git.IsErrNotExist(err) { - log.Warn("Unable to find commit %s for Tag: %s in %-v. Cannot update publisher ID.", err.(*git.ErrNotExist).ID, release.TagName, repo) + log.Warn("Unable to find commit %s for Tag: %s in %-v. Cannot update publisher ID.", err.(git.ErrNotExist).ID, release.TagName, repo) continue } log.Error("Error whilst getting commit for Tag: %s in %-v.", release.TagName, repo)