From: zeripath <art27@cantab.net>
Date: Sun, 4 Sep 2022 16:17:35 +0000 (+0100)
Subject: Redirect if user does not exist on admin pages (#20981) (#21059)
X-Git-Tag: v1.17.2~5
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=ea416d7d0edb1a291e8f2019449abce3d05c9b50;p=gitea.git

Redirect if user does not exist on admin pages (#20981) (#21059)

Backport #20981

When on /admin/users/ endpoints if the user is no longer in the DB,
redirect instead of causing a http 500.

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
---

diff --git a/routers/web/admin/users.go b/routers/web/admin/users.go
index c37ecfd71e..39b212bbc3 100644
--- a/routers/web/admin/users.go
+++ b/routers/web/admin/users.go
@@ -209,7 +209,11 @@ func NewUserPost(ctx *context.Context) {
 func prepareUserInfo(ctx *context.Context) *user_model.User {
 	u, err := user_model.GetUserByID(ctx.ParamsInt64(":userid"))
 	if err != nil {
-		ctx.ServerError("GetUserByID", err)
+		if user_model.IsErrUserNotExist(err) {
+			ctx.Redirect(setting.AppSubURL + "/admin/users")
+		} else {
+			ctx.ServerError("GetUserByID", err)
+		}
 		return nil
 	}
 	ctx.Data["User"] = u