From: Toshi MARUYAMA Date: Mon, 27 Jan 2014 01:09:09 +0000 (+0000) Subject: remove unneeded Relation#all from Mailer model X-Git-Tag: 2.5.0~177 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=ea8e5c74ec493669e315b85729615e06f853d002;p=redmine.git remove unneeded Relation#all from Mailer model git-svn-id: http://svn.redmine.org/redmine/trunk@12723 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- diff --git a/app/models/mailer.rb b/app/models/mailer.rb index c6becfdd4..a7cdd4c2e 100644 --- a/app/models/mailer.rb +++ b/app/models/mailer.rb @@ -266,7 +266,7 @@ class Mailer < ActionMailer::Base # Mailer.account_activation_request(user).deliver => sends an email to all active administrators def account_activation_request(user) # Send the email to all active administrators - recipients = User.active.where(:admin => true).all.collect { |u| u.mail }.compact + recipients = User.active.where(:admin => true).collect { |u| u.mail }.compact @user = user @url = url_for(:controller => 'users', :action => 'index', :status => User::STATUS_REGISTERED, @@ -330,8 +330,8 @@ class Mailer < ActionMailer::Base scope = scope.where(:assigned_to_id => user_ids) if user_ids.present? scope = scope.where(:project_id => project.id) if project scope = scope.where(:tracker_id => tracker.id) if tracker - - issues_by_assignee = scope.includes(:status, :assigned_to, :project, :tracker).all.group_by(&:assigned_to) + issues_by_assignee = scope.includes(:status, :assigned_to, :project, :tracker). + group_by(&:assigned_to) issues_by_assignee.keys.each do |assignee| if assignee.is_a?(Group) assignee.users.each do |user|