From: timmywil Date: Mon, 11 Apr 2011 15:54:55 +0000 (-0400) Subject: Fix unit tests in firefox 4 and opera 11, passing null or undefined to indexOf was... X-Git-Tag: 1.6b1~21^2~13^2^2~1 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=eb857e2b714e6786078cf8641941f267a6e19fa0;p=jquery.git Fix unit tests in firefox 4 and opera 11, passing null or undefined to indexOf was throwing an error in those browsers --- diff --git a/src/traversing.js b/src/traversing.js index fb5946bba..485de56d4 100644 --- a/src/traversing.js +++ b/src/traversing.js @@ -298,13 +298,18 @@ jQuery.extend({ // Implement the identical functionality for filter and not function winnow( elements, qualifier, keep ) { + + // Can't pass null or undefined to indexOf in Firefox 4 + // Set to 0 to skip string check + qualifier = qualifier || 0; + if ( jQuery.isFunction( qualifier ) ) { return jQuery.grep(elements, function( elem, i ) { var retVal = !!qualifier.call( elem, i, elem ); return retVal === keep; }); - } else if ( qualifier && qualifier.nodeType ) { + } else if ( qualifier.nodeType ) { return jQuery.grep(elements, function( elem, i ) { return (elem === qualifier) === keep; });