From: David Ostrovsky <david@ostrovsky.org>
Date: Wed, 26 Apr 2023 08:08:25 +0000 (+0200)
Subject: Demote severity of some error prone bug patterns to warnings
X-Git-Tag: v6.6.0.202305031100-m2~20^2^2^2^2^2~1^2~2^2^2~1
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=f3a3a2e8772222d89e4fbcf1dab43aa08935ea97;p=jgit.git

Demote severity of some error prone bug patterns to warnings

The code is not violation free, so demote the severity of these bug
patterns to warning:

o DefaultCharset
o FutureReturnValueIgnored
o UnusedException

Change-Id: Ie886a4a247770a74953385f018498ac2515ed209
---

diff --git a/tools/BUILD b/tools/BUILD
index 2b208744b5..eeac3e0722 100644
--- a/tools/BUILD
+++ b/tools/BUILD
@@ -34,7 +34,7 @@ java_package_configuration(
         "-Xep:CannotMockFinalClass:ERROR",
         "-Xep:ClassCanBeStatic:ERROR",
         "-Xep:ClassNewInstance:ERROR",
-        "-Xep:DefaultCharset:ERROR",
+        "-Xep:DefaultCharset:WARN",
         "-Xep:DoubleCheckedLocking:ERROR",
         "-Xep:ElementsCountedInLoop:ERROR",
         "-Xep:EqualsHashCode:ERROR",
@@ -44,7 +44,7 @@ java_package_configuration(
         "-Xep:FragmentInjection:ERROR",
         "-Xep:FragmentNotInstantiable:ERROR",
         "-Xep:FunctionalInterfaceClash:ERROR",
-        "-Xep:FutureReturnValueIgnored:ERROR",
+        "-Xep:FutureReturnValueIgnored:WARN",
         "-Xep:GetClassOnEnum:ERROR",
         "-Xep:ImmutableAnnotationChecker:ERROR",
         "-Xep:ImmutableEnumChecker:ERROR",
@@ -78,7 +78,7 @@ java_package_configuration(
         "-Xep:TypeParameterShadowing:ERROR",
         "-Xep:TypeParameterUnusedInFormals:WARN",
         "-Xep:URLEqualsHashCode:ERROR",
-        "-Xep:UnusedException:ERROR",
+        "-Xep:UnusedException:WARN",
         "-Xep:UnsynchronizedOverridesSynchronized:ERROR",
         "-Xep:WaitNotInLoop:ERROR",
     ],