From: Mathieu Suen Date: Wed, 4 Mar 2020 14:15:22 +0000 (+0100) Subject: SONAR-13159 Correct the github binding tab header order. X-Git-Tag: 8.3.0.34182~168 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=f45e42fabe2c5cfe6919d613ebfcb5c6285911ee;p=sonarqube.git SONAR-13159 Correct the github binding tab header order. --- diff --git a/server/sonar-web/src/main/js/apps/settings/components/almIntegration/GithubTab.tsx b/server/sonar-web/src/main/js/apps/settings/components/almIntegration/GithubTab.tsx index cf9aa3c5cb7..07818aa6c8d 100644 --- a/server/sonar-web/src/main/js/apps/settings/components/almIntegration/GithubTab.tsx +++ b/server/sonar-web/src/main/js/apps/settings/components/almIntegration/GithubTab.tsx @@ -48,7 +48,7 @@ export default function GithubTab(props: GithubTabProps) { translate('settings.almintegration.table.column.github.url'), translate('settings.almintegration.table.column.app_id') ]} - additionalColumnsKeys={['appId', 'url']} + additionalColumnsKeys={['url', 'appId']} alm={AlmKeys.GitHub} createConfiguration={createGithubConfiguration} defaultBinding={{ key: '', appId: '', url: '', privateKey: '' }} diff --git a/server/sonar-web/src/main/js/apps/settings/components/almIntegration/__tests__/__snapshots__/GithubTab-test.tsx.snap b/server/sonar-web/src/main/js/apps/settings/components/almIntegration/__tests__/__snapshots__/GithubTab-test.tsx.snap index 1f1420d5604..aaf2b45033d 100644 --- a/server/sonar-web/src/main/js/apps/settings/components/almIntegration/__tests__/__snapshots__/GithubTab-test.tsx.snap +++ b/server/sonar-web/src/main/js/apps/settings/components/almIntegration/__tests__/__snapshots__/GithubTab-test.tsx.snap @@ -13,8 +13,8 @@ exports[`should render correctly: with branch support 1`] = ` } additionalColumnsKeys={ Array [ - "appId", "url", + "appId", ] } alm="github"