From: Wouter Admiraal <wouter.admiraal@sonarsource.com>
Date: Mon, 21 Oct 2019 10:19:19 +0000 (+0200)
Subject: SONAR-12590 Don't show New Code Period menu entry for portfolios or applications
X-Git-Tag: 8.1.0.31237~155
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=f533245c9a73a0be2dd6e87124e23c8d4374295c;p=sonarqube.git

SONAR-12590 Don't show New Code Period menu entry for portfolios or applications
---

diff --git a/server/sonar-web/src/main/js/app/components/nav/component/ComponentNavMenu.tsx b/server/sonar-web/src/main/js/app/components/nav/component/ComponentNavMenu.tsx
index 83bd2377ccc..aa133ded13d 100644
--- a/server/sonar-web/src/main/js/app/components/nav/component/ComponentNavMenu.tsx
+++ b/server/sonar-web/src/main/js/app/components/nav/component/ComponentNavMenu.tsx
@@ -274,6 +274,9 @@ export class ComponentNavMenu extends React.PureComponent<Props> {
   }
 
   renderBaselineLink() {
+    if (!this.getConfiguration().showSettings || this.isApplication() || this.isPortfolio()) {
+      return null;
+    }
     return (
       <li key="baseline">
         <Link
diff --git a/server/sonar-web/src/main/js/app/components/nav/component/__tests__/__snapshots__/ComponentNavMenu-test.tsx.snap b/server/sonar-web/src/main/js/app/components/nav/component/__tests__/__snapshots__/ComponentNavMenu-test.tsx.snap
index b505a2dd16c..025e537c345 100644
--- a/server/sonar-web/src/main/js/app/components/nav/component/__tests__/__snapshots__/ComponentNavMenu-test.tsx.snap
+++ b/server/sonar-web/src/main/js/app/components/nav/component/__tests__/__snapshots__/ComponentNavMenu-test.tsx.snap
@@ -319,23 +319,6 @@ exports[`should work for all qualifiers 2`] = `
       <ul
         className="menu"
       >
-        <li>
-          <Link
-            activeClassName="active"
-            onlyActiveOnIndex={false}
-            style={Object {}}
-            to={
-              Object {
-                "pathname": "/project/baseline",
-                "query": Object {
-                  "id": "foo",
-                },
-              }
-            }
-          >
-            project_baseline.page
-          </Link>
-        </li>
         <li>
           <Link
             activeClassName="active"
@@ -451,35 +434,6 @@ exports[`should work for all qualifiers 3`] = `
       project_activity.page
     </Link>
   </li>
-  <Dropdown
-    data-test="administration"
-    overlay={
-      <ul
-        className="menu"
-      >
-        <li>
-          <Link
-            activeClassName="active"
-            onlyActiveOnIndex={false}
-            style={Object {}}
-            to={
-              Object {
-                "pathname": "/project/baseline",
-                "query": Object {
-                  "id": "foo",
-                },
-              }
-            }
-          >
-            project_baseline.page
-          </Link>
-        </li>
-      </ul>
-    }
-    tagName="li"
-  >
-    <Component />
-  </Dropdown>
 </NavBarTabs>
 `;
 
@@ -578,23 +532,6 @@ exports[`should work for all qualifiers 4`] = `
       <ul
         className="menu"
       >
-        <li>
-          <Link
-            activeClassName="active"
-            onlyActiveOnIndex={false}
-            style={Object {}}
-            to={
-              Object {
-                "pathname": "/project/baseline",
-                "query": Object {
-                  "id": "foo",
-                },
-              }
-            }
-          >
-            project_baseline.page
-          </Link>
-        </li>
         <li>
           <Link
             activeClassName="active"