From: Joonas Lehtinen <joonas.lehtinen@itmill.com>
Date: Sun, 28 Oct 2007 08:47:55 +0000 (+0000)
Subject: More comments (TODO) for Jani
X-Git-Tag: 6.7.0.beta1~5770
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=f93417aee81a462a1517941608469ec2f1d5535d;p=vaadin-framework.git

More comments (TODO) for Jani

svn changeset:2605/svn branch:trunk
---

diff --git a/build/build.xml b/build/build.xml
index 528a3b2cf1..c100928b40 100644
--- a/build/build.xml
+++ b/build/build.xml
@@ -44,6 +44,9 @@
 
 	<!-- Initialization - - - - - - - - - - - - - - - - - - - - - - - - -->
 	<target name="init">
+		
+		<!-- TODO The following selects mac platform even when we are building (on mac) for windows ??? -->
+		
 		<!-- Find out which platform we are in -->
 		<if>
 			<equals arg1="${os.name}" arg2="Windows 2000, Windows XP" />
@@ -99,6 +102,11 @@
 		<mkdir dir="${output-dir}/WebContent/WEB-INF" />
 		<mkdir dir="${output-dir}/WebContent/WEB-INF/classes" />
 
+		<!-- TODO Selection of classpath conflicts with bin/compile-gwt-components. build.xml expects gwt/mac/...
+		and bin/compile-gwt-components expects gwt/gwt/... We should use constistent naming everywhere. I propose
+		that we use gwt/mac/... everywhere. Still this init target should use the platform we are targeting, not the
+		platform we are building on. -->
+		
 		<!-- Construct classpath used by java and javadoc compilation -->
 		<path id="compile.classpath">
 			<pathelement path="build/gwt/${platform}/gwt-user.jar" />