From: Daniel Calviño Sánchez <danxuliu@gmail.com>
Date: Sat, 24 Nov 2018 17:06:20 +0000 (+0100)
Subject: Wait for the empty content element to be shown
X-Git-Tag: v14.0.5RC1~76^2~1
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=fc0a1d10159e60d1e76a3f141b5c13da7a633c1f;p=nextcloud-server.git

Wait for the empty content element to be shown

When the "Comments" tab is open the empty content element is always in
the DOM, although it is only shown once the message collection was
fetched and there were no messages. Due to this it is necessary to
explicitly wait for it to be shown instead of relying on the implicit
wait made to find the element; otherwise it would be found immediately
and if the collection was not fetched yet it would not be visible,
causing the test to fail.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
---

diff --git a/tests/acceptance/features/bootstrap/CommentsAppContext.php b/tests/acceptance/features/bootstrap/CommentsAppContext.php
index 5d19412c30e..57e60afa60e 100644
--- a/tests/acceptance/features/bootstrap/CommentsAppContext.php
+++ b/tests/acceptance/features/bootstrap/CommentsAppContext.php
@@ -83,8 +83,12 @@ class CommentsAppContext implements Context, ActorAwareInterface {
 	 * @Then /^I see that there are no comments$/
 	 */
 	public function iSeeThatThereAreNoComments() {
-		PHPUnit_Framework_Assert::assertTrue(
-				$this->actor->find(self::emptyContent(), 10)->isVisible());
+		if (!WaitFor::elementToBeEventuallyShown(
+				$this->actor,
+				self::emptyContent(),
+				$timeout = 10 * $this->actor->getFindTimeoutMultiplier())) {
+			PHPUnit_Framework_Assert::fail("The no comments message is not visible yet after $timeout seconds");
+		}
 	}
 
 	/**