From: Matthias Sohn <matthias.sohn@sap.com>
Date: Wed, 16 Nov 2011 19:47:12 +0000 (+0100)
Subject: [findBugs] Silence returning null for StringUtils.toBooleanOrNull()
X-Git-Tag: v1.2.0.201112221803-r~33^2
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=refs%2Fchanges%2F38%2F4638%2F1;p=jgit.git

[findBugs] Silence returning null for StringUtils.toBooleanOrNull()

As the method name and its javadoc clearly state that this method can
return null we can ignore this FindBugs warning.

Change-Id: I366435e26eda5d910f5d1a907db51f08efd4bb8c
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
---

diff --git a/org.eclipse.jgit/findBugs/FindBugsExcludeFilter.xml b/org.eclipse.jgit/findBugs/FindBugsExcludeFilter.xml
index 073f3da9d5..b8f300740a 100644
--- a/org.eclipse.jgit/findBugs/FindBugsExcludeFilter.xml
+++ b/org.eclipse.jgit/findBugs/FindBugsExcludeFilter.xml
@@ -45,4 +45,11 @@
        <Class name="org.eclipse.jgit.util.TemporaryBuffer$BlockInputStream" />
        <Bug pattern="UR_UNINIT_READ" />
      </Match>
+
+     <!-- Silence returning null for Boolean return type -->
+     <Match>
+       <Class name="org.eclipse.jgit.util.StringUtils" />
+       <Method name="toBooleanOrNull" />
+       <Bug pattern="NP_BOOLEAN_RETURN_NULL" />
+     </Match>
 </FindBugsFilter>