From: Arthur Schiwon <blizzz@arthur-schiwon.de>
Date: Fri, 17 Apr 2020 12:56:53 +0000 (+0200)
Subject: do not run paged results against ldap_read ops on PHP7.3+
X-Git-Tag: v19.0.0beta5~8^2
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=refs%2Fpull%2F20536%2Fhead;p=nextcloud-server.git

do not run paged results against ldap_read ops on PHP7.3+

- previously it was needed as the PHP LDAP handling of paged results was
strange
- but now the read operation would fail, e.g. with extra home dir attribute
set ("Home dir attribute can't be read from LDAP for uid: foobar"

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
---

diff --git a/apps/user_ldap/lib/PagedResults/Php73.php b/apps/user_ldap/lib/PagedResults/Php73.php
index f431365ff18..014a7b1caa7 100644
--- a/apps/user_ldap/lib/PagedResults/Php73.php
+++ b/apps/user_ldap/lib/PagedResults/Php73.php
@@ -135,7 +135,6 @@ class Php73 implements IAdapter {
 		$this->linkData[$linkId]['readArgs'] = func_get_args();
 		$this->linkData[$linkId]['readArgs'][] = 0; // $attrsonly default
 		$this->linkData[$linkId]['readArgs'][] = -1; // $sizelimit default
-		$this->preparePagesResultsArgs($linkId, 'readArgs');
 	}
 
 	public function getReadArgs($link): array {