From: Joas Schilling Date: Fri, 11 Sep 2020 09:52:05 +0000 (+0200) Subject: Don't log Microsoft WebDAV client trying to tag things X-Git-Tag: v20.0.0RC1~34^2 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=refs%2Fpull%2F22799%2Fhead;p=nextcloud-server.git Don't log Microsoft WebDAV client trying to tag things Signed-off-by: Joas Schilling --- diff --git a/apps/dav/lib/Connector/Sabre/ExceptionLoggerPlugin.php b/apps/dav/lib/Connector/Sabre/ExceptionLoggerPlugin.php index 0bd0a54d667..ad590c8cf34 100644 --- a/apps/dav/lib/Connector/Sabre/ExceptionLoggerPlugin.php +++ b/apps/dav/lib/Connector/Sabre/ExceptionLoggerPlugin.php @@ -32,6 +32,7 @@ use OCA\DAV\Connector\Sabre\Exception\FileLocked; use OCA\DAV\Connector\Sabre\Exception\PasswordLoginForbidden; use OCP\Files\StorageNotAvailableException; use OCP\ILogger; +use Sabre\DAV\Exception\BadRequest; use Sabre\DAV\Exception\Conflict; use Sabre\DAV\Exception\Forbidden; use Sabre\DAV\Exception\InvalidSyncToken; @@ -54,6 +55,10 @@ class ExceptionLoggerPlugin extends \Sabre\DAV\ServerPlugin { // the sync client uses this to find out whether files exist, // so it is not always an error, log it as debug NotFound::class => true, + // the sync client messed up their request + // (e.g. propfind for tags with string instead of int) + // so it is not always an error, log it as debug + BadRequest::class => true, // this one mostly happens when the same file is uploaded at // exactly the same time from two clients, only one client // wins, the second one gets "Precondition failed"