source.dussan.org Git

Dominik Stadler [Tue, 12 Apr 2016 06:56:06 +0000 (06:56 +0000)]

Exclude file that was modified and now fails with the known limitation of sheet-cloning

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738704 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 12 Apr 2016 03:43:33 +0000 (03:43 +0000)]

convert to junit4

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738680 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 12 Apr 2016 03:21:01 +0000 (03:21 +0000)]

whitespace: +svn:eol-style=native, tabs to 4 spaces

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738679 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 12 Apr 2016 03:13:52 +0000 (03:13 +0000)]

javadoc typo

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738677 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 12 Apr 2016 01:31:09 +0000 (01:31 +0000)]

change chart type from 2 independent data series to one independent-dependent data series

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738675 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 12 Apr 2016 01:30:20 +0000 (01:30 +0000)]

fix javadocs and findbugs warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738674 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 12 Apr 2016 00:21:46 +0000 (00:21 +0000)]

bug 59306: add SimpleScatterChart.xls(x) for testing

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738671 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 11 Apr 2016 21:35:22 +0000 (21:35 +0000)]

bug 52949: add unit test for reading VBA Macros from a Visio OOXML (VSDM, 2013+) file

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738651 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 11 Apr 2016 21:25:11 +0000 (21:25 +0000)]

bug 52949: add Visio (XDGF) file with macros to test macro extraction

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738649 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 11 Apr 2016 05:54:17 +0000 (05:54 +0000)]

bug 52949: add VBAMacroReader unit tests for H/XSLF, H/XWPF, and HGDF; OLE directories as case-insensitive

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738513 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 11 Apr 2016 03:02:18 +0000 (03:02 +0000)]

bug 52949: add Word, Powerpoint, and Visio (HDGF) files with macros to test macro extraction

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738502 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 11 Apr 2016 01:33:21 +0000 (01:33 +0000)]

add compile dependency to forbidden-apis-check so that forbidden-apis-check will recompile sources that have been modified

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738500 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 11 Apr 2016 01:26:09 +0000 (01:26 +0000)]

bug 52949: fix forbidden apis

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738499 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 10 Apr 2016 21:28:41 +0000 (21:28 +0000)]

add @NotImplemented annotation to methods that are not implemented

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738469 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 10 Apr 2016 20:21:55 +0000 (20:21 +0000)]

ignore VBA source files in integration test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738460 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 10 Apr 2016 14:46:42 +0000 (14:46 +0000)]

bug 52949: parameterize fromNPOIFS also

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738439 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 10 Apr 2016 14:33:47 +0000 (14:33 +0000)]

bug 52949: prepare for adding DOC/DOCM and PPT/PPTM test cases

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738438 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 10 Apr 2016 14:09:02 +0000 (14:09 +0000)]

bug 52949: add junit test for RLEDecompressingInputStream

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738436 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 10 Apr 2016 14:05:33 +0000 (14:05 +0000)]

svn propset svn:eol-style native

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738435 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sun, 10 Apr 2016 13:02:36 +0000 (13:02 +0000)]

Javadoc tweaks

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738431 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sun, 10 Apr 2016 12:59:38 +0000 (12:59 +0000)]

Make the extractor exactly that, powered by the reader #52949

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738429 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sun, 10 Apr 2016 12:45:53 +0000 (12:45 +0000)]

Unit test for VBA macro reading #52949

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738427 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sun, 10 Apr 2016 11:54:09 +0000 (11:54 +0000)]

Start to refactor VBAMacroExtractor into a more general class

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738423 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sun, 10 Apr 2016 11:16:49 +0000 (11:16 +0000)]

VBA extraction support from bug #52949 from Barry Lagerweij

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738418 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 10 Apr 2016 09:40:40 +0000 (09:40 +0000)]

Bug 57844: Add some javadoc for unimplemented features in SXSSF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738413 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sat, 9 Apr 2016 11:28:12 +0000 (11:28 +0000)]

remove copy&paste error in release-prep

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738352 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Tim Allison [Fri, 8 Apr 2016 14:36:05 +0000 (14:36 +0000)]

close fileinputstream on second exception in ZipPackage

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738251 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Thu, 7 Apr 2016 23:11:22 +0000 (23:11 +0000)]

update release-guide and build.xml to the new release process

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738198 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Thu, 7 Apr 2016 07:25:02 +0000 (07:25 +0000)]

In Example FromHowTo, open the OPCPacakge read-only to not try to write it back on close()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738097 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Wed, 6 Apr 2016 21:32:59 +0000 (21:32 +0000)]

update license - include additional dependencies

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738057 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Wed, 6 Apr 2016 19:50:20 +0000 (19:50 +0000)]

Close two more file-handles in Example FromHowTo

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738035 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Wed, 6 Apr 2016 19:50:14 +0000 (19:50 +0000)]

Tried to evaluate all formulas in worksheets as part of the integration tests, but some documents fail and it probably increases runtime of tests considerably, so left commented out for now.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738034 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Wed, 6 Apr 2016 19:50:08 +0000 (19:50 +0000)]

Bug 58648: Fix handling whitespaces in formulas, unfortunately blank can be the intersection operator as well, so we need to try and skip it as whitespace if intersection fails which can lead to hard to track bugs or misleading error messages with some formulas

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738033 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Wed, 6 Apr 2016 19:49:59 +0000 (19:49 +0000)]

Slightly improve error message
Fix some IntelliJ/compiler warnings
Use common interfaces where possible
Cleanup after testing POIFSDump

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738032 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Wed, 6 Apr 2016 19:49:47 +0000 (19:49 +0000)]

Code cleanup via IntelliJ: Remove unnecessary semicolon

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738031 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Wed, 6 Apr 2016 10:52:36 +0000 (10:52 +0000)]

Add missing license header

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737963 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Wed, 6 Apr 2016 09:00:05 +0000 (09:00 +0000)]

Bug 56911: Fix IndexOutOfBoundsException in PlfLfo.add() and add minimal test, however these classes look quite untested and thus require more test-coverage to make them more robust

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737947 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 6 Apr 2016 06:28:14 +0000 (06:28 +0000)]

Fix javadoc warning - As per http://bugs.java.com/bugdatabase/view_bug.do;jsessionid=d014dfa686594180be40ca5872f5?bug_id=4907024 an @see is only allowed a single link with nothing after it

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737924 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 6 Apr 2016 06:01:26 +0000 (06:01 +0000)]

add test coverage for TestSXSSFCell.toString() on blank and date cells

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737923 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 6 Apr 2016 05:15:15 +0000 (05:15 +0000)]

add test coverage for WorkbookFactory.create(File file, String password, Boolean readOnly) when file does not exists

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737917 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 6 Apr 2016 04:32:36 +0000 (04:32 +0000)]

bug 59264: fix javadocs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737914 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 6 Apr 2016 00:06:53 +0000 (00:06 +0000)]

bug 59264: fix findbugs warning 'A boxed value is unboxed and then immediately reboxed.'

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737896 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 5 Apr 2016 23:47:41 +0000 (23:47 +0000)]

whitespace (tabs to 4 spaces)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737895 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 5 Apr 2016 23:30:37 +0000 (23:30 +0000)]

bug 59264: move border style deprecations to POI 3.15 beta 2.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737894 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 5 Apr 2016 21:38:55 +0000 (21:38 +0000)]

bug 59264: type safety: check if border code is a valid BorderStyle enum for setBorderX(short)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737886 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 5 Apr 2016 21:36:11 +0000 (21:36 +0000)]

bug 59264: allow borders styles to be set with BorderStyles enums or Short codes for backwards compatibility

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737885 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 5 Apr 2016 21:34:24 +0000 (21:34 +0000)]

bug 59264: add link to BorderStyle on deprecated BORDER_* constants

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737884 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 5 Apr 2016 20:28:46 +0000 (20:28 +0000)]

bug 59264: use BorderStyle for changing Cell border line style

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737879 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 4 Apr 2016 23:27:20 +0000 (23:27 +0000)]

bug 59264: copy cell border style codes (from CellStyle.java) into BorderStyle enum

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737752 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 4 Apr 2016 23:26:44 +0000 (23:26 +0000)]

rearrange BORDER_DOTTED and BORDER_HAIR

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737751 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Tim Allison [Mon, 4 Apr 2016 11:44:59 +0000 (11:44 +0000)]

revert test file to original bytes see bug 59257. Thanks to Javen O'Neal for pointing this out and Dominik Stadler for fixing the unit test. Apologies to all for not reading my diff more carefully before committing.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737662 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 3 Apr 2016 23:00:28 +0000 (23:00 +0000)]

prepare for 3.15-beta2

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737620 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 3 Apr 2016 22:59:17 +0000 (22:59 +0000)]

release prepare for 3.15-beta1 - pin documentation

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737618 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 3 Apr 2016 22:58:08 +0000 (22:58 +0000)]

release prepare for 3.15-beta1 - updating build.xml and status.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737617 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 3 Apr 2016 22:25:55 +0000 (22:25 +0000)]

prepare for 3.15-beta2

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737615 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 3 Apr 2016 22:24:01 +0000 (22:24 +0000)]

release prepare for 3.15-beta1 - pin documentation

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737613 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 3 Apr 2016 22:23:21 +0000 (22:23 +0000)]

release prepare for 3.15-beta1 - updating build.xml and status.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737611 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 3 Apr 2016 22:19:44 +0000 (22:19 +0000)]

release prepare for 3.15-beta1 - updating build.xml and status.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737610 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 3 Apr 2016 18:32:22 +0000 (18:32 +0000)]

Bug 55982: Don't fail to open the spreadsheet if no TabIdRecord is found

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737602 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 2 Apr 2016 11:01:56 +0000 (11:01 +0000)]

Fix two more places where wrong/invalid files can lead to file-handle leaks currently

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737489 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 2 Apr 2016 11:01:49 +0000 (11:01 +0000)]

Prevent us from changing the file with every test-run

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737488 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 2 Apr 2016 11:01:43 +0000 (11:01 +0000)]

Fix some cases where file handles are not closed in OldExcelExtractor
Close resources in some more tests to make the file-leak report clean again

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737487 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 2 Apr 2016 06:38:39 +0000 (06:38 +0000)]

Regression: Add unit-test which triggers more code deep inside XSLF to have some missing pieces included in the reduced ooxml-schema-jar

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737466 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 1 Apr 2016 07:17:04 +0000 (07:17 +0000)]

Javadoc fix - Generics are type-erased so not included in the javadoc links

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737317 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Fri, 1 Apr 2016 06:25:49 +0000 (06:25 +0000)]

Enhance integration tests to call some of the common examples/devtools to also trigger these with all sample files, currently XLSX2CSV, BiffViewer, FromHowTo

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737308 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Tim Allison [Fri, 1 Apr 2016 00:57:56 +0000 (00:57 +0000)]

POI 59257 upgrade Bouncy Castle to 1.54

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737298 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Thu, 31 Mar 2016 14:39:11 +0000 (14:39 +0000)]

Bug 57930: Add support for inlineString in FromHowTo
Also do not require an Apache Xerces Parser, let the JDK choose an available one instead

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737247 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Thu, 31 Mar 2016 13:56:27 +0000 (13:56 +0000)]

Adjust integration tests, fix compilation warnings, make the check on "EXPECTED_EXTRACTOR_FAILURES" actually work

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737242 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Thu, 31 Mar 2016 13:32:05 +0000 (13:32 +0000)]

Apply patch from bug 58909 - Add a cloneSheet() which directly sets the sheetname to allow to avoid a costly renaming of sheets.
Combine related unit-tests into Base-Test-Classes to run them for all types of Workbook/Sheet/...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737237 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 30 Mar 2016 21:27:03 +0000 (21:27 +0000)]

Fetch the Ant SVN binding jars if init-svn is called

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737165 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Tue, 29 Mar 2016 18:44:11 +0000 (18:44 +0000)]

DumpPOIFS: Create a separate named sub-directory for each file to not overwrite each other when passing in multiple files for dumping, check for failing mkdirs()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737031 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Tue, 29 Mar 2016 18:11:44 +0000 (18:11 +0000)]

Revert set of inadvertedly committed files/changes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737029 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Tue, 29 Mar 2016 17:30:55 +0000 (17:30 +0000)]

Bug 58915: Add note about memory consumption and update changelog

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737025 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Tue, 29 Mar 2016 17:27:20 +0000 (17:27 +0000)]

Bug 58915: Update javadoc for memory consumption and fix some other javadoc and compiler warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737024 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Tue, 29 Mar 2016 16:11:29 +0000 (16:11 +0000)]

Try to reproduce bug 58922, convert to JUnit 4

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737018 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Tue, 29 Mar 2016 15:45:04 +0000 (15:45 +0000)]

Fix some compiler warnings, improve error message, cover some more code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737013 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Tue, 29 Mar 2016 14:53:44 +0000 (14:53 +0000)]

Bug 59132: Adjust implementation of COUNTBLANK to be conforming to Excel, empty strings are counted as blank as well

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737009 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Mon, 28 Mar 2016 22:52:01 +0000 (22:52 +0000)]

XSLF: do not display Master Slide objects by default
XSLF: fix alternate content handling for picture shapes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736935 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Mon, 28 Mar 2016 22:49:45 +0000 (22:49 +0000)]

some zips can't be opened via ZipFile in JDK6, as the central directory
contains either non-latin entries or the compression type can't be handled
the workaround is to iterate over the stream and not the directory

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736933 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Mon, 28 Mar 2016 22:46:53 +0000 (22:46 +0000)]

sonar fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736932 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 28 Mar 2016 20:22:08 +0000 (20:22 +0000)]

Fix some compiler warnings, javadoc, ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736924 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 28 Mar 2016 20:20:29 +0000 (20:20 +0000)]

Bug 59199: Handle null date-values in a similar way as null-Strings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736923 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 27 Mar 2016 13:09:50 +0000 (13:09 +0000)]

assertCloseDoesNotModifyFile method was adapted from method with the same name in TestWorkbookFactory

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736744 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 27 Mar 2016 13:04:37 +0000 (13:04 +0000)]

add more commented-out tests for bug 58779: closing an XML Workbook that was not opened as read-only will modify the file on disk

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736742 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 27 Mar 2016 05:01:02 +0000 (05:01 +0000)]

make OPCPackage logger final

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736721 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 24 Mar 2016 17:29:00 +0000 (17:29 +0000)]

bug 59224: change hasTint, add hasAlpha and unit tests. Patch from gubespam@gmail.com

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736469 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 24 Mar 2016 06:37:34 +0000 (06:37 +0000)]

make private member variable ctColor final

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736395 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 23 Mar 2016 16:42:04 +0000 (16:42 +0000)]

bug 59222: fix NPE thrown by (S)XSSFSheet.getCellComments(). Reported by Vasily Kopytov.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736347 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 22 Mar 2016 09:22:03 +0000 (09:22 +0000)]

bug 59212: Do not check for overlapping regions when adding merged regions to a sheet

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736165 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 22 Mar 2016 09:02:08 +0000 (09:02 +0000)]

bug 59212: Do not check for overlapping regions when adding merged regions to a sheet

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736155 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Tue, 22 Mar 2016 07:51:39 +0000 (07:51 +0000)]

Check for null in IOUtils.closeQuietly() to not log this unnecessarily
Add coverage for some more methods in ExtractorFactory
Fix some IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736146 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 22 Mar 2016 07:04:51 +0000 (07:04 +0000)]

return unmodifiable shared strings to guarentee parallel data structures stay in sync

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736144 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 22 Mar 2016 04:20:45 +0000 (04:20 +0000)]

bug 59208: correctly understand val="1" for isBold, isItalic, etc

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736126 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 22 Mar 2016 02:31:16 +0000 (02:31 +0000)]

fix inconsistent newlines (remove carriage returns), set svnprop eol-style native

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736121 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Mon, 21 Mar 2016 23:42:56 +0000 (23:42 +0000)]

findbugs fixes - SE_COMPARATOR_SHOULD_BE_SERIALIZABLE

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736114 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Mon, 21 Mar 2016 23:29:06 +0000 (23:29 +0000)]

findbugs fixes - RR_NOT_CHECKED

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736112 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Mon, 21 Mar 2016 20:44:32 +0000 (20:44 +0000)]

another gump run fix (... try)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736091 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Mon, 21 Mar 2016 00:14:21 +0000 (00:14 +0000)]

fix eclipse warnings
close resources

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735912 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 20 Mar 2016 13:36:56 +0000 (13:36 +0000)]

fix eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735881 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 20 Mar 2016 13:15:04 +0000 (13:15 +0000)]

XmlBeans generation still needs the original jar

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735876 13f79535-47bb-0310-9956-ffa450edef68