fix: catch errors in id3parser library

We use a forked version of getID3 to read embedded images from mp3 files to use them as previews.

If the library is unable to extract a image or fails on something different we should handle it properly.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #38434 from nextcloud/release/25.0.7

25.0.7

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

25.0.7

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #38315 from nextcloud/release/25.0.7_rc1

25.0.7 RC1

Merge pull request #38309 from nextcloud/backport/37961/stable25

[stable25] SystemTags endpoint to return tags used by a user with meta data

Merge pull request #38090 from nextcloud/backport/35092/stable25

[stable25] Check return value and improve error handling on certificate manager

Merge pull request #37769 from nextcloud/backport/36217/stable25

[stable25] Handle reminders where calendar name is null

Merge pull request #38074 from nextcloud/stable25-fix-a11y-files-settings

[stable25] Add required accessibility attributes to legacy files navigation

Merge pull request #38132 from nextcloud/backport/36895/stable25

[stable25] Fix json_decode expecting a string

Merge pull request #37850 from nextcloud/backport/37834/stable25

[stable25] Fix TypeError in Profiler

Merge pull request #37832 from nextcloud/backport/37807/stable25

[stable25] Fix background color of external devices with errors on dark color theme

Merge pull request #38249 from nextcloud/fix/read-only-system-addres-book-acls-stable25

[stable25] fix(carddav): Mark system address book as read-only

Merge pull request #37702 from nextcloud/backport/37617/stable25

[stable25] handle not being able to write file for notify self-test

Merge pull request #37569 from nextcloud/backport/34375/stable25

[stable25] fix(dav) Handle Calendar trashbin UID conflicts by removing the deleted calendar object

Merge pull request #37307 from nextcloud/backport/37006/stable25

[stable25] also unmark deleted ldap user when checking the ldap entry

Merge pull request #37720 from nextcloud/backport/37697/stable25

[stable25] Fix button text

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix button text

Signed-off-by: Christopher Ng <chrng8@gmail.com>
(cherry picked from commit 3b94da9c1d9869db35cf8b33da82119d93c1402f)

Merge pull request #38325 from nextcloud/backport/38303/stable25

[stable25] fix(search): fix load more

fix backport

Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #38305 from nextcloud/backport/38143/stable25

[stable25] Fix generated avatars cache

fix(search): fix load more

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

25.0.7 RC1

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: PHP 7.4 compat

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

refactor: remove where specification from SELECT getter

- search constraints are now fully in control of
  SystemTagsInFilesDetector::detectAssignedSystemTagsIn(), avoids
  duplication of a WHERE statement

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

refactor: remove SystemTag logic from Folder into QuerySearchHelper

- adds OC\SystemTag\SystemTagsInFilesDetector where the search logic is
  moved to

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

chore: polish SystemTagsInUseCollection

- DI SystemTagManager
- add some comments and doc
- catch NoUserException
- add return type hints

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: improve naming of new systemtags endpoint to systemtags-assigned

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

feat: specify media type via url path: systemtags-current/$mediaType

- only the media part of the mime type can be search, but not the full
  mime type. It can be added, should it become necessary.
- thus fixes previously hardcoded selector for image/ types
- also fixes a return type hint
- adds a return type hint

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

PoC: SystemTags endpoint to return tags used by a user with meta data

Target case is photos app: when visiting the tags category, all systemtags
of the whole cloud are retrieved. In subequent steps the next tag is
requested until the browser view is filled with tag tiles (i.e. previews
are requested just as well).

With this approach, we incorpoate the dav search and look for user related
tags that are used by them, and already returns the statistics (number of
files tagged with the respective tag) as well as a file id for the purpose
to load the preview. This defaults to the file with the highest id.

Call:
curl -s -u 'user:password' \
  'https://my.nc.srv/remote.php/dav/systemtags-current' \
  -X PROPFIND -H 'Accept: text/plain' \
  -H 'Accept-Language: en-US,en;q=0.5'  -H 'Depth: 1' \
  -H 'Content-Type: text/plain;charset=UTF-8' \
  --data @/home/doe/request-systemtag-props.xml

With request-systemtag-props.xml:
<?xml version="1.0" encoding="UTF-8"?>
<d:propfind xmlns:d="DAV:">
        <d:prop xmlns:oc="http://owncloud.org/ns" xmlns:nc="http://nextcloud.org/ns">
                <oc:id/>
                <oc:display-name/>
                <oc:user-visible/>
                <oc:user-assignable/>
                <oc:can-assign/>
                <nc:files-assigned/>
                <nc:reference-fileid/>
        </d:prop>
</d:propfind>

Example output:
  …
  <d:response>
    <d:href>/master/remote.php/dav/systemtags/84</d:href>
    <d:propstat>
      <d:prop>
        <oc:id>84</oc:id>
        <oc:display-name>Computer</oc:display-name>
        <oc:user-visible>true</oc:user-visible>
        <oc:user-assignable>true</oc:user-assignable>
        <oc:can-assign>true</oc:can-assign>
        <nc:files-assigned>42</nc:files-assigned>
        <nc:reference-fileid>924022</nc:reference-fileid>
      </d:prop>
      <d:status>HTTP/1.1 200 OK</d:status>
    </d:propstat>
  </d:response>
  <d:response>
    <d:href>/remote.php/dav/systemtags/97</d:href>
    <d:propstat>
      <d:prop>
        <oc:id>97</oc:id>
        <oc:display-name>Bear</oc:display-name>
        <oc:user-visible>true</oc:user-visible>
        <oc:user-assignable>true</oc:user-assignable>
        <oc:can-assign>true</oc:can-assign>
        <nc:files-assigned>1</nc:files-assigned>
        <nc:reference-fileid>923422</nc:reference-fileid>
      </d:prop>
      <d:status>HTTP/1.1 200 OK</d:status>
    </d:propstat>
  </d:response>
  …

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

adjust patch

Signed-off-by: jld3103 <jld3103yt@gmail.com>

adjust patch

Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: Simon L. <szaimen@e.mail.de>

Clear generated avatar caches

Signed-off-by: jld3103 <jld3103yt@gmail.com>

Properly clear cached avatars

Signed-off-by: jld3103 <jld3103yt@gmail.com>

Merge pull request #38276 from nextcloud/backport/38274/stable25

[stable25] fix(middleware): Also abort the request when reaching max delay in af…

Merge pull request #38258 from nextcloud/backport/38242/stable25

[stable25] Fix incosistent scrolling in Firefox

Merge pull request #38269 from nextcloud/backport/38267/stable25

[stable25] fix(lostpassword): Also rate limit the setPassword endpoint

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #38282 from nextcloud/session-auth-check-username-25

[25] check the username when doing external storage session auth

Fix incosistent scrolling in Firefox

Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

check the username when doing external storage session auth

Signed-off-by: Robin Appelman <robin@icewind.nl>

fix(middleware): Also abort the request when reaching max delay in afterController

Signed-off-by: Joas Schilling <coding@schilljs.com>

fix(tests): Adjust unit tests

Signed-off-by: Joas Schilling <coding@schilljs.com>

fix(lostpassword): Also rate limit the setPassword endpoint

Signed-off-by: Joas Schilling <coding@schilljs.com>

Add required accessibility attributes to legacy files navigation

Co-authored-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Merge pull request #38203 from nextcloud/backport/36893/stable25

[stable25] Make sure to never trigger files hooks on a null path

Merge pull request #38236 from nextcloud/automated/noid/stable25-update-psalm-baseline

[stable25] Update psalm-baseline.xml

fix(carddav): Mark system address book as read-only

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #38239 from nextcloud/backport/37709/stable25

Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix: Check for wrapped retriable exceptions

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #36618 from nextcloud/backport/36417

[stable25] Backport: Make the container fully fulfill PSR container interface

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Make sure to never trigger files hooks on a null path

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Update autoloader

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>

fix: Throw `NotFoundExceptionInterface` to fulfill PSR container interface if class not found

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>

chore: Update 3rdparty to update psr/container to 1.1.2

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>

Merge pull request #38129 from nextcloud/backport/36774/stable25

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

tests: Adapt node related unit tests mocks to required root view

Signed-off-by: Julius Härtl <jus@bitgrid.net>

fix: Use proper path when creating node instances

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Update Checker.php

Signed-off-by: Ilya Apasov <apasov@users.noreply.github.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #38084 from nextcloud/backport/37148/stable25

[stable25] increase imaginary timeouts as for big files the processing could take very long

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix conflicts

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

Merge pull request #38071 from nextcloud/backport/37480/stable25

[stable25] fix(ocp): Add deprecation version to ILogFactory::getCustomLogger

[BUGFIX] throw exception instead of error if unable to create file handler (only exceptions are catch)

Signed-off-by: Jan Messer <jan@mtec-studios.ch>

[BUGFIX] check return value and improve error handling

With S3 primary storage there was a problem with getting the CA bundle from the storage without having the CA bundle for the connection which causes that the CertificateManager was throwing an Error.
This commit improves the handling in CertificateManager and log unexpected behaviors.

Signed-off-by: Jan Messer <jan@mtec-studios.ch>

increase imaginary timeouts as for big files the processing could take very long

Signed-off-by: Simon L <szaimen@e.mail.de>

Merge pull request #38052 from nextcloud/backport/38045/stable25

fix(ocp): Add deprecation version to ILogFactory::getCustomLogger

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #38044 from nextcloud/backport/37787/stable25

Merge pull request #37996 from nextcloud/backport/37909/stable25

[stable25] Update crl after revoke shifts.csr

fix: catch ManuallyLockedException and use app context

The files_lock app may throw ManuallyLockedExceptions
when attempting to revert a file that is currently opened.
This would prevent the user from rolling back a opened file.

Text and Richdocuments handle changes of the file while editing.
Allow reverting files even when they are locked by these apps
and let the apps handle the conflict.

Signed-off-by: Max <max@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Compile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

fix(AppMenu): On bright color theme the app icons in the overflow menu must be inverted

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #38039 from nextcloud/backport/33106/stable25

[stable25] Update expire_date column of table comments

Cover expire_date with unit tests

Signed-off-by: Vitor Mattos <vitor@php.rio>

Update expire_date column of table comments

Signed-off-by: Vitor Mattos <vitor@php.rio>