]> source.dussan.org Git - gitea.git/log
gitea.git
2 months agoRemove unneccessary uses of `word-break: break-all` (#31637)
silverwind [Wed, 17 Jul 2024 10:04:28 +0000 (12:04 +0200)]
Remove unneccessary uses of `word-break: break-all` (#31637)

Fixes: https://github.com/go-gitea/gitea/issues/31636
1. Issue sidebar topic is disussed in
https://github.com/go-gitea/gitea/issues/31636
2. Org description already has `overflow-wrap: anywhere` to ensure no
overflow.

Co-authored-by: Giteabot <teabot@gitea.io>
3 months ago[skip ci] Updated translations via Crowdin
GiteaBot [Wed, 17 Jul 2024 00:27:54 +0000 (00:27 +0000)]
[skip ci] Updated translations via Crowdin

3 months agoAllow searching issues by ID (#31479)
Carsten Klein [Tue, 16 Jul 2024 22:49:05 +0000 (00:49 +0200)]
Allow searching issues by ID (#31479)

When you are entering a number in the issue search, you likely want the
issue with the given ID (code internal concept: issue index).
As such, when a number is detected, the issue with the corresponding ID
will now be added to the results.

Fixes #4479

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
3 months agoallow synchronizing user status from OAuth2 login providers (#31572)
Rowan Bohde [Tue, 16 Jul 2024 18:33:16 +0000 (13:33 -0500)]
allow synchronizing user status from OAuth2 login providers (#31572)

This leverages the existing `sync_external_users` cron job to
synchronize the `IsActive` flag on users who use an OAuth2 provider set
to synchronize. This synchronization is done by checking for expired
access tokens, and using the stored refresh token to request a new
access token. If the response back from the OAuth2 provider is the
`invalid_grant` error code, the user is marked as inactive. However, the
user is able to reactivate their account by logging in the web browser
through their OAuth2 flow.

Also changed to support this is that a linked `ExternalLoginUser` is
always created upon a login or signup via OAuth2.

### Notes on updating permissions
Ideally, we would also refresh permissions from the configured OAuth
provider (e.g., admin, restricted and group mappings) to match the
implementation of LDAP. However, the OAuth library used for this `goth`,
doesn't seem to support issuing a session via refresh tokens. The
interface provides a [`RefreshToken`
method](https://github.com/markbates/goth/blob/master/provider.go#L20),
but the returned `oauth.Token` doesn't implement the `goth.Session` we
would need to call `FetchUser`. Due to specific implementations, we
would need to build a compatibility function for every provider, since
they cast to concrete types (e.g.
[Azure](https://github.com/markbates/goth/blob/master/providers/azureadv2/azureadv2.go#L132))

---------

Co-authored-by: Kyle D <kdumontnu@gmail.com>
3 months agoEnable `no-jquery/no-class-state` (#31639)
silverwind [Tue, 16 Jul 2024 10:14:27 +0000 (12:14 +0200)]
Enable `no-jquery/no-class-state` (#31639)

Just 4 validations and I specifically tested this by
selecting/unselecting issue labels.

Co-authored-by: Giteabot <teabot@gitea.io>
3 months agoAdded default sorting milestones by name (#27084)
Bartlomiej Komendarczuk [Tue, 16 Jul 2024 08:08:54 +0000 (10:08 +0200)]
Added default sorting milestones by name (#27084)

#26996
Added default sorting for milestones by name.
Additional, name for sorting closestduedate and furthestduedate was
broken, so I fixed it.

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
3 months agoCode editor theme enhancements (#31629)
silverwind [Sun, 14 Jul 2024 23:22:48 +0000 (01:22 +0200)]
Code editor theme enhancements (#31629)

1. Fixed border-radius
2. Monaco ignores the alpha channel on the shadow color, introduce
`color-shadow-opaque`
3. Remove scrollbar color which follows
https://github.com/go-gitea/gitea/pull/29800

Before:

<img width="34" alt="Screenshot 2024-07-13 at 15 38 18"
src="https://github.com/user-attachments/assets/042d9bde-6db9-4467-a2a4-8f61ecc773eb">
<img width="35" alt="Screenshot 2024-07-13 at 15 38 31"
src="https://github.com/user-attachments/assets/04146ee0-551c-4ff2-9636-bd119b33595a">

After:

<img width="45" alt="Screenshot 2024-07-13 at 15 38 06"
src="https://github.com/user-attachments/assets/1f58fa5a-1289-4e45-83c9-18ca82a5e266">
<img width="39" alt="Screenshot 2024-07-13 at 21 16 56"
src="https://github.com/user-attachments/assets/e12ebe22-b29b-4798-9f0d-4c100f311562">

3 months agoAdd option to change mail from user display name (#31528)
6543 [Sun, 14 Jul 2024 21:27:00 +0000 (14:27 -0700)]
Add option to change mail from user display name (#31528)

Make it posible to let mails show e.g.:

`Max Musternam (via gitea.kithara.com) <gitea@kithara.com>`

Docs: https://gitea.com/gitea/docs/pulls/23

---
*Sponsored by Kithara Software GmbH*

3 months agoUpgrade xorm to v1.3.9 and improve some migrations Sync (#29899)
Lunny Xiao [Sun, 14 Jul 2024 21:15:59 +0000 (05:15 +0800)]
Upgrade xorm to v1.3.9 and improve some migrations Sync (#29899)

Co-authored-by: 6543 <6543@obermui.de>
3 months agoIssue Templates: add option to have dropdown printed list (#31577)
6543 [Sun, 14 Jul 2024 14:38:45 +0000 (07:38 -0700)]
Issue Templates: add option to have dropdown printed list (#31577)

Issue template dropdown can have many entries, and it could be better to
have them rendered as list later on if multi-select is enabled.

so this adds an option to the issue template engine to do so.

DOCS: https://gitea.com/gitea/docs/pulls/19

---

## demo:

```yaml
name: Name
title: Title
about: About
labels: ["label1", "label2"]
ref: Ref
body:
  - type: dropdown
    id: id6
    attributes:
      label: Label of dropdown (list)
      description: Description of dropdown
      multiple: true
      list: true
      options:
        - Option 1 of dropdown
        - Option 2 of dropdown
        - Option 3 of dropdown
        - Option 4 of dropdown
        - Option 5 of dropdown
        - Option 6 of dropdown
        - Option 7 of dropdown
        - Option 8 of dropdown
        - Option 9 of dropdown
```

![image](https://github.com/user-attachments/assets/102ed0f4-89da-420b-ab2a-1788b59676f9)

![image](https://github.com/user-attachments/assets/a2bdb14e-43ff-4cc6-9bbe-20244830453c)

---
*Sponsored by Kithara Software GmbH*

3 months agoFix update flake (#31626)
6543 [Fri, 12 Jul 2024 16:25:54 +0000 (09:25 -0700)]
Fix update flake (#31626)

3 months ago[skip ci] Updated translations via Crowdin
GiteaBot [Fri, 12 Jul 2024 00:27:07 +0000 (00:27 +0000)]
[skip ci] Updated translations via Crowdin

3 months agoDisplay app name in the registration email title (#31562)
Sunny Wan [Thu, 11 Jul 2024 23:23:31 +0000 (19:23 -0400)]
Display app name in the registration email title (#31562)

I changed the title of the registation email from "Welcome to Gitea" to
"Welcome to (appname)". I did this by substituting 'Gitea' in
register_notify to %s and formating the registration title in mail.go. I
changed this for all the languages I could, but I struggled to changed
the translation file for Farsi. I have attached the screenshots of
before and after and the related issue below.

Related issue:
https://github.com/go-gitea/gitea/issues/31108

Before change:
![Screenshot from 2024-07-04
22-32-17](https://github.com/go-gitea/gitea/assets/94445569/4178b51c-1acc-45f4-9750-dff41564a709)

After:
![Screenshot from 2024-07-04
22-32-01](https://github.com/go-gitea/gitea/assets/94445569/9cd7a58d-c0f5-4a3c-a66c-805c55411eaa)

---------

Signed-off-by: Sunny Wan <Sunnywan2020@gmail.com>
Co-authored-by: 6543 <6543@obermui.de>
3 months agotypo on date in security document (#31617)
techknowlogick [Thu, 11 Jul 2024 21:51:08 +0000 (17:51 -0400)]
typo on date in security document (#31617)

3 months agoUpdate JS dependencies (#31616)
silverwind [Thu, 11 Jul 2024 18:36:02 +0000 (20:36 +0200)]
Update JS dependencies (#31616)

Result of `make update-js`. Tested all dependencies. Lockfile diff is
because of https://github.com/npm/cli/pull/7475.

3 months agoAdd types for js globals (#31586)
silverwind [Thu, 11 Jul 2024 10:20:51 +0000 (12:20 +0200)]
Add types for js globals (#31586)

Adds types for `window.config` and jQuery/htmx globals, eliminating 48
`tsc` errors.

3 months agoUpgrade security public key (#31594)
Lunny Xiao [Wed, 10 Jul 2024 16:28:22 +0000 (00:28 +0800)]
Upgrade security public key (#31594)

Fix #31591

3 months agoFix wrong merge on removing docs (#31605)
Lunny Xiao [Wed, 10 Jul 2024 15:47:32 +0000 (23:47 +0800)]
Fix wrong merge on removing docs (#31605)

3 months agoRefactor webhook (#31587)
wxiaoguang [Wed, 10 Jul 2024 11:37:16 +0000 (19:37 +0800)]
Refactor webhook (#31587)

A more complete fix for #31588

1. Make "generic" code more readable
2. Clarify HTML or Markdown for the payload content

3 months agoFix: Allow org team names of length 255 in create team form (#31564)
Tobias Balle-Petersen [Wed, 10 Jul 2024 02:15:17 +0000 (04:15 +0200)]
Fix: Allow org team names of length 255 in create team form (#31564)

Gitea 1.22.1 was supposed to allow for team names of length 255 (up from
30) after the following PR was merged in:
https://github.com/go-gitea/gitea/pull/31410. However, the length of
team names was still limited to 30 as described in this issue:
https://github.com/go-gitea/gitea/issues/31554.

One more change to _gitea_ needs to be made to allow for the longer team
names, as there is a 30 character limit here:
https://github.com/go-gitea/gitea/blob/2c92c7c5226e29636a1d47a277130f477fa2037b/services/forms/org.go#L65

This PR changes that value to 255.

3 months agoRemove docs sub folder since docs has been moved to https://gitea.com/gitea/docs...
Lunny Xiao [Wed, 10 Jul 2024 01:46:08 +0000 (09:46 +0800)]
Remove docs sub folder since docs has been moved to https://gitea.com/gitea/docs (#31536)

3 months agoAdd bohde as maintainer (#31601)
Kyle D [Wed, 10 Jul 2024 00:18:35 +0000 (20:18 -0400)]
Add bohde as maintainer (#31601)

[4 merged
PRs](https://github.com/go-gitea/gitea/pulls?q=is%3Apr+author%3Abohde+is%3Aclosed)


3 months agoAdd `YEAR`, `MONTH`, `MONTH_ENGLISH`, `DAY` variables for template repos (#31584)
delvh [Tue, 9 Jul 2024 18:05:12 +0000 (20:05 +0200)]
Add `YEAR`, `MONTH`, `MONTH_ENGLISH`, `DAY` variables for template repos (#31584)

Fixes #31583

3 months agoAllow disabling authentication related user features (#31535)
Rowan Bohde [Tue, 9 Jul 2024 17:36:31 +0000 (12:36 -0500)]
Allow disabling authentication related user features (#31535)

We have some instances that only allow using an external authentication
source for authentication. In this case, users changing their email,
password, or linked OpenID connections will not have any effect, and
we'd like to prevent showing that to them to prevent confusion.

Included in this are several changes to support this:
* A new setting to disable user managed authentication credentials
(email, password & OpenID connections)
* A new setting to disable user managed MFA (2FA codes & WebAuthn)
* Fix an issue where some templates had separate logic for determining
if a feature was disabled since it didn't check the globally disabled
features
* Hide more user setting pages in the navbar when their settings aren't
enabled

---------

Co-authored-by: Kyle D <kdumontnu@gmail.com>
3 months agoAdd back esbuild-loader for .js files (#31585)
silverwind [Tue, 9 Jul 2024 09:28:43 +0000 (11:28 +0200)]
Add back esbuild-loader for .js files (#31585)

The build currently seems to work fine without this, but in theory it
should fail because Fomantic is JavaScript. I feel more comfortable
having this loader declared.

Note: I did try using the [combined loader
config](https://github.com/privatenumber/esbuild-loader#-quick-setup)
but when I did that, vue files could not load, so I think this is the
best option.

3 months agoUse FullName in Emails to address the recipient if possible (#31527)
6543 [Mon, 8 Jul 2024 08:38:45 +0000 (01:38 -0700)]
Use FullName in Emails to address the recipient if possible (#31527)

Before we had just the plain mail address as recipient. But now we
provide additional Information for the Mail clients.

---
*Sponsored by Kithara Software GmbH*

3 months agoDon't show hidden labels when filling out an issue template (#31576)
6543 [Mon, 8 Jul 2024 04:31:12 +0000 (21:31 -0700)]
Don't show hidden labels when filling out an issue template (#31576)

Related to #31574

---
*Sponsored by Kithara Software GmbH*

3 months ago[skip ci] Updated translations via Crowdin
GiteaBot [Mon, 8 Jul 2024 00:28:11 +0000 (00:28 +0000)]
[skip ci] Updated translations via Crowdin

3 months agoConvert frontend code to typescript (#31559)
silverwind [Sun, 7 Jul 2024 15:32:30 +0000 (17:32 +0200)]
Convert frontend code to typescript (#31559)

None of the frontend js/ts files was touched besides these two commands
(edit: no longer true, I touched one file in
https://github.com/go-gitea/gitea/pull/31559/commits/61105d0618e285d97e95044bfb64415f364a4526
because of a deprecation that was not showing before the rename).

`tsc` currently reports 778 errors, so I have disabled it in CI as
planned.

Everything appears to work fine.

3 months ago[skip ci] Updated translations via Crowdin
GiteaBot [Sun, 7 Jul 2024 00:29:37 +0000 (00:29 +0000)]
[skip ci] Updated translations via Crowdin

3 months ago[skip ci] Updated translations via Crowdin
GiteaBot [Sat, 6 Jul 2024 00:26:24 +0000 (00:26 +0000)]
[skip ci] Updated translations via Crowdin

3 months agoAllow force push to protected branches (#28086)
Henry Goodman [Fri, 5 Jul 2024 18:21:56 +0000 (04:21 +1000)]
Allow force push to protected branches (#28086)

Fixes #22722

### Problem
Currently, it is not possible to force push to a branch with branch
protection rules in place. There are often times where this is necessary
(CI workflows/administrative tasks etc).

The current workaround is to rename/remove the branch protection,
perform the force push, and then reinstate the protections.

### Solution
Provide an additional section in the branch protection rules to allow
users to specify which users with push access can also force push to the
branch. The default value of the rule will be set to `Disabled`, and the
UI is intuitive and very similar to the `Push` section.

It is worth noting in this implementation that allowing force push does
not override regular push access, and both will need to be enabled for a
user to force push.

This applies to manual force push to a remote, and also in Gitea UI
updating a PR by rebase (which requires force push)

This modifies the `BranchProtection` API structs to add:
- `enable_force_push bool`
- `enable_force_push_whitelist bool`
- `force_push_whitelist_usernames string[]`
- `force_push_whitelist_teams string[]`
- `force_push_whitelist_deploy_keys bool`

### Updated Branch Protection UI:

<img width="943" alt="image"
src="https://github.com/go-gitea/gitea/assets/79623665/7491899c-d816-45d5-be84-8512abd156bf">

### Pull Request `Update branch by Rebase` option enabled with source
branch `test` being a protected branch:

![image](https://github.com/go-gitea/gitea/assets/79623665/e018e6e9-b7b2-4bd3-808e-4947d7da35cc)
<img width="1038" alt="image"
src="https://github.com/go-gitea/gitea/assets/79623665/57ead13e-9006-459f-b83c-7079e6f4c654">

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
3 months agoRefactor login page (#31530)
Anbraten [Fri, 5 Jul 2024 17:10:09 +0000 (19:10 +0200)]
Refactor login page (#31530)

As requested in
https://github.com/go-gitea/gitea/pull/31504#issuecomment-2196196646.
This PR refactor the login page:

![Screenshot from 2024-07-04
19-23-10](https://github.com/go-gitea/gitea/assets/6918444/c45700f4-6747-473c-bdee-2156718a7953)

![Screenshot from 2024-07-04
19-23-21](https://github.com/go-gitea/gitea/assets/6918444/b1bf71cf-85f9-4517-a409-cc6d72e6af8f)

![Screenshot from 2024-06-30
09-35-20](https://github.com/go-gitea/gitea/assets/6918444/728cc37e-0cca-4883-afec-a43663d2c666)

# Changes
- [x] use separate box for passkey login and go to registration
- [x] move forgot passoword next to password label
- [x] fix password required label `*` and padding
- [x] remove tabs from login page

---------

Co-authored-by: silverwind <me@silverwind.io>
3 months agoFix slow patch checking with commits that add or remove many files (#31548)
Brecht Van Lommel [Thu, 4 Jul 2024 18:57:11 +0000 (20:57 +0200)]
Fix slow patch checking with commits that add or remove many files (#31548)

Running git update-index for every individual file is slow, so add and
remove everything with a single git command.

When such a big commit lands in the default branch, it could cause PR
creation and patch checking for all open PRs to be slow, or time out
entirely. For example, a commit that removes 1383 files was measured to
take more than 60 seconds and timed out. With this change checking took
about a second.

This is related to #27967, though this will not help with commits that
change many lines in few files.

3 months agoAdd typescript guideline and typescript-specific eslint plugins and fix issues (...
silverwind [Wed, 3 Jul 2024 15:48:14 +0000 (17:48 +0200)]
Add typescript guideline and typescript-specific eslint plugins and fix issues (#31521)

1. Add some general guidelines how to write our typescript code
2. Add `@typescript-eslint/eslint-plugin`, general typescript rules
3. Add `eslint-plugin-deprecation` to detect deprecated code
4. Fix all new lint issues that came up

3 months agoUpdate `golang.org/x/image` to v0.18.0 (#31541)
silverwind [Tue, 2 Jul 2024 19:41:14 +0000 (21:41 +0200)]
Update `golang.org/x/image` to v0.18.0 (#31541)

Result of `go get -u  golang.org/x/image && make tidy`

Fixes: https://github.com/go-gitea/gitea/security/dependabot/67
3 months ago[skip ci] Updated translations via Crowdin
GiteaBot [Mon, 1 Jul 2024 00:30:50 +0000 (00:30 +0000)]
[skip ci] Updated translations via Crowdin

3 months agoFix markdown preview $$ support (#31514)
charles [Sat, 29 Jun 2024 23:23:47 +0000 (07:23 +0800)]
Fix markdown preview $$ support (#31514)

close #31481

currently `$$A + B$$ test` will ignore text after $$ block

test text

![圖片](https://github.com/go-gitea/gitea/assets/30816317/39b2974b-c0b6-48a0-87d0-5f4a13615eed)

before fix

![圖片](https://github.com/go-gitea/gitea/assets/30816317/15469e4c-474d-4128-b46f-d6cadaafbd68)

after fix

![圖片](https://github.com/go-gitea/gitea/assets/30816317/c1025eef-177f-4ade-988f-510e7039f3f9)

github display

![圖片](https://github.com/go-gitea/gitea/assets/30816317/97cd1e10-ac94-4899-86d8-8e359ef1d694)

3 months agoAdd Passkey login support (#31504)
Anbraten [Sat, 29 Jun 2024 22:50:03 +0000 (00:50 +0200)]
Add Passkey login support (#31504)

closes #22015

After adding a passkey, you can now simply login with it directly by
clicking `Sign in with a passkey`.

![Screenshot from 2024-06-26
12-18-17](https://github.com/go-gitea/gitea/assets/6918444/079013c0-ed70-481c-8497-4427344bcdfc)

Note for testing. You need to run gitea using `https` to get the full
passkeys experience.

---------

Co-authored-by: silverwind <me@silverwind.io>
3 months agoUse stable version of fabric (#31526)
silverwind [Sat, 29 Jun 2024 15:37:18 +0000 (17:37 +0200)]
Use stable version of fabric (#31526)

Fabric 6 is [now
stable](https://github.com/fabricjs/fabric.js/releases/tag/v6.0.0-rc5),
use it.

3 months agoAlways use HTML attributes for avatar size (#31509)
silverwind [Fri, 28 Jun 2024 21:29:15 +0000 (23:29 +0200)]
Always use HTML attributes for avatar size (#31509)

Many avatars were rendered in HTML with certain width/height but then
resized again in CSS. This was pointless so I removed all these cases
and made the HTML size match the previous render size.

Also did a few CSS cleanups in the tribute rendering:

<img width="648" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/cb2fafb3-5e20-46e9-814f-07df20038beb">

3 months agoAdd initial typescript config and use it for eslint,vitest,playwright (#31186)
silverwind [Fri, 28 Jun 2024 16:15:51 +0000 (18:15 +0200)]
Add initial typescript config and use it for eslint,vitest,playwright (#31186)

This enables eslint to use the typescript parser and resolver which
brings some benefits that eslint rules now have type information
available and a tsconfig.json is required for the upcoming typescript
migration as well. Notable changes done:

- Add typescript parser and resolver
- Move the vue-specific config into the root file
- Enable `vue-scoped-css/enforce-style-type` rule, there was only one
violation and I added a inline disable there.
- Fix new lint errors that were detected because of the parser change
- Update `i/no-unresolved` to remove now-unnecessary workaround for the
resolver
- Disable `i/no-named-as-default` as it seems to raise bogus issues in
the webpack config
- Change vitest config to typescript
- Change playwright config to typescript
- Add `eslint-plugin-playwright` and fix issues
- Add `tsc` linting to `make lint-js`

3 months agoSupport legacy _links LFS batch responses (#31513)
Royce Remer [Fri, 28 Jun 2024 08:42:57 +0000 (01:42 -0700)]
Support legacy _links LFS batch responses (#31513)

Support legacy _links LFS batch response.

Fixes #31512.

This is backwards-compatible change to the LFS client so that, upon
mirroring from an upstream which has a batch api, it can download
objects whether the responses contain the `_links` field or its
successor the `actions` field. When Gitea must fallback to the legacy
`_links` field a logline is emitted at INFO level which looks like this:
```
...s/lfs/http_client.go:188:performOperation() [I] <LFSPointer ee95d0a27ccdfc7c12516d4f80dcf144a5eaf10d0461d282a7206390635cdbee:160> is using a deprecated batch schema response!
```

I've only run `test-backend` with this code, but added a new test to
cover this case. Additionally I have a fork with this change deployed
which I've confirmed syncs LFS from Gitea<-Artifactory (which has legacy
`_links`) as well as from Gitea<-Gitea (which has the modern `actions`).

Signed-off-by: Royce Remer <royceremer@gmail.com>
3 months agoFix JS error with disabled attachment and easymde (#31511)
silverwind [Fri, 28 Jun 2024 05:59:22 +0000 (07:59 +0200)]
Fix JS error with disabled attachment and easymde (#31511)

Not sure if this is a regression from
https://github.com/go-gitea/gitea/pull/30513, but when attachments are
disabled, `this.dropzone` is null and the code had failed in
`initEasyMDEPaste` trying to access `dropzoneEl.dropzone`.

3 months agoFix avatar radius problem on the new issue page (#31506)
charles [Thu, 27 Jun 2024 14:04:05 +0000 (22:04 +0800)]
Fix avatar radius problem on the new issue page (#31506)

Close #31502

Related to #31419.

In this PR, the avatar width is set to 3em, but the height is not set,
so the image is not squared.

When object-fit is set to contain, it can't maintain the radius of the
image.

Result:

![圖片](https://github.com/go-gitea/gitea/assets/30816317/bceb98aa-b0f7-4753-bc8b-3b9c41dfd55a)

3 months agoMake toast support preventDuplicates (#31501)
wxiaoguang [Thu, 27 Jun 2024 13:58:38 +0000 (21:58 +0800)]
Make toast support preventDuplicates (#31501)

make preventDuplicates default to true, users get a clear UI feedback
and know that "a new message appears".

Fixes: https://github.com/go-gitea/gitea/issues/26651
---------

Co-authored-by: silverwind <me@silverwind.io>
3 months agoImprove attachment upload methods (#30513)
Tyrone Yeh [Thu, 27 Jun 2024 09:31:49 +0000 (17:31 +0800)]
Improve attachment upload methods (#30513)

* Use dropzone to handle file uploading for all cases, including pasting
and dragging
* Merge duplicate code, use consistent behavior for link generating

Close #20130

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
3 months agoRefactor issue label selection (#31497)
wxiaoguang [Wed, 26 Jun 2024 23:41:59 +0000 (07:41 +0800)]
Refactor issue label selection (#31497)

Follow #26460

3 months agoRefactor dropzone (#31482)
wxiaoguang [Wed, 26 Jun 2024 17:01:20 +0000 (01:01 +0800)]
Refactor dropzone (#31482)

Refactor the legacy code and remove some jQuery calls.

3 months ago[skip ci] Updated translations via Crowdin
GiteaBot [Wed, 26 Jun 2024 00:26:17 +0000 (00:26 +0000)]
[skip ci] Updated translations via Crowdin

3 months agoOptimization of labels handling in issue_search (#26460)
Chl [Tue, 25 Jun 2024 17:09:13 +0000 (19:09 +0200)]
Optimization of labels handling in issue_search (#26460)

This PR enhances the labels handling in issue_search by optimizing the
SQL query and de-duplicate the IDs when generating the query string.

---------

Co-authored-by: techknowlogick <techknowlogick@gitea.com>
3 months agouse correct l10n string (#31487)
CyberFlame [Tue, 25 Jun 2024 14:54:18 +0000 (02:54 +1200)]
use correct l10n string (#31487)

Uses the correct string for searching - this is what it looks like prior
to the change:

![image](https://github.com/go-gitea/gitea/assets/24910512/38519825-c347-44d6-85d4-6fa3c71ddb7c)
(observe how the top box has "Search teams" even though collaborator
would be user

3 months agoFix overflow menu flickering on mobile (#31484)
Brecht Van Lommel [Tue, 25 Jun 2024 14:24:15 +0000 (16:24 +0200)]
Fix overflow menu flickering on mobile (#31484)

The overflow menu button was incorrectly included in the measurement of
the width of the items. As a result, it could get stuck in a loop
alternating between different measurements as the button appears and
disappears.

3 months ago[skip ci] Updated translations via Crowdin
GiteaBot [Tue, 25 Jun 2024 00:26:08 +0000 (00:26 +0000)]
[skip ci] Updated translations via Crowdin

3 months agoFix poor table column width due to breaking words (#31473)
Brecht Van Lommel [Mon, 24 Jun 2024 17:48:43 +0000 (19:48 +0200)]
Fix poor table column width due to breaking words (#31473)

Caused by #31091

---------

Co-authored-by: silverwind <me@silverwind.io>
3 months agobump golang deps (#31422)
techknowlogick [Mon, 24 Jun 2024 13:26:42 +0000 (09:26 -0400)]
bump golang deps (#31422)

3 months agoDisable issue/PR comment button given empty input (#31463)
Kemal Zebari [Sun, 23 Jun 2024 18:41:01 +0000 (11:41 -0700)]
Disable issue/PR comment button given empty input (#31463)

Given an empty issue/PR comment, the comment history would not be
updated if the user were to submit it. Therefore, it would make since to
just disable the comment button when the text editor is empty.

This is inline with what GitHub does when given empty text editor input.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
3 months agoSimplify 404/500 page (#31409)
wxiaoguang [Sun, 23 Jun 2024 17:45:21 +0000 (01:45 +0800)]
Simplify 404/500 page (#31409)

3 months agoFix web notification icon not updated once you read all notifications (#31447)
kiatt210 [Sun, 23 Jun 2024 07:50:10 +0000 (09:50 +0200)]
Fix web notification icon not updated once you read all notifications (#31447)

Fix #29065
Remove status filtering from GetUIDsAndNotificationCounts sql.

---------

Co-authored-by: kiatt210 <kiatt210@github.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
3 months agoSwitch to "Write" tab when edit comment again (#31445)
wxiaoguang [Sat, 22 Jun 2024 09:25:04 +0000 (17:25 +0800)]
Switch to "Write" tab when edit comment again (#31445)

Fix #19031

3 months agoAdd simple JS init performance trace (#31459)
wxiaoguang [Sat, 22 Jun 2024 09:20:20 +0000 (17:20 +0800)]
Add simple JS init performance trace (#31459)

Related to #23461, and help some cases like #31412

For developers, they could use browser's Performance tool to collect
performance data, while this PR is also quite handy to optimize the
`index.js`.

For end users, this PR is simple enough and could figure out the slow
function quickly.

![image](https://github.com/go-gitea/gitea/assets/2114189/a557b08e-6594-474b-81a3-03d5ac2bd68e)

3 months agoRefactor image diff (#31444)
wxiaoguang [Sat, 22 Jun 2024 04:52:09 +0000 (12:52 +0800)]
Refactor image diff (#31444)

And remove some jQuery functions

3 months ago[skip ci] Updated translations via Crowdin
GiteaBot [Sat, 22 Jun 2024 00:25:47 +0000 (00:25 +0000)]
[skip ci] Updated translations via Crowdin

3 months agoSupport relative paths to videos from Wiki pages (#31061)
Sergey Sharybin [Fri, 21 Jun 2024 18:23:54 +0000 (20:23 +0200)]
Support relative paths to videos from Wiki pages (#31061)

This change fixes cases when a Wiki page refers to a video stored in the
Wiki repository using relative path. It follows the similar case which
has been already implemented for images.

Test plan:
- Create repository and Wiki page
- Clone the Wiki repository
- Add video to it, say `video.mp4`
- Modify the markdown file to refer to the video using `<video
src="video.mp4">`
- Commit the Wiki page
- Observe that the video is properly displayed

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
3 months agoFix deprecated Dockerfile ENV format (#31450)
silverwind [Fri, 21 Jun 2024 15:08:42 +0000 (17:08 +0200)]
Fix deprecated Dockerfile ENV format (#31450)

See
https://docs.docker.com/reference/build-checks/legacy-key-value-format/.
Fixes these warnings seen during the docker build:

```
 4 warnings found (use --debug to expand):
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 5)
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 9)
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 75)
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 76)
 ```

Introduced in: https://github.com/moby/buildkit/pull/4923

3 months agoREADME Badge maintenance (#31441)
silverwind [Fri, 21 Jun 2024 13:18:39 +0000 (15:18 +0200)]
README Badge maintenance (#31441)

1. Remove tickgit badge, the service [only gives
errors](https://www.tickgit.com/browse?repo=github.com/go-gitea/gitea&branch=main)
and the repo [seems
unmaintained](https://github.com/augmentable-dev/tickgit).
2. Color the gitpod badge green because grey badges look odd.

3 months agoImprove markdown textarea for indentation and lists (#31406)
wxiaoguang [Fri, 21 Jun 2024 08:14:40 +0000 (16:14 +0800)]
Improve markdown textarea for indentation and lists (#31406)

Almost works like GitHub

* use Tab/Shift-Tab to indent/unindent the selected lines
* use Enter to insert a new line with the same indentation and prefix

3 months agoSplit common-global.js into separate files (#31438)
wxiaoguang [Fri, 21 Jun 2024 07:40:33 +0000 (15:40 +0800)]
Split common-global.js into separate files (#31438)

To improve maintainability

3 months agoFix the link for .git-blame-ignore-revs bypass (#31432)
wxiaoguang [Thu, 20 Jun 2024 23:28:34 +0000 (07:28 +0800)]
Fix the link for .git-blame-ignore-revs bypass (#31432)

A quick fix for #31429

3 months agoBump htmx to 2.0.0 (#31413)
Yarden Shoham [Thu, 20 Jun 2024 20:04:09 +0000 (23:04 +0300)]
Bump htmx to 2.0.0 (#31413)

Tested Subscribe, Follow, Star, Watch, and System Status.

---------

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
3 months agoFix the wrong line number in the diff view page when expanded twice. (#31431)
charles [Thu, 20 Jun 2024 17:43:42 +0000 (01:43 +0800)]
Fix the wrong line number in the diff view page when expanded twice. (#31431)

close #31149, regression of #29385 (incorrect `data-query=`)

3 months agoFix labels and projects menu overflow on issue page (#31435)
Brecht Van Lommel [Thu, 20 Jun 2024 16:54:19 +0000 (18:54 +0200)]
Fix labels and projects menu overflow on issue page (#31435)

It was correct only on the new issue page.

Resolves #31415

3 months ago[Fix] Account Linking UpdateMigrationsByType (#31428)
Sumit [Thu, 20 Jun 2024 13:24:53 +0000 (18:54 +0530)]
[Fix] Account Linking UpdateMigrationsByType  (#31428)

Fix https://github.com/go-gitea/gitea/issues/31427

3 months agoFix markdown math brackets render problem (#31420)
charles [Thu, 20 Jun 2024 02:12:54 +0000 (10:12 +0800)]
Fix markdown math brackets render problem (#31420)

Close #31371, support `($ ... $)` like GitHub

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
3 months agoReduce `air` verbosity (#31417)
silverwind [Wed, 19 Jun 2024 19:42:06 +0000 (21:42 +0200)]
Reduce `air` verbosity (#31417)

Make `air` log less. Uses the option added in
https://github.com/air-verse/air/pull/367.

3 months agoFix new issue/pr avatar (#31419)
silverwind [Wed, 19 Jun 2024 16:19:59 +0000 (18:19 +0200)]
Fix new issue/pr avatar (#31419)

The avatar on "New Issue" and "New Pull Request" pages was inconsistent.
Removed the extra margin and the new CSS rules now use common parent
`<form id="#new-issue">` because `.repository.new.issue` is not present
on pull request page.

3 months agoIncrease max length of org team names from 30 to 255 characters (#31410)
Tobias Balle-Petersen [Wed, 19 Jun 2024 14:36:09 +0000 (16:36 +0200)]
Increase max length of org team names from 30 to 255 characters (#31410)

This PR modifies the structs for editing and creating org teams to allow
team names to be up to 255 characters. The previous maximum length was
30 characters.

3 months ago[skip ci] Updated translations via Crowdin
GiteaBot [Wed, 19 Jun 2024 00:26:25 +0000 (00:26 +0000)]
[skip ci] Updated translations via Crowdin

3 months agoRefactor names (#31405)
wxiaoguang [Tue, 18 Jun 2024 22:32:45 +0000 (06:32 +0800)]
Refactor names (#31405)

This PR only does "renaming":

* `Route` should be `Router` (and chi router is also called "router")
* `Params` should be `PathParam` (to distingush it from URL query param, and to match `FormString`)
* Use lower case for private functions to avoid exposing or abusing

3 months agoUpdate JS dependencies, remove `eslint-plugin-jquery` (#31402)
silverwind [Tue, 18 Jun 2024 08:10:30 +0000 (10:10 +0200)]
Update JS dependencies, remove `eslint-plugin-jquery` (#31402)

- Result of `make update-js`
- Added 1 new eslint rule
- Autofixed 1 new eslint issue
- Remove `eslint-plugin-jquery` as `eslint-plugin-no-jquery` does all it
does and is actually the maintained fork of it.
- Tested all affected `dependencies`

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
3 months agoSwitch to upstream of `gorilla/feeds` (#31400)
Yarden Shoham [Tue, 18 Jun 2024 08:05:28 +0000 (11:05 +0300)]
Switch to upstream of `gorilla/feeds` (#31400)

They merged the PR we waited for.

- Reference: https://github.com/gorilla/feeds/pull/107
- Follows: https://github.com/go-gitea/gitea/pull/28860

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
3 months agoFix rendered wiki page link (#31398)
wxiaoguang [Tue, 18 Jun 2024 03:09:20 +0000 (11:09 +0800)]
Fix rendered wiki page link (#31398)

Fix #31395

3 months agoRefactor repo unit "disabled" check (#31389)
wxiaoguang [Tue, 18 Jun 2024 00:51:13 +0000 (08:51 +0800)]
Refactor repo unit "disabled" check (#31389)

1. There are already global "unit consts", no need to use context data, which is fragile
2. Remove the "String()" method from "unit", it would only cause rendering problems in templates

---------

Co-authored-by: silverwind <me@silverwind.io>
3 months agoRefactor route path normalization (#31381)
wxiaoguang [Mon, 17 Jun 2024 23:28:47 +0000 (07:28 +0800)]
Refactor route path normalization (#31381)

Refactor route path normalization and decouple it from the chi router.
Fix the TODO, fix the legacy strange path behavior.

3 months agoRefactor markup code (#31399)
wxiaoguang [Mon, 17 Jun 2024 22:56:45 +0000 (06:56 +0800)]
Refactor markup code (#31399)

1. use clearer names
2. remove deadcode
3. avoid name shadowing
4. eliminate some lint warnings

3 months agoAdd cache test for admins (#31265)
6543 [Mon, 17 Jun 2024 19:22:39 +0000 (21:22 +0200)]
Add cache test for admins (#31265)

Add a test to probe the cache similar to the email test func.

![image](https://github.com/go-gitea/gitea/assets/24977596/700e2733-586d-4091-900f-f5f71e6e94bf)

![image](https://github.com/go-gitea/gitea/assets/24977596/2a953802-18fc-4e81-a37d-24ebe1297365)

![image](https://github.com/go-gitea/gitea/assets/24977596/e00d62ad-bb60-41cc-9138-09993daee156)

---------

Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: silverwind <me@silverwind.io>
3 months agoFix double border in system status table (#31363)
silverwind [Mon, 17 Jun 2024 13:21:59 +0000 (15:21 +0200)]
Fix double border in system status table (#31363)

Fix regression from https://github.com/go-gitea/gitea/pull/30712 where
the introduction of this `<div>` caused the `.ui.attached:not(.message)
+ .ui.attached.segment:not(.top)` CSS selector to no longer work and
cause a double border.

Before:

<img width="200" alt="Screenshot 2024-06-13 at 19 06 12"
src="https://github.com/go-gitea/gitea/assets/115237/a9fa0688-adf0-4b2d-a958-6a7679a62031">

After:
<img width="232" alt="Screenshot 2024-06-13 at 19 05 57"
src="https://github.com/go-gitea/gitea/assets/115237/025b780f-f72f-4049-86de-a5d84851bd1d">

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
3 months agoImprove rubygems package registry (#31357)
wxiaoguang [Mon, 17 Jun 2024 08:42:46 +0000 (16:42 +0800)]
Improve rubygems package registry (#31357)

To make it work with Bundler:
https://guides.rubygems.org/rubygems-org-compact-index-api/

It only adds 2 new API endpoints and improves some tests, existing logic
is not changed.

3 months agoFix natural sort (#31384)
wxiaoguang [Mon, 17 Jun 2024 06:45:12 +0000 (14:45 +0800)]
Fix natural sort (#31384)

Fix #31374

3 months agoFix missing images in editor preview due to wrong links (#31299)
Brecht Van Lommel [Mon, 17 Jun 2024 06:16:14 +0000 (08:16 +0200)]
Fix missing images in editor preview due to wrong links (#31299)

Parse base path and tree path so that media links can be correctly
created with /media/.

Resolves #31294

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
3 months agoAdd a simple test for AdoptRepository (#31391)
wxiaoguang [Mon, 17 Jun 2024 01:18:35 +0000 (09:18 +0800)]
Add a simple test for AdoptRepository (#31391)

Follow #31333

3 months ago[skip ci] Updated licenses and gitignores
GiteaBot [Mon, 17 Jun 2024 00:27:39 +0000 (00:27 +0000)]
[skip ci] Updated licenses and gitignores

4 months agoFix JS error when creating new issue (#31383)
wxiaoguang [Sun, 16 Jun 2024 02:07:21 +0000 (10:07 +0800)]
Fix JS error when creating new issue (#31383)

Fix #31336

4 months ago[skip ci] Updated translations via Crowdin
GiteaBot [Sun, 16 Jun 2024 00:28:50 +0000 (00:28 +0000)]
[skip ci] Updated translations via Crowdin

4 months agoRename repo_model.SearchOrderByMap to repo_model.OrderByMap (#31359)
6543 [Sat, 15 Jun 2024 06:45:02 +0000 (08:45 +0200)]
Rename repo_model.SearchOrderByMap to repo_model.OrderByMap (#31359)

https://github.com/go-gitea/gitea/pull/30876#discussion_r1637112394

4 months agorm const do inline (#31360)
6543 [Sat, 15 Jun 2024 04:48:52 +0000 (06:48 +0200)]
rm const do inline (#31360)

https://github.com/go-gitea/gitea/pull/30876/files#r1637288202

4 months agoAllow downloading attachments of draft releases (#31369)
Zettat123 [Sat, 15 Jun 2024 04:20:14 +0000 (12:20 +0800)]
Allow downloading attachments of draft releases (#31369)

Fix #31362

4 months agoFix duplicate sub-path for avatars (#31365)
wxiaoguang [Sat, 15 Jun 2024 03:43:57 +0000 (11:43 +0800)]
Fix duplicate sub-path for avatars (#31365)

Fix #31361, and add tests

And this PR introduces an undocumented & debug-purpose-only config
option: `USE_SUB_URL_PATH`. It does nothing for end users, it only helps
the development of sub-path related problems.

And also fix #31366

Co-authored-by: @ExplodingDragon
4 months ago[skip ci] Updated translations via Crowdin
GiteaBot [Sat, 15 Jun 2024 00:26:00 +0000 (00:26 +0000)]
[skip ci] Updated translations via Crowdin

4 months agoAdd tag protection via rest api #17862 (#31295)
mzroot [Fri, 14 Jun 2024 16:56:10 +0000 (19:56 +0300)]
Add tag protection via rest api #17862 (#31295)

Add tag protection manage via rest API.

---------

Co-authored-by: Alexander Kogay <kogay.a@citilink.ru>
Co-authored-by: Giteabot <teabot@gitea.io>