]> source.dussan.org Git - nextcloud-server.git/log
nextcloud-server.git
5 years ago[tx-robot] updated from transifex
Nextcloud bot [Mon, 31 Dec 2018 01:12:01 +0000 (01:12 +0000)]
[tx-robot] updated from transifex

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Sun, 30 Dec 2018 01:13:01 +0000 (01:13 +0000)]
[tx-robot] updated from transifex

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Sat, 29 Dec 2018 01:12:01 +0000 (01:12 +0000)]
[tx-robot] updated from transifex

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Fri, 28 Dec 2018 01:12:07 +0000 (01:12 +0000)]
[tx-robot] updated from transifex

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Thu, 27 Dec 2018 01:12:01 +0000 (01:12 +0000)]
[tx-robot] updated from transifex

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Wed, 26 Dec 2018 01:12:16 +0000 (01:12 +0000)]
[tx-robot] updated from transifex

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Tue, 25 Dec 2018 01:11:54 +0000 (01:11 +0000)]
[tx-robot] updated from transifex

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Mon, 24 Dec 2018 01:12:08 +0000 (01:12 +0000)]
[tx-robot] updated from transifex

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Sun, 23 Dec 2018 01:12:46 +0000 (01:12 +0000)]
[tx-robot] updated from transifex

5 years agoMerge pull request #12617 from nextcloud/backport/10839/stable14
Roeland Jago Douma [Sat, 22 Dec 2018 11:15:05 +0000 (12:15 +0100)]
Merge pull request #12617 from nextcloud/backport/10839/stable14

[stable14] adjust Calendar resource / room interfaces to use class implementation

5 years agoMerge pull request #13216 from nextcloud/backport/13212/stable14
Roeland Jago Douma [Sat, 22 Dec 2018 09:35:08 +0000 (10:35 +0100)]
Merge pull request #13216 from nextcloud/backport/13212/stable14

[stable14] Files list not rendering if user has favorites navigation unfolded

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Sat, 22 Dec 2018 01:12:06 +0000 (01:12 +0000)]
[tx-robot] updated from transifex

5 years agoMerge pull request #13219 from nextcloud/backport/13187/stable14
blizzz [Fri, 21 Dec 2018 15:58:17 +0000 (16:58 +0100)]
Merge pull request #13219 from nextcloud/backport/13187/stable14

[stable14] do not forgot to store the second displayname portion

5 years agodo not forgot to store the second displayname portion 13219/head
Arthur Schiwon [Thu, 20 Dec 2018 22:11:00 +0000 (23:11 +0100)]
do not forgot to store the second displayname portion

otherwise it causes a chain reaction of system addressbook updates

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
5 years agoMerge pull request #13207 from nextcloud/backport/13154/stable14
Roeland Jago Douma [Fri, 21 Dec 2018 13:22:56 +0000 (14:22 +0100)]
Merge pull request #13207 from nextcloud/backport/13154/stable14

[stable14] Fix ie11 checkboxes

5 years agoReplace ChildNode.before with custom before helper 13216/head
Julius Härtl [Fri, 21 Dec 2018 11:03:34 +0000 (12:03 +0100)]
Replace ChildNode.before with custom before helper

Signed-off-by: Julius Härtl <jus@bitgrid.net>
5 years agoFix ie11 checkboxes 13207/head
John Molakvoæ (skjnldsv) [Wed, 19 Dec 2018 10:31:10 +0000 (11:31 +0100)]
Fix ie11 checkboxes

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
5 years ago[tx-robot] updated from transifex
Nextcloud bot [Fri, 21 Dec 2018 01:12:05 +0000 (01:12 +0000)]
[tx-robot] updated from transifex

5 years agoMerge pull request #13180 from nextcloud/backport/13171/stable14
Roeland Jago Douma [Thu, 20 Dec 2018 19:38:02 +0000 (20:38 +0100)]
Merge pull request #13180 from nextcloud/backport/13171/stable14

[stable14] Use a case insensitive search for email

5 years agoUse a case insensitive search for email 13180/head
Roeland Jago Douma [Thu, 20 Dec 2018 10:09:10 +0000 (11:09 +0100)]
Use a case insensitive search for email

Fixes #7084
Now entering wrongly cased email (roeland@ instead of Roeland@) for
password reset etc. Will also work.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
5 years ago[tx-robot] updated from transifex
Nextcloud bot [Thu, 20 Dec 2018 01:12:03 +0000 (01:12 +0000)]
[tx-robot] updated from transifex

5 years agoMerge pull request #13152 from nextcloud/backport/13133/stable14
John Molakvoæ [Wed, 19 Dec 2018 10:22:01 +0000 (11:22 +0100)]
Merge pull request #13152 from nextcloud/backport/13133/stable14

[stable14] Prevent special characters from breaking the file drop remote url

5 years agoPrevent special characters from breaking the file drop remote url 13152/head
John Molakvoæ (skjnldsv) [Tue, 18 Dec 2018 08:17:49 +0000 (09:17 +0100)]
Prevent special characters from breaking the file drop remote url

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
5 years ago[tx-robot] updated from transifex
Nextcloud bot [Wed, 19 Dec 2018 01:12:05 +0000 (01:12 +0000)]
[tx-robot] updated from transifex

5 years agoMerge pull request #13124 from nextcloud/backport/13118/stable14
Roeland Jago Douma [Tue, 18 Dec 2018 15:20:01 +0000 (16:20 +0100)]
Merge pull request #13124 from nextcloud/backport/13118/stable14

[stable14] Fix SAML Client login flow on Apple devices

5 years agoMerge pull request #13120 from nextcloud/backport/12693/stable14
Julius Härtl [Tue, 18 Dec 2018 09:48:53 +0000 (10:48 +0100)]
Merge pull request #13120 from nextcloud/backport/12693/stable14

[stable14] fix exception on LDAP mapping during login

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Tue, 18 Dec 2018 01:11:52 +0000 (01:11 +0000)]
[tx-robot] updated from transifex

5 years agoFix SAML Client login flow on Apple devices 13124/head
Roeland Jago Douma [Mon, 17 Dec 2018 11:50:32 +0000 (12:50 +0100)]
Fix SAML Client login flow on Apple devices

Because the redirect from the SAML/SSO endpoint is a POST the lax/strict
cookies are not properly send.

Note that it is not strictly requried on this endpoint as we do not need
the remember me data. Only the real session info is enough. The endpoint
is also already protected by a state token.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
5 years agoMerge pull request #13077 from nextcloud/stb14-ie11-compatibility-updatenotifications
Roeland Jago Douma [Mon, 17 Dec 2018 12:26:18 +0000 (13:26 +0100)]
Merge pull request #13077 from nextcloud/stb14-ie11-compatibility-updatenotifications

[stable14] Ie11 compatibility updatenotifications

5 years agoLDAP clear cache on config modification also when done via API or CLI 13120/head
Arthur Schiwon [Sun, 16 Dec 2018 23:31:27 +0000 (00:31 +0100)]
LDAP clear cache on config modification also when done via API or CLI

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
5 years agorun LDAP integrations tests with redis which is the recommended setup
Arthur Schiwon [Mon, 3 Dec 2018 13:34:03 +0000 (14:34 +0100)]
run LDAP integrations tests with redis which is the recommended setup

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
5 years agobe careful with mixed return values even if it may look unsuspicious…
Arthur Schiwon [Tue, 27 Nov 2018 16:09:55 +0000 (17:09 +0100)]
be careful with mixed return values even if it may look unsuspicious…

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
5 years agocache users as existing after mapping
Arthur Schiwon [Tue, 27 Nov 2018 16:06:48 +0000 (17:06 +0100)]
cache users as existing after mapping

during login they might be cached as non-existing and cause an Exception
in the long run

reduces some duplication, too

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
5 years ago[tx-robot] updated from transifex
Nextcloud bot [Mon, 17 Dec 2018 01:11:50 +0000 (01:11 +0000)]
[tx-robot] updated from transifex

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Sun, 16 Dec 2018 01:12:51 +0000 (01:12 +0000)]
[tx-robot] updated from transifex

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Sat, 15 Dec 2018 01:11:56 +0000 (01:11 +0000)]
[tx-robot] updated from transifex

5 years agoTranspile arrow function for ie11 compatibility 13077/head
John Molakvoæ (skjnldsv) [Fri, 14 Dec 2018 15:49:00 +0000 (16:49 +0100)]
Transpile arrow function for ie11 compatibility

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
5 years ago[tx-robot] updated from transifex
Nextcloud bot [Fri, 14 Dec 2018 01:12:50 +0000 (01:12 +0000)]
[tx-robot] updated from transifex

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Thu, 13 Dec 2018 01:12:16 +0000 (01:12 +0000)]
[tx-robot] updated from transifex

5 years agoMerge pull request #13037 from nextcloud/settings-ie11-fixes
Roeland Jago Douma [Wed, 12 Dec 2018 16:56:35 +0000 (17:56 +0100)]
Merge pull request #13037 from nextcloud/settings-ie11-fixes

[stable14] Settings ie11 fixes

5 years agoMerge branch 'stable14' of https://github.com/nextcloud/server into settings-ie11... 13037/head
John Molakvoæ (skjnldsv) [Wed, 12 Dec 2018 15:45:08 +0000 (16:45 +0100)]
Merge branch 'stable14' of https://github.com/nextcloud/server into settings-ie11-fixes

5 years agoIE11 compatibility for users management
John Molakvoæ (skjnldsv) [Wed, 12 Dec 2018 15:23:33 +0000 (16:23 +0100)]
IE11 compatibility for users management

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
5 years agoMerge pull request #13030 from nextcloud/backport/13009/stable14
Roeland Jago Douma [Wed, 12 Dec 2018 14:52:37 +0000 (15:52 +0100)]
Merge pull request #13030 from nextcloud/backport/13009/stable14

[stable14] Better activities for systemtags that are removed by CLI

5 years agoBetter activities for systemtags that are removed by CLI 13030/head
Joas Schilling [Tue, 11 Dec 2018 15:13:33 +0000 (16:13 +0100)]
Better activities for systemtags that are removed by CLI

Signed-off-by: Joas Schilling <coding@schilljs.com>
5 years ago[tx-robot] updated from transifex
Nextcloud bot [Wed, 12 Dec 2018 01:11:55 +0000 (01:11 +0000)]
[tx-robot] updated from transifex

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Tue, 11 Dec 2018 01:12:05 +0000 (01:12 +0000)]
[tx-robot] updated from transifex

5 years agoMerge pull request #12749 from nextcloud/backport/12424/stable14
Christoph Wurst [Mon, 10 Dec 2018 08:46:12 +0000 (09:46 +0100)]
Merge pull request #12749 from nextcloud/backport/12424/stable14

[stable14] Add pipe mode for sendmail

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Mon, 10 Dec 2018 01:11:56 +0000 (01:11 +0000)]
[tx-robot] updated from transifex

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Sun, 9 Dec 2018 01:12:45 +0000 (01:12 +0000)]
[tx-robot] updated from transifex

5 years agoApply patch from @cwiedmann but drop -oi option for pipe 12749/head
Carsten Wiedmann [Mon, 12 Nov 2018 22:26:35 +0000 (23:26 +0100)]
Apply patch from @cwiedmann but drop -oi option for pipe

* Add sendmailmode to gui
* Add testcases for pipe mode

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
5 years agoMerge pull request #12739 from nextcloud/stable14-12408
John Molakvoæ [Sat, 8 Dec 2018 10:13:17 +0000 (11:13 +0100)]
Merge pull request #12739 from nextcloud/stable14-12408

[stable14] Make sure to always load the latest icons-vars.css file

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Sat, 8 Dec 2018 01:11:42 +0000 (01:11 +0000)]
[tx-robot] updated from transifex

5 years agoMake sure to always load the latest icons-vars.css file 12739/head
Julius Härtl [Mon, 12 Nov 2018 10:00:56 +0000 (11:00 +0100)]
Make sure to always load the latest icons-vars.css file

Signed-off-by: Julius Härtl <jus@bitgrid.net>
5 years agoMerge pull request #12914 from nextcloud/backport/12897/stable14
Morris Jobke [Fri, 7 Dec 2018 15:12:44 +0000 (16:12 +0100)]
Merge pull request #12914 from nextcloud/backport/12897/stable14

[stable14] Fix unread comment icon not shown for the sharee

5 years agoIf the parent is not cached we should request the file 12914/head
Roeland Jago Douma [Thu, 6 Dec 2018 20:59:28 +0000 (21:59 +0100)]
If the parent is not cached we should request the file

Else we ignore all incomming shares. Which basically does :boom:

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
5 years agoAdd acceptance tests for comments on shared files and folders
Daniel Calviño Sánchez [Wed, 28 Nov 2018 11:37:52 +0000 (12:37 +0100)]
Add acceptance tests for comments on shared files and folders

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
5 years ago[tx-robot] updated from transifex
Nextcloud bot [Fri, 7 Dec 2018 01:12:00 +0000 (01:12 +0000)]
[tx-robot] updated from transifex

5 years agoMerge pull request #12860 from nextcloud/fix/stable14-fix-password-confirmation-ie11
Roeland Jago Douma [Thu, 6 Dec 2018 08:02:43 +0000 (09:02 +0100)]
Merge pull request #12860 from nextcloud/fix/stable14-fix-password-confirmation-ie11

[stable14] Fix password confirmation lib for ie11

5 years agoMerge pull request #12869 from nextcloud/backport/12857/stable14
Roeland Jago Douma [Thu, 6 Dec 2018 07:30:31 +0000 (08:30 +0100)]
Merge pull request #12869 from nextcloud/backport/12857/stable14

[stable14] Emit write update only once on touch

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Thu, 6 Dec 2018 01:12:21 +0000 (01:12 +0000)]
[tx-robot] updated from transifex

5 years agoMerge pull request #12862 from nextcloud/backport/12855/stable14
Morris Jobke [Wed, 5 Dec 2018 23:05:49 +0000 (00:05 +0100)]
Merge pull request #12862 from nextcloud/backport/12855/stable14

[stable14] Only execute query in propagateChange once

5 years agoEmit write update only once on touch 12869/head
Roeland Jago Douma [Wed, 5 Dec 2018 20:29:48 +0000 (21:29 +0100)]
Emit write update only once on touch

When a touch is done (i.e. when creating a new file in the node API)
The hooks contain 'write' and 'touch' (and the operation is touch as
well). This would cause a double write update. Which doesn't make sense.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
5 years agoOnly execute query in propagateChange once 12862/head
Roeland Jago Douma [Wed, 5 Dec 2018 19:32:02 +0000 (20:32 +0100)]
Only execute query in propagateChange once

The second execute statement should be inside the if block. Else it gets
executed twice which makes no sense.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
5 years agoFix password confirmation lib for ie11 12860/head
Christoph Wurst [Wed, 5 Dec 2018 20:36:43 +0000 (21:36 +0100)]
Fix password confirmation lib for ie11

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
5 years agoMerge pull request #12850 from nextcloud/stb14-missing-click-apps-update
Roeland Jago Douma [Wed, 5 Dec 2018 20:08:16 +0000 (21:08 +0100)]
Merge pull request #12850 from nextcloud/stb14-missing-click-apps-update

[stable14] Fix missing click event on update button

5 years agoFix missing click event on update button 12850/head
Julius Härtl [Tue, 4 Dec 2018 14:08:51 +0000 (15:08 +0100)]
Fix missing click event on update button

Signed-off-by: Julius Härtl <jus@bitgrid.net>
5 years agoMerge pull request #12834 from nextcloud/backport/12831/stable14
Morris Jobke [Wed, 5 Dec 2018 08:35:03 +0000 (09:35 +0100)]
Merge pull request #12834 from nextcloud/backport/12831/stable14

[stable14] Do not update child all child shares on group share update

5 years agoMerge pull request #12817 from nextcloud/backport/12813/stable14
Roeland Jago Douma [Wed, 5 Dec 2018 07:42:29 +0000 (08:42 +0100)]
Merge pull request #12817 from nextcloud/backport/12813/stable14

[stable14] Fix the system address book

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Wed, 5 Dec 2018 01:12:15 +0000 (01:12 +0000)]
[tx-robot] updated from transifex

5 years agoDo not update child all child shares on group share update 12834/head
Roeland Jago Douma [Tue, 4 Dec 2018 19:55:14 +0000 (20:55 +0100)]
Do not update child all child shares on group share update

Else we overwrite the whole share for link shares. Basically breaking
them.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
5 years agoMerge pull request #12826 from nextcloud/backport/12822/stable14
Roeland Jago Douma [Tue, 4 Dec 2018 19:12:48 +0000 (20:12 +0100)]
Merge pull request #12826 from nextcloud/backport/12822/stable14

[stable14] PHP module is named mbstring

5 years agoPHP module is named mbstring 12826/head
Morris Jobke [Tue, 4 Dec 2018 16:22:11 +0000 (17:22 +0100)]
PHP module is named mbstring

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
5 years agoFix the system address book 12817/head
Roeland Jago Douma [Tue, 4 Dec 2018 12:33:03 +0000 (13:33 +0100)]
Fix the system address book

c23a66cda46d9a1f0ce8dc60a6c160809c87d9f6 broke the system address book.
We now move the ACL rules for this special case up and all is good in
the world again.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
5 years agoMerge pull request #12748 from nextcloud/backport/14/11200/stable14
Roeland Jago Douma [Tue, 4 Dec 2018 14:03:11 +0000 (15:03 +0100)]
Merge pull request #12748 from nextcloud/backport/14/11200/stable14

[stable14] Fix interaction with groups that contain a slash

5 years agoMerge pull request #12812 from nextcloud/backport/12808/stable14
Roeland Jago Douma [Tue, 4 Dec 2018 13:50:43 +0000 (14:50 +0100)]
Merge pull request #12812 from nextcloud/backport/12808/stable14

[stable14] Only run the AnonymousOptionsPlugion on Anonymous requests

5 years agoOnly run the AnonymousOptionsPlugion on Anonymous requests 12812/head
Roeland Jago Douma [Tue, 4 Dec 2018 10:55:04 +0000 (11:55 +0100)]
Only run the AnonymousOptionsPlugion on Anonymous requests

Fixes #12744

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
5 years ago[tx-robot] updated from transifex
Nextcloud bot [Tue, 4 Dec 2018 01:12:26 +0000 (01:12 +0000)]
[tx-robot] updated from transifex

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Mon, 3 Dec 2018 01:11:52 +0000 (01:11 +0000)]
[tx-robot] updated from transifex

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Sun, 2 Dec 2018 01:12:56 +0000 (01:12 +0000)]
[tx-robot] updated from transifex

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Sat, 1 Dec 2018 01:11:47 +0000 (01:11 +0000)]
[tx-robot] updated from transifex

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Fri, 30 Nov 2018 01:12:17 +0000 (01:12 +0000)]
[tx-robot] updated from transifex

5 years agoMerge pull request #12745 from nextcloud/backport/12647/stable14
Morris Jobke [Thu, 29 Nov 2018 21:44:57 +0000 (22:44 +0100)]
Merge pull request #12745 from nextcloud/backport/12647/stable14

[stable14] update compatible versions for cloud federation api

5 years agoFix interaction with groups that contain a slash 12748/head
Joas Schilling [Thu, 13 Sep 2018 08:04:45 +0000 (10:04 +0200)]
Fix interaction with groups that contain a slash

Signed-off-by: Joas Schilling <coding@schilljs.com>
5 years agoupdate compatible versions for cloud federation api 12745/head
Robin Appelman [Fri, 23 Nov 2018 14:26:32 +0000 (15:26 +0100)]
update compatible versions for cloud federation api

Signed-off-by: Robin Appelman <robin@icewind.nl>
5 years agoMerge pull request #12738 from nextcloud/backport/12690/stable14
Roeland Jago Douma [Thu, 29 Nov 2018 18:35:42 +0000 (19:35 +0100)]
Merge pull request #12738 from nextcloud/backport/12690/stable14

[stable14] Set Referrer-Policy also in addSecurityHeaders()

5 years agoSet Referrer-Policy also in addSecurityHeaders() 12738/head
Peter Kraume [Tue, 27 Nov 2018 15:34:54 +0000 (16:34 +0100)]
Set Referrer-Policy also in addSecurityHeaders()

Fix: #12689
Signed-off-by: Peter Kraume <peter.kraume@gmx.de>
5 years ago[tx-robot] updated from transifex
Nextcloud bot [Thu, 29 Nov 2018 01:11:52 +0000 (01:11 +0000)]
[tx-robot] updated from transifex

5 years agoMerge pull request #12715 from nextcloud/backport/12708/stable14
Morris Jobke [Wed, 28 Nov 2018 22:05:42 +0000 (23:05 +0100)]
Merge pull request #12715 from nextcloud/backport/12708/stable14

[stable14] Fix folder path containing leading slash when getting mount root by id

5 years agoFix folder path containing leading slash when getting mount root by id 12715/head
Robin Appelman [Wed, 28 Nov 2018 14:18:29 +0000 (15:18 +0100)]
Fix folder path containing leading slash when getting mount root by id

This fixes collabora on public link shared groupfolders

Fixes https://github.com/nextcloud/groupfolders/issues/225

Signed-off-by: Robin Appelman <robin@icewind.nl>
5 years agoMerge pull request #12701 from nextcloud/stable14-12632-add-acceptance-tests-for...
Daniel Kesselberg [Wed, 28 Nov 2018 13:11:55 +0000 (14:11 +0100)]
Merge pull request #12701 from nextcloud/stable14-12632-add-acceptance-tests-for-sharing-files-and-folders-with-another-user

[stable14] Add acceptance tests for sharing files and folders with another user

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Wed, 28 Nov 2018 01:12:15 +0000 (01:12 +0000)]
[tx-robot] updated from transifex

5 years agoMerge pull request #12697 from nextcloud/backport/12649/stable14
Daniel Kesselberg [Tue, 27 Nov 2018 20:25:10 +0000 (21:25 +0100)]
Merge pull request #12697 from nextcloud/backport/12649/stable14

[stable14] Make acceptance tests for comments more robust

5 years agoWait for the comment to be added before changing to another file 12697/head
Daniel Calviño Sánchez [Sat, 24 Nov 2018 17:16:09 +0000 (18:16 +0100)]
Wait for the comment to be added before changing to another file

If the server is too slow, changing to a different file immediately
after sending a new comment but without waiting for the comment to be
shown for the original file could cause the new comment to be shown for
the current file instead.

This is, indeed, a bug in the comments. However, it is not possible to
test it reliably in the acceptance tests, as it depends on how fast the
server adds the message and how fast the client changes to a different
file; sometimes the test would fail and sometimes it would not.

Therefore, now it is waited for the comment to be added before changing
to another file, as in this case it can be reliably tested that changing
to a different file does not cause the comments from the previous file
to be shown in the current file (this was a different bug already fixed
and due to which this test was added in the first place).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
5 years agoWait for the empty content element to be shown
Daniel Calviño Sánchez [Sat, 24 Nov 2018 17:06:20 +0000 (18:06 +0100)]
Wait for the empty content element to be shown

When the "Comments" tab is open the empty content element is always in
the DOM, although it is only shown once the message collection was
fetched and there were no messages. Due to this it is necessary to
explicitly wait for it to be shown instead of relying on the implicit
wait made to find the element; otherwise it would be found immediately
and if the collection was not fetched yet it would not be visible,
causing the test to fail.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
5 years agoMerge pull request #12684 from nextcloud/backport/12650/stable14
Roeland Jago Douma [Tue, 27 Nov 2018 15:28:56 +0000 (16:28 +0100)]
Merge pull request #12684 from nextcloud/backport/12650/stable14

[stable14] Fix count on string

5 years agoAdd return type 12684/head
Daniel Kesselberg [Sun, 25 Nov 2018 11:30:54 +0000 (12:30 +0100)]
Add return type

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
5 years agoFix count on string
Daniel Kesselberg [Sat, 24 Nov 2018 21:06:45 +0000 (22:06 +0100)]
Fix count on string

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
5 years ago[tx-robot] updated from transifex
Nextcloud bot [Tue, 27 Nov 2018 01:11:51 +0000 (01:11 +0000)]
[tx-robot] updated from transifex

5 years agoMerge pull request #12639 from nextcloud/backport/12556/stable14
Morris Jobke [Mon, 26 Nov 2018 10:02:46 +0000 (11:02 +0100)]
Merge pull request #12639 from nextcloud/backport/12556/stable14

[stable14] extend anonymous options to work on every dav url

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Mon, 26 Nov 2018 01:11:41 +0000 (01:11 +0000)]
[tx-robot] updated from transifex