]> source.dussan.org Git - sonarqube.git/log
sonarqube.git
16 months agoSONAR-19365 fix SSF-398 - backport to 9.9 LTS
Pierre [Tue, 30 May 2023 08:25:26 +0000 (10:25 +0200)]
SONAR-19365 fix SSF-398 - backport to 9.9 LTS

17 months agoSONAR-19156 Add tests to regular QA loop
Dimitris Kavvathas [Wed, 3 May 2023 15:15:51 +0000 (17:15 +0200)]
SONAR-19156 Add tests to regular QA loop

17 months agoREL-2633 Update next SonarQube LTS version
Léo Geoffroy [Fri, 28 Apr 2023 09:32:41 +0000 (11:32 +0200)]
REL-2633  Update next SonarQube LTS version

17 months agoSONAR-18872 improve total ncloc computation 9.9.1.69595
Pierre [Tue, 28 Mar 2023 08:16:41 +0000 (10:16 +0200)]
SONAR-18872 improve total ncloc computation

17 months agoSONAR-19097 fix SSF-384
Dimitris Kavvathas [Wed, 26 Apr 2023 08:15:08 +0000 (10:15 +0200)]
SONAR-19097 fix SSF-384

17 months agoSONAR-19091 Fix SSF-383
Jacek Poreda [Mon, 24 Apr 2023 09:47:40 +0000 (11:47 +0200)]
SONAR-19091 Fix SSF-383

(cherry picked from commit 9708d98955560e51ecc3d1089a7d68e81277114c)

18 months agoBUILD-2798 Move after_failure expressions to condition
Jeremy Davis [Wed, 5 Apr 2023 15:44:14 +0000 (17:44 +0200)]
BUILD-2798 Move after_failure expressions to condition

18 months agoSONAR-18587 upgrade text analyzers to 2.0.2.1090
Philippe Perrin [Thu, 30 Mar 2023 09:27:04 +0000 (11:27 +0200)]
SONAR-18587 upgrade text analyzers to 2.0.2.1090

18 months ago[SONAR-18502] move validation of drop index param
Steve Marion [Wed, 22 Feb 2023 11:03:09 +0000 (12:03 +0100)]
[SONAR-18502] move validation of drop index param

This is done to allow to run query based on an actual index name than may not be valid instead of expected one.
Refactor drop index structure to make it simpler and safer.

(cherry picked from commit 5173552f87f2179d9eff40db65ae4d6af3f99442)

19 months agoSONAR-18472 Resolve telemetry performance issue
Alain Kermis [Fri, 17 Feb 2023 10:44:37 +0000 (11:44 +0100)]
SONAR-18472 Resolve telemetry performance issue

Co-authored-by: Jacek Poreda <jacek.poreda@sonarsource.com>
(cherry picked from commit a20f2bce3cc9111152aa810030253db6acbd4af8)

19 months agoBUILD-2482 setup gitlab on runtime
Julien Carsique [Wed, 1 Feb 2023 14:52:22 +0000 (15:52 +0100)]
BUILD-2482 setup gitlab on runtime

19 months agoBUILD-2486 Use quay.io/keycloak/keycloak:17.0.1 Docker image
David Rautureau [Wed, 1 Feb 2023 13:00:27 +0000 (14:00 +0100)]
BUILD-2486 Use quay.io/keycloak/keycloak:17.0.1 Docker image

19 months agoBUILD-2459 Migrate CirrusCI to AWS
David Rautureau [Fri, 30 Sep 2022 12:54:39 +0000 (14:54 +0200)]
BUILD-2459 Migrate CirrusCI to AWS

cherry-pick 3a47a5db94c (BUILD-2275)

use eks_container instead of gke_container
use ec2_instance instead of gce_instance
tune containers
move GitLab build to re-ci-images

19 months agoSONAR-18386 Add ANALYZE to test to avoid timeout on purge audit
Léo Geoffroy [Mon, 13 Feb 2023 16:42:48 +0000 (17:42 +0100)]
SONAR-18386 Add ANALYZE to test to avoid timeout on purge audit

20 months ago[NO JIRA] Prepare next release cycle
Alain Kermis [Fri, 3 Feb 2023 14:45:56 +0000 (15:45 +0100)]
[NO JIRA] Prepare next release cycle

20 months ago[NO-JIRA] Better discrimate Gitlab task names
Philippe Perrin [Tue, 7 Feb 2023 09:12:45 +0000 (10:12 +0100)]
[NO-JIRA] Better discrimate Gitlab task names

20 months agoSONAR-17815 Small text changes 9.9.0.65466
Wouter Admiraal [Fri, 3 Feb 2023 09:09:42 +0000 (10:09 +0100)]
SONAR-17815 Small text changes

20 months agoSONAR-17815 implement updated logic for CaYC quality gates
Matteo Mara [Fri, 27 Jan 2023 15:16:07 +0000 (16:16 +0100)]
SONAR-17815 implement updated logic for CaYC quality gates

20 months ago[NO JIRA] Allow 9.9 nightly builds to run the full QA
Matteo Mara [Thu, 2 Feb 2023 08:56:54 +0000 (09:56 +0100)]
[NO JIRA] Allow 9.9 nightly builds to run the full QA

20 months agoSONAR-18275 Fix App stats present in projects-general-stats telemetry payload
Antoine Vinot [Mon, 30 Jan 2023 11:33:54 +0000 (12:33 +0100)]
SONAR-18275 Fix App stats present in projects-general-stats telemetry payload

20 months agoSONAR-18219 Change type of telemetry data
Antoine Vinot [Fri, 27 Jan 2023 09:55:06 +0000 (10:55 +0100)]
SONAR-18219 Change type of telemetry data

20 months agoSONAR-18219 Add telemetry fields for CaYC
Alain Kermis [Wed, 25 Jan 2023 14:20:50 +0000 (15:20 +0100)]
SONAR-18219 Add telemetry fields for CaYC

20 months agoSONAR-17815 Updating links for learn more CAYC and translation changes
Revanshu Paliwal [Tue, 24 Jan 2023 14:45:25 +0000 (15:45 +0100)]
SONAR-17815 Updating links for learn more CAYC and translation changes

20 months agoSONAR-18147 Fix infinite loading in ListFooter
stanislavh [Tue, 17 Jan 2023 10:23:05 +0000 (11:23 +0100)]
SONAR-18147 Fix infinite loading in ListFooter

20 months agoSONAR-18216 Improve SonarText analysis
Jacek Poreda [Tue, 17 Jan 2023 09:27:14 +0000 (10:27 +0100)]
SONAR-18216 Improve SonarText analysis

20 months agoSONAR-18151 [1099147] Incorrect semantic markup
guillaume-peoch-sonarsource [Mon, 16 Jan 2023 11:20:18 +0000 (12:20 +0100)]
SONAR-18151 [1099147] Incorrect semantic markup

20 months agoSONAR-18150 Reading order of static content changes meaning
Mathieu Suen [Mon, 16 Jan 2023 13:01:17 +0000 (14:01 +0100)]
SONAR-18150 Reading order of static content changes meaning

20 months agoSONAR-17732 Remove all usage of redirect.sonarsource.com
Wouter Admiraal [Fri, 13 Jan 2023 15:44:23 +0000 (16:44 +0100)]
SONAR-17732 Remove all usage of redirect.sonarsource.com

20 months agoSONAR-17815 CAYC Wording changes for QG page
Revanshu Paliwal [Mon, 16 Jan 2023 14:08:20 +0000 (15:08 +0100)]
SONAR-17815 CAYC Wording changes for QG page

20 months agoSONAR-18212 Improve SonarText analysis
Jacek Poreda [Mon, 16 Jan 2023 16:32:16 +0000 (17:32 +0100)]
SONAR-18212 Improve SonarText analysis

20 months ago[NO JIRA] Migrate enzyme to RTL for application console
Mathieu Suen [Wed, 11 Jan 2023 13:00:09 +0000 (14:00 +0100)]
[NO JIRA] Migrate enzyme to RTL for application console

20 months agoSONAR-17816 Better wording
Jeremy Davis [Mon, 16 Jan 2023 14:17:42 +0000 (15:17 +0100)]
SONAR-17816 Better wording

20 months agoSONAR-17845 [1096026, 1099611] Multiple links have the same programmatic link text...
Kevin Silva [Tue, 10 Jan 2023 13:41:42 +0000 (14:41 +0100)]
SONAR-17845 [10960261099611] Multiple links have the same programmatic link text but different destinations

20 months agoSONAR-18147 Status message not automatically announced
stanislavh [Mon, 16 Jan 2023 11:19:52 +0000 (12:19 +0100)]
SONAR-18147 Status message not automatically announced

20 months agoSONAR-18148 The decorative image is not hidden from screen readers
stanislavh [Mon, 16 Jan 2023 11:19:34 +0000 (12:19 +0100)]
SONAR-18148 The decorative image is not hidden from screen readers

20 months agoSONAR-18143 An icon lacks 3 to 1 contrast ratio
stanislavh [Fri, 13 Jan 2023 08:21:37 +0000 (09:21 +0100)]
SONAR-18143 An icon lacks 3 to 1 contrast ratio

20 months agoSONAR-18141 Status message is not automatically announced
stanislavh [Fri, 13 Jan 2023 08:20:49 +0000 (09:20 +0100)]
SONAR-18141 Status message is not automatically announced

20 months agoSONAR-18192 - Update size of user uuid column to 255 in audit table
Léo Geoffroy [Mon, 16 Jan 2023 15:23:42 +0000 (16:23 +0100)]
SONAR-18192 - Update size of user uuid column to 255 in audit table

20 months agoSONAR-18168 Improve Python and Java DBD analysis: better cache management on PR analysis
Jacek Poreda [Mon, 16 Jan 2023 09:58:11 +0000 (10:58 +0100)]
SONAR-18168 Improve Python and Java DBD analysis: better cache management on PR analysis

20 months agoSONAR-18196 Improve PHP analysis: better cache management on PR analysis
Jacek Poreda [Mon, 16 Jan 2023 09:57:05 +0000 (10:57 +0100)]
SONAR-18196 Improve PHP analysis: better cache management on PR analysis

20 months agoSONAR-18199 Improve Security analysis: hardening
Jacek Poreda [Mon, 16 Jan 2023 09:56:01 +0000 (10:56 +0100)]
SONAR-18199 Improve Security analysis: hardening

20 months agoSONAR-18200 Improve JS analysis
Jacek Poreda [Mon, 16 Jan 2023 09:54:04 +0000 (10:54 +0100)]
SONAR-18200 Improve JS analysis

20 months agoSONAR-18201 Improve Python analysis: better cache management on PR analysis
Jacek Poreda [Mon, 16 Jan 2023 09:52:53 +0000 (10:52 +0100)]
SONAR-18201 Improve Python analysis: better cache management on PR analysis

20 months agoSONAR-18203 Improve XML analysis: hardening before LTS (memory leak and template...
Jacek Poreda [Mon, 16 Jan 2023 09:51:29 +0000 (10:51 +0100)]
SONAR-18203 Improve XML analysis: hardening before LTS (memory leak and template rule misconfiguration)

20 months agoSONAR-18204 Improve JaCoCo XML Importer: do not index files when there's no JaCoCo...
Jacek Poreda [Mon, 16 Jan 2023 09:50:24 +0000 (10:50 +0100)]
SONAR-18204 Improve JaCoCo XML Importer: do not index files when there's no JaCoCo reports

20 months agoSONAR-17801 C# - New .NET Hotfix, Incremental PR Analysis
Jacek [Fri, 13 Jan 2023 10:36:33 +0000 (11:36 +0100)]
SONAR-17801 C# - New .NET Hotfix, Incremental PR Analysis

20 months agoSONAR-17802 VB.NET - New .NET Hotfix, Incremental PR Analysis
Jacek [Fri, 13 Jan 2023 10:32:58 +0000 (11:32 +0100)]
SONAR-17802 VB.NET - New .NET Hotfix, Incremental PR Analysis

20 months agoSONAR-17808 Improve JaCoCo support: Coverage not imported for files with a package...
Jacek [Fri, 13 Jan 2023 10:28:39 +0000 (11:28 +0100)]
SONAR-17808 Improve JaCoCo support: Coverage not imported for files with a package that doesn't match directory structure

20 months agoSONAR-18173 Improve CFamily analysis: 13 new rules about C++20's std::format
Jacek [Fri, 13 Jan 2023 10:20:08 +0000 (11:20 +0100)]
SONAR-18173 Improve CFamily analysis: 13 new rules about C++20's std::format

20 months agoSONAR-18182 First support of Dockerfile analysis with 8 rules
Jacek [Fri, 13 Jan 2023 09:58:12 +0000 (10:58 +0100)]
SONAR-18182 First support of Dockerfile analysis with 8 rules

20 months agoSONAR-18189 Improve PHP analysis: incremental PR analysis consumes less memory
Jacek [Fri, 13 Jan 2023 09:33:44 +0000 (10:33 +0100)]
SONAR-18189 Improve PHP analysis: incremental PR analysis consumes less memory

20 months agoSONAR-18190 Improve Java analysis: hardening, fix many FPs
Jacek [Fri, 13 Jan 2023 09:32:18 +0000 (10:32 +0100)]
SONAR-18190 Improve Java analysis: hardening, fix many FPs

20 months agoSONAR-18205 Make web service 'analysis_cache/get' public
Duarte Meneses [Mon, 16 Jan 2023 10:11:13 +0000 (11:11 +0100)]
SONAR-18205 Make web service 'analysis_cache/get' public

20 months agoSONAR-18198 Removing nested interactive Clean as You Code element in Quality Gate...
Revanshu Paliwal [Fri, 13 Jan 2023 15:18:46 +0000 (16:18 +0100)]
SONAR-18198 Removing nested interactive Clean as You Code element in Quality Gate page menu

20 months agoSONAR-18155 Fix homepage logo alt text
Wouter Admiraal [Fri, 13 Jan 2023 16:29:12 +0000 (17:29 +0100)]
SONAR-18155 Fix homepage logo alt text

20 months agoSONAR-17845 [1099604] Replace <footer> with <div> to fix a11y issue
Ambroise [Fri, 13 Jan 2023 10:22:13 +0000 (11:22 +0100)]
SONAR-17845 [1099604] Replace <footer> with <div> to fix a11y issue

20 months agoSONAR-17845 [1109939] Programmatic label does not convey purpose of control
Kevin Silva [Thu, 12 Jan 2023 10:45:25 +0000 (11:45 +0100)]
SONAR-17845 [1109939] Programmatic label does not convey purpose of control

21 months agoSONAR-12243 Do not require 'commit statuses' GitHub App permission 3317/head
Aurelien Poscia [Thu, 12 Jan 2023 09:45:29 +0000 (10:45 +0100)]
SONAR-12243 Do not require 'commit statuses' GitHub App permission

21 months ago[NO JIRA] Remove second devops instance warning
guillaume-peoch-sonarsource [Thu, 12 Jan 2023 16:09:24 +0000 (17:09 +0100)]
[NO JIRA] Remove second devops instance warning

21 months agoSONAR-13109 Users should understand why they're asked for their personal access token
guillaume-peoch-sonarsource [Tue, 10 Jan 2023 16:52:05 +0000 (17:52 +0100)]
SONAR-13109 Users should understand why they're asked for their personal access token

21 months agoSONAR-18145 Visual heading text is not marked up as heading
stanislavh [Thu, 12 Jan 2023 12:29:38 +0000 (13:29 +0100)]
SONAR-18145 Visual heading text is not marked up as heading

21 months agoSONAR-18133 Header elements must have sufficient color contrast
stanislavh [Thu, 12 Jan 2023 10:58:05 +0000 (11:58 +0100)]
SONAR-18133 Header elements must have sufficient color contrast

21 months agoSONAR-18132 SONAR-18135 SONAR-18136 SONAR-18137 SONAR-18138 SONAR-18139 SONAR-18140...
stanislavh [Thu, 12 Jan 2023 10:57:42 +0000 (11:57 +0100)]
SONAR-18132 SONAR-18135 SONAR-18136 SONAR-18137 SONAR-18138 SONAR-18139 SONAR-18140 Visual list is not marked up as list

21 months agoSONAR-18195 Missing SCM data might cause a NPE in the Compute Engine
Duarte Meneses [Fri, 13 Jan 2023 08:25:34 +0000 (09:25 +0100)]
SONAR-18195 Missing SCM data might cause a NPE in the Compute Engine

21 months agoSONAR-18175 Fix compatibility issue with older browsers
Wouter Admiraal [Fri, 13 Jan 2023 11:03:55 +0000 (12:03 +0100)]
SONAR-18175 Fix compatibility issue with older browsers

21 months agoSONAR-18188 Share CAYC quality gate info via telemetry
Alain Kermis [Thu, 12 Jan 2023 13:19:38 +0000 (14:19 +0100)]
SONAR-18188 Share CAYC quality gate info via telemetry

21 months agoSONAR-17845 [1095656] Fix list status not being automatically announced
Ambroise [Thu, 12 Jan 2023 15:33:41 +0000 (16:33 +0100)]
SONAR-17845 [1095656] Fix list status not being automatically announced

21 months agoSONAR-17845 [1099483] Elements must have sufficient color contrast
Kevin Silva [Tue, 10 Jan 2023 16:28:01 +0000 (17:28 +0100)]
SONAR-17845 [1099483] Elements must have sufficient color contrast

21 months ago[NO-JIRA] explicitly declare toList collector mutable or not
Zipeng WU [Thu, 12 Jan 2023 14:07:29 +0000 (15:07 +0100)]
[NO-JIRA] explicitly declare toList collector mutable or not

21 months agoSONAR-15820 Can't create new user on Firefox (#7377)
David Cho-Lerat [Fri, 13 Jan 2023 08:30:38 +0000 (09:30 +0100)]
SONAR-15820 Can't create new user on Firefox (#7377)

21 months agoSONAR-17816 Improve QG display for Apps
Jeremy Davis [Thu, 12 Jan 2023 10:42:43 +0000 (11:42 +0100)]
SONAR-17816 Improve QG display for Apps

21 months agoSONAR-17815 New UI changes for CAYC quality gates
Revanshu Paliwal [Wed, 11 Jan 2023 13:02:45 +0000 (14:02 +0100)]
SONAR-17815 New UI changes for CAYC quality gates

21 months agoSONAR-17176 Change folder for saving score matrix to fix security hotspot
Léo Geoffroy [Thu, 12 Jan 2023 15:50:19 +0000 (16:50 +0100)]
SONAR-17176 Change folder for saving score matrix to fix security hotspot

21 months agoSONAR-18191 replace security principles with Clean Code principles
Pierre [Wed, 11 Jan 2023 15:53:43 +0000 (16:53 +0100)]
SONAR-18191 replace security principles with Clean Code principles

21 months agoSONAR-18174 Analyzer cache should be kept in the file system to decrease memory use
Duarte Meneses [Fri, 6 Jan 2023 23:42:28 +0000 (17:42 -0600)]
SONAR-18174 Analyzer cache should be kept in the file system to decrease memory use

21 months agoSONAR-18179 Deletion of selected branch break header
stanislavh [Wed, 11 Jan 2023 16:28:40 +0000 (17:28 +0100)]
SONAR-18179 Deletion of selected branch break header

21 months ago[NO-JIRA] Remove reported generic code smell
Matteo Mara [Thu, 12 Jan 2023 12:54:48 +0000 (13:54 +0100)]
[NO-JIRA] Remove reported generic code smell

21 months agoSONAR-17816 Warn user about non-cayc-compliant QG on the project overview
Jeremy Davis [Tue, 10 Jan 2023 13:35:17 +0000 (14:35 +0100)]
SONAR-17816 Warn user about non-cayc-compliant QG on the project overview

21 months ago[NO JIRA] Fix quality issues related to assertions
Duarte Meneses [Thu, 12 Jan 2023 08:35:20 +0000 (09:35 +0100)]
[NO JIRA] Fix quality issues related to assertions

21 months agoSONAR-17739 Fix adhoc rule name not showing correctly in issue search
Léo Geoffroy [Thu, 12 Jan 2023 10:07:01 +0000 (11:07 +0100)]
SONAR-17739 Fix adhoc rule name not showing correctly in issue search

21 months agoSONAR-14901 Fix "ALM" term in product+doc
Duarte Meneses [Tue, 3 Jan 2023 21:56:14 +0000 (15:56 -0600)]
SONAR-14901 Fix "ALM" term in product+doc

21 months ago[NO-JIRA] Remove reported generic code smell
Matteo Mara [Wed, 11 Jan 2023 13:26:26 +0000 (14:26 +0100)]
[NO-JIRA] Remove reported generic code smell

21 months ago[NO-JIRA] Remove reported code smells about switch labels
Matteo Mara [Wed, 11 Jan 2023 10:41:25 +0000 (11:41 +0100)]
[NO-JIRA] Remove reported code smells about switch labels

21 months ago[NO-JIRA] Remove reported code smells about unused imports
Matteo Mara [Wed, 11 Jan 2023 10:31:20 +0000 (11:31 +0100)]
[NO-JIRA] Remove reported code smells about unused imports

21 months ago[NO-JIRA] Use record for data classes
Zipeng WU [Tue, 10 Jan 2023 10:51:59 +0000 (11:51 +0100)]
[NO-JIRA] Use record for data classes

21 months ago[NO-JIRA] Drop unnecessary k8s Hazelcast plugin 3316/head
Jacek [Wed, 11 Jan 2023 09:41:48 +0000 (10:41 +0100)]
[NO-JIRA] Drop unnecessary k8s Hazelcast plugin

- included since Hazelcast 5.X, see https://github.com/hazelcast/hazelcast-kubernetes

21 months ago[NO-JIRA] Fix typing issue in extensions
Philippe Perrin [Mon, 2 Jan 2023 16:56:51 +0000 (17:56 +0100)]
[NO-JIRA] Fix typing issue in extensions

21 months agoSONAR-17779 Update branch when application settings change
Mathieu Suen [Wed, 4 Jan 2023 13:20:53 +0000 (14:20 +0100)]
SONAR-17779 Update branch when application settings change

21 months agoSONAR-18164 Deprecate language specific parameters
alain [Wed, 11 Jan 2023 14:29:35 +0000 (15:29 +0100)]
SONAR-18164 Deprecate language specific parameters

21 months agoSONAR-17844 Multi-file issues: fold the location list if there are more than 4 locati...
David Cho-Lerat [Wed, 11 Jan 2023 14:13:28 +0000 (15:13 +0100)]
SONAR-17844 Multi-file issues: fold the location list if there are more than 4 locations to display (#7323)

21 months agoSONAR-17834 Reactivate GitHub Integration Tests
Antoine Vinot [Thu, 5 Jan 2023 15:37:28 +0000 (16:37 +0100)]
SONAR-17834 Reactivate GitHub Integration Tests

21 months agoSONAR-17838 Portfolio creation: invalid characters in the key should prevent form...
David Cho-Lerat [Wed, 11 Jan 2023 12:51:36 +0000 (13:51 +0100)]
SONAR-17838 Portfolio creation: invalid characters in the key should prevent form submission (#7329)

21 months agoSONAR-17837 Move "Secrets" analysis configuration to the "Languages" setting tab
Philippe Perrin [Tue, 10 Jan 2023 08:13:46 +0000 (09:13 +0100)]
SONAR-17837 Move "Secrets" analysis configuration to the "Languages" setting tab

21 months agoSONAR-17836 Deactivate common rules for the "Secrets" language
Philippe Perrin [Tue, 10 Jan 2023 08:07:17 +0000 (09:07 +0100)]
SONAR-17836 Deactivate common rules for the "Secrets" language

21 months agoSONAR-18181 fix qrofile/profile typo
Pierre [Tue, 10 Jan 2023 15:43:23 +0000 (16:43 +0100)]
SONAR-18181 fix qrofile/profile typo

21 months agoSONAR-177790 - Update oracle image for ITs for express edition and 21C
Léo Geoffroy [Wed, 11 Jan 2023 08:40:55 +0000 (09:40 +0100)]
SONAR-177790 - Update oracle image for ITs for express edition and 21C

21 months agoNO-JIRA removing duplicated method
Lukasz Jarocki [Tue, 10 Jan 2023 15:00:58 +0000 (16:00 +0100)]
NO-JIRA removing duplicated method

21 months agoSONAR-14656 fixed unit tests not passing on Windows
Lukasz Jarocki [Tue, 10 Jan 2023 16:20:03 +0000 (17:20 +0100)]
SONAR-14656 fixed unit tests not passing on Windows

21 months ago[NO-JIRA] Remove reported code smells about usages of toList
Matteo Mara [Tue, 10 Jan 2023 14:16:50 +0000 (15:16 +0100)]
[NO-JIRA] Remove reported code smells about usages of toList

21 months ago[NO-JIRA] Remove reported code smells about usage of instanceof
Matteo Mara [Mon, 9 Jan 2023 09:21:46 +0000 (10:21 +0100)]
[NO-JIRA] Remove reported code smells about usage of instanceof