]> source.dussan.org Git - vaadin-framework.git/log
vaadin-framework.git
10 years agoTest for broken Webkit feature which causes extra scrollbars (#12736, #12727)
Artur Signell [Wed, 6 Nov 2013 15:17:42 +0000 (17:17 +0200)]
Test for broken Webkit feature which causes extra scrollbars (#12736, #12727)

This is the original cause for the Vaadin issues

Live test at http://artur.virtuallypreinstalled.com/webkit-scrollbars.html

Change-Id: Iaf9a46b635fabcb7cd795547c782c596aa57ce12

10 years agoCorrect assertion message which changed due to #12915
Artur Signell [Fri, 29 Nov 2013 14:53:05 +0000 (16:53 +0200)]
Correct assertion message which changed due to #12915

Converted to TB3 to allow running on only one browser

Change-Id: I8a0d20cfb5af798d8b89f3fca86ef7d9d7a37527

10 years agoFor @-directives, infer missing semicolon before closing brace (#12792)
joheriks [Wed, 27 Nov 2013 15:34:30 +0000 (17:34 +0200)]
For @-directives, infer missing semicolon before closing brace (#12792)

Parser now accepts the following (note missing semicolon after last
@extend-directive):

xyzzy {
  @extend foo ;
  @extend bar
}

As a consequence, moved 31 sasslang-cases from broken to fixed. Moved
two tests from fixed to broken (34, 95, previously passed accidentally)

Change-Id: I8968074abd79dec71be762ed926cc6f37fbcaa99

11 years agoMove a sass test that no longer fails.
Mika Murtojarvi [Wed, 27 Nov 2013 11:29:51 +0000 (13:29 +0200)]
Move a sass test that no longer fails.

Change-Id: Ic83330cbea688be1c30aa89cad9524016617be8d

11 years agoMove working sass tests from sasslangbroken to sasslang.
Mika Murtojarvi [Wed, 27 Nov 2013 07:26:07 +0000 (09:26 +0200)]
Move working sass tests from sasslangbroken to sasslang.

Change-Id: Ic503021884fd52b650f29df221cef3e69e8ef570

11 years agoCatch and log exceptions in session lifecycle listeners (#12915)
Henri Sara [Wed, 27 Nov 2013 13:30:36 +0000 (15:30 +0200)]
Catch and log exceptions in session lifecycle listeners (#12915)

Change-Id: Ie8638f010d74c569c5ff56e91c95e23a5cb92c9b

11 years agoMake test work reliably by activating @Push
Artur Signell [Wed, 13 Nov 2013 12:56:06 +0000 (14:56 +0200)]
Make test work reliably by activating @Push

Additional test now ensures that access() works both when called
before init() is done and after init() is done

Change-Id: Id56bd09f1aaa7a6a99eed8d097f12910cdc11596

11 years agoMixins now accept an empty argument list in parentheses
Mika Murtojarvi [Mon, 25 Nov 2013 14:31:55 +0000 (16:31 +0200)]
Mixins now accept an empty argument list in parentheses
(#12992).

Change-Id: If2484e2f289aa7039984df0d9a73ba595117462c

11 years agoNormalize line endings
Mika Murtojarvi [Tue, 26 Nov 2013 12:14:06 +0000 (14:14 +0200)]
Normalize line endings

Change-Id: I328a1d3505471c65681dccdaa1a342dbb9c9ab37

11 years agoFixed TabSheet tab keyboard focus issues (#12343)
Juho Nurminen [Thu, 31 Oct 2013 13:38:51 +0000 (15:38 +0200)]
Fixed TabSheet tab keyboard focus issues (#12343)

Change-Id: Ifacf4208e5124665115d13928463d87922282461

11 years agoCleaned up the implementation of VTabsheet.selectPreviousTab()
Juho Nurminen [Wed, 20 Nov 2013 15:08:16 +0000 (17:08 +0200)]
Cleaned up the implementation of VTabsheet.selectPreviousTab()

Change-Id: I8e7fef3005173d7647b4dfda31f60978cbf5972a

11 years agoFixed TabSheet keyboard navigation (#12971)
Juho Nurminen [Mon, 18 Nov 2013 16:11:40 +0000 (18:11 +0200)]
Fixed TabSheet keyboard navigation (#12971)

Change-Id: Ibb155946811eb43829c6c200fa83c5eaa1d7cdfa

11 years agoFix TB3 local testing and occasionally failing SliderDisableTest.
Teemu Suo-Anttila [Tue, 19 Nov 2013 13:06:16 +0000 (15:06 +0200)]
Fix TB3 local testing and occasionally failing SliderDisableTest.

Change-Id: I58e60e55838c3339c934cf975e5e148c8f09a78b

11 years agoOutput test results in XML reports instead of to standard output
Artur Signell [Mon, 4 Nov 2013 16:10:05 +0000 (18:10 +0200)]
Output test results in XML reports instead of to standard output

This is a workaround for a problem with the integrated TeamCity JUnit
listener which is not thread safe. Without this the test results are
completely mixed up in TeamCity. For more information, see
http://youtrack.jetbrains.com/issue/TW-33176.

All standard JUnit test reports is put in result/reports. For uitest
there are three report directories: result/reports-tb2,
result/reports-tb3 and result/reports-integration to be able to clean
the directories before running a given type of tests.

This change is based on the separate fixes by John.

Change-Id: I2f0dee416f6745544636f2f3dcea0d0832ff8076

11 years agoRevert "Fixed lost scrollLeft when row count changed in Table (#12652)."
Leif Åstrand [Fri, 15 Nov 2013 09:46:42 +0000 (09:46 +0000)]
Revert "Fixed lost scrollLeft when row count changed in Table (#12652)."

This reverts commit 533ddcda271b7226b38c035adf3073062c562653.

Seems like the caused regressions are far from trivial to resolve. A new approach might be needed to resolve this issue.

Change-Id: I88cf75608e8d47fffab5a366a8ad1b3b70c1c11f

11 years agoAllow using @RunLocally to run on a local Firefox/Chrome/Safari
Artur Signell [Thu, 14 Nov 2013 07:38:05 +0000 (09:38 +0200)]
Allow using @RunLocally to run on a local Firefox/Chrome/Safari

Change-Id: Ibb1dfd12dc48637d8179f80322b5203ea5562805

11 years agoUse localhost when running locally to avoid potential network issues
Artur Signell [Mon, 11 Nov 2013 18:41:09 +0000 (20:41 +0200)]
Use localhost when running locally to avoid potential network issues

Change-Id: Ie43604a2b41d2214d55d0976ba3c81ea361c8c56

11 years agoAdded extra asserts to make test more safer to blind refactorings
Matti Tahvonen [Thu, 14 Nov 2013 10:17:04 +0000 (12:17 +0200)]
Added extra asserts to make test more safer to blind refactorings

Change-Id: I5dd159640bdc4f188c291017032ca96ca8b85d11

11 years agoPrevents accidental selection of window caption or content. (#12726)
Felype Santiago Ferreira [Mon, 11 Nov 2013 13:19:48 +0000 (15:19 +0200)]
Prevents accidental selection of window caption or content. (#12726)

Change-Id: Ida479ef0c421cf67b2863cf78c76b495337f30cf

11 years agoAdded test case for #12726
Matti Tahvonen [Thu, 14 Nov 2013 09:41:40 +0000 (11:41 +0200)]
Added test case for #12726

Change-Id: I396bfa4f255d64dd1729afa1be6771ff35026ad9

11 years agoEnsure alternate text is still visible (#11780)
Artur Signell [Wed, 13 Nov 2013 12:26:50 +0000 (14:26 +0200)]
Ensure alternate text is still visible (#11780)

Change-Id: Icfa54ec612153c3a92f83d7cb083685f7e77d295

11 years agoWorkaround for missing value change event in chrome (#10109)
Matti Tahvonen [Tue, 12 Nov 2013 15:12:30 +0000 (17:12 +0200)]
Workaround for missing value change event in chrome (#10109)

Change-Id: I019527041539fcd0083261b693767144492e626a

11 years agoDo not generate ParseException as it has been customized (#12937)
Artur Signell [Tue, 12 Nov 2013 09:08:07 +0000 (11:08 +0200)]
Do not generate ParseException as it has been customized (#12937)

Reverted ParseException to the previous version

Change-Id: Ic89eb4b65d1a78f40c4cb94e9b2a13a3250c1924

11 years agoRegenerated parser files (#12937)
Artur Signell [Mon, 11 Nov 2013 15:24:27 +0000 (17:24 +0200)]
Regenerated parser files (#12937)

Change-Id: I03e5f818c932d43be178008a4e857676bfed8f87

11 years agoEnsure generated parser is re-generated during build (#12937)
Artur Signell [Mon, 11 Nov 2013 14:11:50 +0000 (16:11 +0200)]
Ensure generated parser is re-generated during build (#12937)

Ultimately we should remove Parser.java and other generated files from
the project but this still needs tweaking ide.xml somehow so the parser
is built.

Change-Id: Iac491c6a50c87e1e8e0bb2f612e82186319a6de3

11 years agoUse correct type for UIDL value to avoid development mode problems (#12545)
Artur Signell [Mon, 11 Nov 2013 14:41:16 +0000 (16:41 +0200)]
Use correct type for UIDL value to avoid development mode problems (#12545)

Change-Id: Ib183e352fa64cb5c8f4d499ecb194768b18a16d6

11 years agoFixes double scrollbar issue in browserframes (#11780)
Thomas [Thu, 7 Nov 2013 11:03:52 +0000 (13:03 +0200)]
Fixes double scrollbar issue in browserframes (#11780)
Fixed by adding font-size 0 to the base theme.

Change-Id: I8d0224cb65f8ab36c50d2fd68157de4803c823e2

11 years agoRemove broken JSch check
Artur Signell [Mon, 11 Nov 2013 08:57:03 +0000 (10:57 +0200)]
Remove broken JSch check

The current check requires ANT_HOME/lib to contain jsch-0.1.48. There are
however other places, like .ant/lib where you can place the jar also.
Additionally the build agents in TeamCity seems to wipe ANT_HOME/lib
every now and then, which makes this a bad place to add extra jars.

Change-Id: I83b8e0612e72d422d4341fc68b1ab6a0c98848a5

11 years agoFixes NPE in TreeTable.setContainerDS(null) (#12928)
Thomas [Fri, 8 Nov 2013 11:59:28 +0000 (13:59 +0200)]
Fixes NPE in TreeTable.setContainerDS(null) (#12928)

Change-Id: I7f3148e51d216dfe20a11c8a5fd922f43cbc673b

11 years agoPrevent showing "Session Expired" notification if navigating away (#12298)
Johannes Dahlström [Thu, 7 Nov 2013 17:55:32 +0000 (19:55 +0200)]
Prevent showing "Session Expired" notification if navigating away (#12298)

Currently only works if navigation initiated via Page.open(url, "_self").
Page.setLocation should be changed in 7.2 to use "_self" as well (#12925)

Change-Id: I56ad66ffbbd1a83b64999307d23028cbd84bb508

11 years agoAdd a test for @mixin { @font-face {...} } (#11649)
joheriks [Fri, 8 Nov 2013 13:22:31 +0000 (15:22 +0200)]
Add a test for @mixin { @font-face {...} } (#11649)

Change-Id: I7d089ea14b169481f943a1f44058ad47f9b8179a

11 years agoFixes for sass compiler, handling mixins (#11288).
Mika Murtojarvi [Fri, 8 Nov 2013 09:23:35 +0000 (11:23 +0200)]
Fixes for sass compiler, handling mixins (#11288).

Keyframe selectors can now be comma-separated lists, interpolation
unquotes a quoted string and the parameters of an @include are no longer
lost.

Change-Id: I2622aca7471adc8004371affbb803d850e801307

11 years agoDo not apply fix on mobile devices or devices without scrollbars (#12736)
Artur Signell [Fri, 8 Nov 2013 09:26:08 +0000 (11:26 +0200)]
Do not apply fix on mobile devices or devices without scrollbars (#12736)

Change-Id: I38ef869d87418c18197a59a5ecd3fb7e12e1c02e

11 years agoMinimal fix for error handling with streaming (#12578)
Artur Signell [Thu, 7 Nov 2013 09:20:54 +0000 (11:20 +0200)]
Minimal fix for error handling with streaming (#12578)

There are still issues in PushHandler where the wrong resource is used but these should not be as critical. They will be fixed in #12920

Change-Id: Ife8d3694bdb6ee29c5b4adbd8988cc0346c4fe3f

11 years agoAdds JBoss EAP 6 server to integration test suit (#12908)
Thomas [Wed, 6 Nov 2013 11:34:18 +0000 (13:34 +0200)]
Adds JBoss EAP 6 server to integration test suit (#12908)

Change-Id: I2d31a0b446e40f0c221403dfb66a990e346e53c0

11 years agoFix scroll position handling in Window Webkit hack (#12736)
Artur Signell [Wed, 6 Nov 2013 13:11:34 +0000 (15:11 +0200)]
Fix scroll position handling in Window Webkit hack (#12736)

Change-Id: If4d17c34b2d20ad983f21b892d3ab4c68f511780

11 years agoRevert "Make Panel scroll the correct div (#12736)"
Artur Signell [Wed, 6 Nov 2013 13:26:42 +0000 (15:26 +0200)]
Revert "Make Panel scroll the correct div (#12736)"
Revert "Reverted change in how hack works (#12727, #12736)"
Revert "Fixes the handling of the scroll position of a Window (#12736)"
Revert "Recovering scroll position after regression problems. (#12727)"
Revert "Ticket #12727 - Panels get unnecessary scroll bars in WebKit when content is 100% wide."

This reverts commit 6a63d12afc5a4bf3971dd016f8e2761cd27bcc74.
This reverts commit c48c94dc23da22b6d885c69b0bc697257f9dbf11.
This reverts commit 017bd0684c7d6c8475c8b43514e6f3998095c8d6.
This reverts commit 51a46a038fe0353f4babfd8218153eb68e2602ca.
This reverts commit ab5b20cf502f99944c82f619ffef387f0525e8ba.

Test cases were left as-is as the issue (#12736) still needs a workaround

Change-Id: I0b6c2afb4a9be8629f2a8f880a8ae8d0a6d5088f

11 years agoFixed lost scrollLeft when row count changed in Table (#12652).
Tapio Aali [Tue, 5 Nov 2013 10:17:06 +0000 (12:17 +0200)]
Fixed lost scrollLeft when row count changed in Table (#12652).

Change-Id: I868f56c1e7003c6619859ba46619f4c53ef9744e

11 years agoForces redraw in IE 8 when table does post layout. (#12687)
Jarno Rantala [Mon, 4 Nov 2013 13:21:22 +0000 (15:21 +0200)]
Forces redraw in IE 8 when table does post layout. (#12687)

Without forcing the redraw, IE8 measures component sizes incorrectly in some cases.

Change-Id: I38e8a70e18753714b00f5ca4492749d6c84f10dc

11 years agoSend window position data back to server after drag (#12885)
Thomas [Tue, 5 Nov 2013 13:21:06 +0000 (15:21 +0200)]
Send window position data back to server after drag (#12885)

Change-Id: I9ca766b0e06390c7ab90f9cbd4996b83032789db

11 years agoImprove error message in createWidget() (#12901)
Leif Åstrand [Tue, 5 Nov 2013 13:41:45 +0000 (15:41 +0200)]
Improve error message in createWidget() (#12901)

Change-Id: If456a2be242754bcd1e0a8c5be00062a4355af35

11 years agoAllow @font-face and general @-directives inside @if-blocks (#11649)
joheriks [Mon, 28 Oct 2013 15:06:23 +0000 (17:06 +0200)]
Allow @font-face and general @-directives inside @if-blocks (#11649)

Change-Id: Ifa844e7bf8add886792b39c016cc2c9aa3d94b0c

11 years agoUpdated to Atmosphere 1.0.18.vaadin1 (#12891)
Artur Signell [Tue, 5 Nov 2013 06:36:37 +0000 (08:36 +0200)]
Updated to Atmosphere 1.0.18.vaadin1 (#12891)

Change-Id: I5387c9f5eca1eb7941fbd4565d4b6f3cb95a5a0f

11 years agoEnsure testing Jetty does not run out of heap space
Artur Signell [Mon, 4 Nov 2013 19:50:49 +0000 (21:50 +0200)]
Ensure testing Jetty does not run out of heap space

Change-Id: If4549c7bcb0a6518756aa42827340415c44a030c

11 years agoMake Panel scroll the correct div (#12736)
Artur Signell [Mon, 4 Nov 2013 18:23:27 +0000 (20:23 +0200)]
Make Panel scroll the correct div (#12736)

Redefined util method to take the scrollable instead of its parent to make
it useful also for cases where the first child is not scrollable

Change-Id: I301d260d26373b38fdee525f169347bb7b4c499e

11 years agoMake test more reliable by updating description which does not update the DOM
Artur Signell [Mon, 4 Nov 2013 20:24:49 +0000 (22:24 +0200)]
Make test more reliable by updating description which does not update the DOM

Many browsers (IE) choke quite easily when there is a 1MB string inside a div

Change-Id: Ied9b27c17c5374b7cac36820be9cbe38e84448ee

11 years agoFix NPE in fix (#12504)
Artur Signell [Mon, 4 Nov 2013 17:59:50 +0000 (19:59 +0200)]
Fix NPE in fix (#12504)

Change-Id: I65960bcfae850955ea40584445125c0affa26848

11 years agoRemove possibility to use static inner classes for tests
Artur Signell [Fri, 1 Nov 2013 10:58:33 +0000 (12:58 +0200)]
Remove possibility to use static inner classes for tests

Change-Id: I461568918bc09bd7a09abbf9c4a34f1a5f3b997f

11 years agoExtracted test to separate class
Artur Signell [Fri, 1 Nov 2013 10:54:05 +0000 (12:54 +0200)]
Extracted test to separate class

Change-Id: Ibfad0180e93e7f74b91427761b40c86938044c50

11 years agoFix NPE caused by setting ApplicationConnection too late (#12736)
Artur Signell [Mon, 4 Nov 2013 09:25:50 +0000 (11:25 +0200)]
Fix NPE caused by setting ApplicationConnection too late (#12736)

Change-Id: Ib5b3bc7123ffd2f212fb6e242ee07175ff743b0f

11 years agoReverted change in how hack works (#12727, #12736)
Artur Signell [Mon, 4 Nov 2013 09:26:54 +0000 (11:26 +0200)]
Reverted change in how hack works (#12727, #12736)

The fix for Window slightly altered how the hack was done, breaking #12736

Change-Id: I2d33b45421c40ce011d2e728a573f7572e326c47

11 years agofix regression related to #12504
Matti Tahvonen [Wed, 23 Oct 2013 14:28:55 +0000 (17:28 +0300)]
fix regression related to #12504

Cloning date instances passed from state to cal panel as they appear to be mutating

Change-Id: I3775b8445ddc0a779b894b4e044bde93f4c5936c

11 years agoMade test more stable and added Firefox reconnect test (#12492)
Artur Signell [Thu, 31 Oct 2013 19:35:25 +0000 (21:35 +0200)]
Made test more stable and added Firefox reconnect test (#12492)

Waits longer for push message as at least Firefox has some kind of built in back off for websocket reconnects

Change-Id: Iaab2e09e8364f0b6247b3b39c19be439a4995800

11 years agoPrepare for Safari 7 testing (#5288)
Artur Signell [Thu, 31 Oct 2013 17:27:40 +0000 (19:27 +0200)]
Prepare for Safari 7 testing (#5288)

Change-Id: I8868d9bd5e6dcc2b6ece404460700f00e6f2004e

11 years agoFix duplicate id issue in test and test more corner cases
Artur Signell [Thu, 31 Oct 2013 17:22:44 +0000 (19:22 +0200)]
Fix duplicate id issue in test and test more corner cases

Change-Id: I4bacfe7353968df7b0f1a8786ae4e488dffa3565

11 years agoUpdate to Atmosphere js 2.0.3.vaadin2 (#12868, #12852)
Artur Signell [Thu, 31 Oct 2013 17:34:00 +0000 (19:34 +0200)]
Update to Atmosphere js 2.0.3.vaadin2 (#12868, #12852)

Change-Id: I1a75b7dbc024e4222466d7cd0900660991a3c8f2

11 years agoNo longer require specifying Atmosphere js version in two places
Artur Signell [Thu, 31 Oct 2013 17:00:21 +0000 (19:00 +0200)]
No longer require specifying Atmosphere js version in two places

Change-Id: I84faea7fe0cd3447d7d66503e5231f26367dcd57

11 years agoForce connection to closed state on reconnect (#12853)
Artur Signell [Thu, 31 Oct 2013 16:42:22 +0000 (18:42 +0200)]
Force connection to closed state on reconnect (#12853)

IE10+ does not call onabort when the streaming connection is aborted.
As a result, onclose is never called and the client side does not
change the connection state away from "connected". This results in
user actions not being queued on the client side, instead the client
tries to send them immediately, leading to an eternal spinner.

If this can be fixed in Atmosphere somehow, it should. This is a
workaround until then.

Change-Id: Icd1a86ac9775d1a7d9c0bc1dee0fd399e2bf2266

11 years agoTests for validating reconnect works for streaming and websockets (#12868,#12853...
Artur Signell [Thu, 31 Oct 2013 10:39:12 +0000 (12:39 +0200)]
Tests for validating reconnect works for streaming and websockets (#12868,#12853,#12852)

Change-Id: I0e1e51291e9275a78737ad0e70e63b75ef993a63

11 years agoFix compilation error in test
Artur Signell [Thu, 31 Oct 2013 12:30:16 +0000 (14:30 +0200)]
Fix compilation error in test

Change-Id: I1ad693fdc55becd4b4e620b8549d824b4496b908

11 years agoConverted LayoutTesterApplication test to TB3
Artur Signell [Mon, 28 Oct 2013 14:55:45 +0000 (16:55 +0200)]
Converted LayoutTesterApplication test to TB3

Change-Id: I2cee37ae8297c74b4a37fc59e3cf835c9291ed43

11 years agoAdd StringToLongConverter for automatic handling of long values (#12225)
Artur Signell [Fri, 9 Aug 2013 17:35:54 +0000 (20:35 +0300)]
Add StringToLongConverter for automatic handling of long values (#12225)

Backported from master

Change-Id: Ibb91d28aab3731486c84d09547c7af641f39610a
Merge: no

11 years agoFixed Tab error tooltips (#12802)
Juho Nurminen [Wed, 30 Oct 2013 12:25:30 +0000 (14:25 +0200)]
Fixed Tab error tooltips (#12802)

Change-Id: I5ad33f38be5fac64805950d143ad2712e671ff83

11 years agoFixes the handling of the scroll position of a Window (#12736)
Mika Murtojarvi [Tue, 29 Oct 2013 13:22:45 +0000 (15:22 +0200)]
Fixes the handling of the scroll position of a Window (#12736)

After the first commit the same fix has been applied also for panels, in
addition to other suggested changes.

The scroll position of a Window is now memorized before applying
the fix for bug #11994. The position is restored after the fix.

Because the scrolling issue is known to appear also in other components,
the fix for the scrolling has been moved to the Util class.

Change-Id: I5251011b5bede77a7fb18972e1d90016c0eccc23

11 years agoAdded dummy checkstyle and test targets to liferay module
John Ahlroos [Mon, 28 Oct 2013 12:55:22 +0000 (14:55 +0200)]
Added dummy checkstyle and test targets to liferay module

The main build is currently assuming that every submodule has
a checkstyle and a test target. Added a dummy implementation for both of
them so the build passes.

Change-Id: Iea29b25840c26a4a384ba1ce8293d9ea6f37981e

11 years agoStop polling if Communication Error #12362
John Ahlroos [Mon, 28 Oct 2013 14:41:24 +0000 (16:41 +0200)]
Stop polling if Communication Error #12362

This change adds a new ApplicationStopped event which is triggered
whenever the ApplicationConnection marks the application as stopped.
This event is listened by the UIConnector and will terminate any polling
that might be currently done.

Change-Id: I5e698fba7a94f530f69a9f6f554eea896c370824

11 years agoRevert "Publish error artifacts immediatly in TeamCity"
Artur Signell [Wed, 30 Oct 2013 07:04:17 +0000 (07:04 +0000)]
Revert "Publish error artifacts immediatly in TeamCity"

This reverts commit 5fb1da2da04ccca2305af31a9105b848e42b1ed6.

Change-Id: I9d84b75e5e189378eacd2559bb42399b77957010

11 years agoRevert "Only print testbench failure TeamCity messages when running in TC"
Artur Signell [Wed, 30 Oct 2013 07:03:51 +0000 (07:03 +0000)]
Revert "Only print testbench failure TeamCity messages when running in TC"

This reverts commit d0e604f6b509767c46ffe0fd6765cf23535f593e.

Change-Id: I14509a9cb1365761d02a3a8a18d3febc4a7ba918

11 years agoEnsure error screenshots are named according to the browser and not reference
Artur Signell [Tue, 29 Oct 2013 12:18:24 +0000 (14:18 +0200)]
Ensure error screenshots are named according to the browser and not reference

Change-Id: I3fe0a3f5e2906bde79d6d9fc3e84dab8102ffd60

11 years agoParser stripped minus of negative numbers with unknown units (#12811)
joheriks [Mon, 28 Oct 2013 12:28:57 +0000 (14:28 +0200)]
Parser stripped minus of negative numbers with unknown units (#12811)

Change-Id: I8964b1732f867cb3c5aa5859d12e94a5978adece

11 years agoRemove out of order flush() (#12283)
Artur Signell [Fri, 18 Oct 2013 11:08:50 +0000 (14:08 +0300)]
Remove out of order flush() (#12283)

Writer.flush() is specified as:
"Flushes the stream. If the stream has saved any characters from the various
write() methods in a buffer, write them immediately to their intended
destination. Then, if that destination is another character or byte stream,
flush it. Thus one flush() invocation will flush all the buffers in a chain
of Writers and OutputStreams."

Change-Id: Iecafdbb13a7a26a48300d2967c25c705f5bf1e38

11 years agoFixes test issues preventing it from passing
Artur Signell [Tue, 22 Oct 2013 20:24:44 +0000 (23:24 +0300)]
Fixes test issues preventing it from passing

Ensure push is enabled correctly without a fallback and made test more stable

Change-Id: I6c653a96375e05c6ad18e1f5b697c6a584c6c53f

11 years agoConvert push test to TB3 so it has a chance to pass
Artur Signell [Tue, 22 Oct 2013 21:51:44 +0000 (00:51 +0300)]
Convert push test to TB3 so it has a chance to pass

Change-Id: I6381ea4bd61b3df19599f2f9d3a303a50c810460

11 years agoRecovering scroll position after regression problems. (#12727)
Felype Santiago Ferreira [Wed, 23 Oct 2013 08:23:02 +0000 (11:23 +0300)]
Recovering scroll position after regression problems. (#12727)

The fix for "Panels get unnecessary scroll bars in WebKit when content is 100% wide (#12727)" introduced side effects to #6731. This fix solves the problem.

Change-Id: I15ca926c0ee4cad49e9eea0c578c9cc73c850588

11 years agoRevert broken fix and test (#12446)
Johannes Dahlström [Mon, 21 Oct 2013 13:16:37 +0000 (16:16 +0300)]
Revert broken fix and test (#12446)

The timeoutInterval variable needs to be part of per-UI state for the
code to work correctly. Storing it in a servlet-global MetadataWriter
instance is both semantically wrong and a race condition.

Also, the test currently throws NPE if assertions are enabled.

This reverts commit f595d057951523baf35a797692376dfa5de0bc8d.

Change-Id: Ia6d1383b2c112b86ce60c75a3ebb9f10da545d4a

11 years agoFixed focus issue in TableMoveFocusWithSelectionTest (#12540)
John Ahlroos [Mon, 21 Oct 2013 13:12:09 +0000 (16:12 +0300)]
Fixed focus issue in TableMoveFocusWithSelectionTest (#12540)

Change-Id: I40dbc81b6aa4eaf0a235ae2cc7f04025011445c9

11 years agoTicket #12727 - Panels get unnecessary scroll bars in WebKit when content is 100...
Felype Santiago Ferreira [Fri, 18 Oct 2013 07:44:35 +0000 (10:44 +0300)]
Ticket #12727 - Panels get unnecessary scroll bars in WebKit when content is 100% wide.

Change-Id: Ia34e7c3ce755556460d237fb3489501274ced39f

11 years agoSass variables can now start with underscore (#12716)
joheriks [Thu, 17 Oct 2013 08:16:45 +0000 (11:16 +0300)]
Sass variables can now start with underscore (#12716)

Change-Id: I1c6cb12113f2462f96e8fcfc0749d3f62fd1998c

11 years agoAdded more exception handling to PushHandler (#12578, #11882)
Marc Englund [Wed, 9 Oct 2013 12:31:06 +0000 (15:31 +0300)]
Added more exception handling to PushHandler (#12578, #11882)

PushHandler now catches Exception and calls ErrorHandler more.

Change-Id: I7032c00f717b1dae34f4352abc035b1b398c7cfc

11 years agoFix serialization issue (#12703)
Artur Signell [Fri, 18 Oct 2013 10:00:31 +0000 (13:00 +0300)]
Fix serialization issue (#12703)

Change-Id: Ibdced8cdc3200ccfef2750e32fc8bf8dc544f1ae

11 years agoAdd more hax to make test work with new Atmosphere JS (#12241)
Artur Signell [Thu, 17 Oct 2013 12:46:40 +0000 (15:46 +0300)]
Add more hax to make test work with new Atmosphere JS (#12241)

Change-Id: Id75cabd402e243ed4bec7da61771554f2df4fbf6

11 years agoFixed javadoc
Artur Signell [Thu, 17 Oct 2013 08:25:50 +0000 (11:25 +0300)]
Fixed javadoc

Change-Id: I0c54a5d033d53efd2c82a1dc03f9b6fda423e8ce

11 years agoResolve concurrency issue in running TB3 tests
Artur Signell [Thu, 17 Oct 2013 12:21:09 +0000 (15:21 +0300)]
Resolve concurrency issue in running TB3 tests

Ensure nobody can update the static collections of browsers to run on
but that sub classes can restrict which browsers to run on using
super.getBrowersToTest().remove(something)

Change-Id: Iad520840801fbeb719bae51050714c0e47148804

11 years agoRemove unused test super class (#12786)
Artur Signell [Thu, 17 Oct 2013 08:19:06 +0000 (11:19 +0300)]
Remove unused test super class (#12786)

Change-Id: I7a56c9da10557485d5562eaf8d9197bfff4bc849

11 years agoFix compilation error
Artur Signell [Wed, 16 Oct 2013 14:02:42 +0000 (17:02 +0300)]
Fix compilation error

Change-Id: I0068b68ef29c2b3f669869cb4bf427567f71c8b2

11 years agoDisable automated testing on Opera until issues are resolved (#12487, #12367, #12800)
Artur Signell [Wed, 16 Oct 2013 13:33:54 +0000 (16:33 +0300)]
Disable automated testing on Opera until issues are resolved (#12487, #12367, #12800)

Change-Id: Id90abf6b2241aeb4f4e83551647169512a93401b

11 years agoReverted button click() logic check (#12743)
Artur Signell [Wed, 16 Oct 2013 12:31:15 +0000 (15:31 +0300)]
Reverted button click() logic check (#12743)

The isConnectorEnabled() method should only to be used to check if the
client side is allowed to interact with the button, not on the server side
(isConnectorEnabled() is false if the component is not attached to a UI)

Change-Id: I56cd93a1041432199337148f5c4a1449a825c5bc

11 years agoSkip compilation of TB2 tests if tests.tb2.skip is set
Artur Signell [Wed, 16 Oct 2013 11:48:57 +0000 (14:48 +0300)]
Skip compilation of TB2 tests if tests.tb2.skip is set

Change-Id: I647fb48059372b497c77580d252c9622d259d3eb

11 years agoTest for pushing large chunks of data (#12567)
Artur Signell [Fri, 13 Sep 2013 06:18:47 +0000 (09:18 +0300)]
Test for pushing large chunks of data (#12567)

Change-Id: I846b8417f69a0dca7cda2c3851148896d22cabcc

11 years agoDisable fallback in a way compatible with Atmosphere JS 2.0.3 (#12241)
Artur Signell [Wed, 16 Oct 2013 11:09:45 +0000 (14:09 +0300)]
Disable fallback in a way compatible with Atmosphere JS 2.0.3 (#12241)

Change-Id: I4023b50038288e39559cb8542ed59be807274d40

11 years agoHandle numbers in the same way if they do not have a unit (#12732)
Artur Signell [Tue, 15 Oct 2013 19:50:47 +0000 (22:50 +0300)]
Handle numbers in the same way if they do not have a unit (#12732)

Change-Id: Ic9dba337ffb209bf73ab427fa3a39e542e645c08

11 years agoAdd sub directory support to sass test scanner (#12790)
Artur Signell [Tue, 15 Oct 2013 18:49:25 +0000 (21:49 +0300)]
Add sub directory support to sass test scanner (#12790)

Exclude partial scss files (starting with _)
Add new lines to normalized css for easier comparison

Change-Id: I2bfb796b293cb0b578c3c5c56aacffe7c1514b02

11 years agoAdded liferay module for building liferay.zip #12748
John Ahlroos [Fri, 11 Oct 2013 12:41:49 +0000 (15:41 +0300)]
Added liferay module for building liferay.zip #12748

Change-Id: I16c7ba25387b3e1ad9a56e800c49755306b44890

11 years agoAllow running tests locally by overriding runLocally() (#12786)
Artur Signell [Mon, 14 Oct 2013 19:05:40 +0000 (22:05 +0300)]
Allow running tests locally by overriding runLocally() (#12786)

Uses Firefox either from path or from the location given using firefox.path in /work/run-eclipse-run-selected-test.properties

Change-Id: I29faa94cac4c978792a8fab9db338048553d166a

11 years agoCreated constants for tested browser versions (#12786)
Artur Signell [Tue, 15 Oct 2013 14:01:32 +0000 (17:01 +0300)]
Created constants for tested browser versions (#12786)

Change-Id: I8f349bb3c338bb7e9073944891436edac5ee1bb1

11 years agoValidate that the connector is enabled before triggering actions for it (#12743)
Artur Signell [Tue, 15 Oct 2013 06:33:43 +0000 (09:33 +0300)]
Validate that the connector is enabled before triggering actions for it (#12743)

Automated test enabled only for IE9-IE11 because of #12785

Change-Id: I265e5d1ead3fa56469861c5a98dcc9d0106d1051

11 years agoFixed swallower access. Now error handler logs exceptions. (#12703)
Felype Santiago Ferreira [Tue, 8 Oct 2013 13:04:32 +0000 (16:04 +0300)]
Fixed swallower access. Now error handler logs exceptions. (#12703)

Change-Id: If8fe00e10c7ec56cbd8753ff88d4816613a340f2

11 years agoAllow skipping TB2/TB3 tests using tests.tb2/tb3.skip
Artur Signell [Fri, 11 Oct 2013 17:31:48 +0000 (20:31 +0300)]
Allow skipping TB2/TB3 tests using tests.tb2/tb3.skip

Change-Id: If9f16657731fa5ea06e61bf9702abe385e4fc7a1

11 years agoDisable unit cache to avoid compilation issues when switching between branches
Artur Signell [Mon, 14 Oct 2013 18:57:08 +0000 (21:57 +0300)]
Disable unit cache to avoid compilation issues when switching between branches

Change-Id: Iac8a3cdc4b17c031108c08cf3e8cd8769bc14961

11 years agoUpdate to atmosphere javascript 2.0.3-vaadin1 (#12241, #12127)
Artur Signell [Fri, 11 Oct 2013 13:28:32 +0000 (16:28 +0300)]
Update to atmosphere javascript 2.0.3-vaadin1 (#12241, #12127)

Build vaadinPush.js from the released version instead of having a separate
javascript version in the project

Change-Id: I37aac284216c8ec6efd03c242e639e88854f11fd