]> source.dussan.org Git - redmine.git/log
redmine.git
5 years agocode cleanup: rubocop: fix Style/WhileUntilModifier in lib/redmine/unified_diff.rb
Toshi MARUYAMA [Sat, 19 Oct 2019 11:15:54 +0000 (11:15 +0000)]
code cleanup: rubocop: fix Style/WhileUntilModifier in lib/redmine/unified_diff.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18759 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/WhileUntilModifier in app/models/project.rb
Toshi MARUYAMA [Sat, 19 Oct 2019 11:15:43 +0000 (11:15 +0000)]
code cleanup: rubocop: fix Style/WhileUntilModifier in app/models/project.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18758 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agofix stderr_log_file and strip_credential of Redmine::Scm::Adapters::AbstractAdapter...
Toshi MARUYAMA [Sat, 19 Oct 2019 11:15:30 +0000 (11:15 +0000)]
fix stderr_log_file and strip_credential of Redmine::Scm::Adapters::AbstractAdapter are not private

git-svn-id: http://svn.redmine.org/redmine/trunk@18757 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoReturn to version page after the issue is created (#28138).
Jean-Philippe Lang [Sat, 19 Oct 2019 10:23:06 +0000 (10:23 +0000)]
Return to version page after the issue is created (#28138).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@18756 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoDisplay new issue link in version page (#28138).
Jean-Philippe Lang [Sat, 19 Oct 2019 10:22:16 +0000 (10:22 +0000)]
Display new issue link in version page (#28138).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@18755 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFixed that QueriesController can not handle subclass of IssueQuery (#25265).
Jean-Philippe Lang [Sat, 19 Oct 2019 10:13:12 +0000 (10:13 +0000)]
Fixed that QueriesController can not handle subclass of IssueQuery (#25265).

git-svn-id: http://svn.redmine.org/redmine/trunk@18754 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUpdates for 4.0.5 release.
Jean-Philippe Lang [Sat, 19 Oct 2019 09:29:07 +0000 (09:29 +0000)]
Updates for 4.0.5 release.

git-svn-id: http://svn.redmine.org/redmine/trunk@18749 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUpdate ruby-openid to 2.9.2 (#32294).
Jean-Philippe Lang [Sat, 19 Oct 2019 09:17:04 +0000 (09:17 +0000)]
Update ruby-openid to 2.9.2 (#32294).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18746 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFixed that total estimated time column is shown even when estimated time field is...
Jean-Philippe Lang [Sat, 19 Oct 2019 08:30:15 +0000 (08:30 +0000)]
Fixed that total estimated time column is shown even when estimated time field is deactivated (#31779).

Patch by Felix Schäfer and Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18743 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLines in lib/redmine/wiki_formatting/textile...
Toshi MARUYAMA [Sat, 19 Oct 2019 07:27:46 +0000 (07:27 +0000)]
code cleanup: rubocop: fix Layout/EmptyLines in lib/redmine/wiki_formatting/textile/redcloth3.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18742 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLines in test/unit/query_test.rb
Toshi MARUYAMA [Sat, 19 Oct 2019 07:27:35 +0000 (07:27 +0000)]
code cleanup: rubocop: fix Layout/EmptyLines in test/unit/query_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18741 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLines in test/functional/project_enumerations_...
Toshi MARUYAMA [Sat, 19 Oct 2019 07:27:23 +0000 (07:27 +0000)]
code cleanup: rubocop: fix Layout/EmptyLines in test/functional/project_enumerations_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18740 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLines in test/functional/activities_controller...
Toshi MARUYAMA [Sat, 19 Oct 2019 07:27:12 +0000 (07:27 +0000)]
code cleanup: rubocop: fix Layout/EmptyLines in test/functional/activities_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18739 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/WhileUntilModifier in lib/redmine/wiki_formatting...
Toshi MARUYAMA [Sat, 19 Oct 2019 07:26:59 +0000 (07:26 +0000)]
code cleanup: rubocop: fix Style/WhileUntilModifier in lib/redmine/wiki_formatting/textile/redcloth3.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18738 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/UnlessElse in lib/redmine/wiki_formatting/textile...
Toshi MARUYAMA [Sat, 19 Oct 2019 07:26:45 +0000 (07:26 +0000)]
code cleanup: rubocop: fix Style/UnlessElse in lib/redmine/wiki_formatting/textile/redcloth3.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18737 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLines in app/models/issue.rb
Toshi MARUYAMA [Sat, 19 Oct 2019 04:30:26 +0000 (04:30 +0000)]
code cleanup: rubocop: fix Layout/EmptyLines in app/models/issue.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18736 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLines in app/models/issue.rb
Toshi MARUYAMA [Sat, 19 Oct 2019 04:30:13 +0000 (04:30 +0000)]
code cleanup: rubocop: fix Layout/EmptyLines in app/models/issue.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18735 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/MultilineTernaryOperator in lib/redmine/utils.rb
Toshi MARUYAMA [Sat, 19 Oct 2019 04:30:01 +0000 (04:30 +0000)]
code cleanup: rubocop: fix Style/MultilineTernaryOperator in lib/redmine/utils.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18734 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/WhileUntilModifier in app/helpers/queries_helper.rb
Toshi MARUYAMA [Sat, 19 Oct 2019 04:29:47 +0000 (04:29 +0000)]
code cleanup: rubocop: fix Style/WhileUntilModifier in app/helpers/queries_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18733 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EndAlignment in lib/redmine/export/pdf/issues_pdf_h...
Toshi MARUYAMA [Thu, 17 Oct 2019 17:02:35 +0000 (17:02 +0000)]
code cleanup: rubocop: fix Layout/EndAlignment in lib/redmine/export/pdf/issues_pdf_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18732 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EndAlignment in app/helpers/versions_helper.rb
Toshi MARUYAMA [Thu, 17 Oct 2019 17:02:23 +0000 (17:02 +0000)]
code cleanup: rubocop: fix Layout/EndAlignment in app/helpers/versions_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18731 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EndAlignment in app/helpers/repositories_helper.rb
Toshi MARUYAMA [Thu, 17 Oct 2019 17:02:12 +0000 (17:02 +0000)]
code cleanup: rubocop: fix Layout/EndAlignment in app/helpers/repositories_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18730 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: add detected Layout/EndAlignment files to .rubocop_todo.yml
Toshi MARUYAMA [Thu, 17 Oct 2019 17:02:01 +0000 (17:02 +0000)]
rubocop: add detected Layout/EndAlignment files to .rubocop_todo.yml

git-svn-id: http://svn.redmine.org/redmine/trunk@18729 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/CaseIndentation in app/models/issue_query.rb
Toshi MARUYAMA [Thu, 17 Oct 2019 16:46:05 +0000 (16:46 +0000)]
code cleanup: rubocop: fix Layout/CaseIndentation in app/models/issue_query.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18728 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/CaseIndentation in lib/redmine/helpers/gantt.rb
Toshi MARUYAMA [Thu, 17 Oct 2019 16:45:54 +0000 (16:45 +0000)]
code cleanup: rubocop: fix Layout/CaseIndentation in lib/redmine/helpers/gantt.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18727 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/CaseIndentation in lib/redmine/menu_manager.rb
Toshi MARUYAMA [Thu, 17 Oct 2019 16:45:42 +0000 (16:45 +0000)]
code cleanup: rubocop: fix Layout/CaseIndentation in lib/redmine/menu_manager.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18726 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/SpaceBeforeSemicolon and Style/WhenThen in app...
Toshi MARUYAMA [Thu, 17 Oct 2019 16:40:54 +0000 (16:40 +0000)]
code cleanup: rubocop: fix Layout/SpaceBeforeSemicolon and Style/WhenThen in app/models/issue_query.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18725 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/WhenThen in app/models/role.rb
Toshi MARUYAMA [Thu, 17 Oct 2019 16:40:43 +0000 (16:40 +0000)]
code cleanup: rubocop: fix Style/WhenThen in app/models/role.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18724 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/CaseIndentation in lib/redmine/views/builders.rb
Toshi MARUYAMA [Thu, 17 Oct 2019 16:40:32 +0000 (16:40 +0000)]
code cleanup: rubocop: fix Layout/CaseIndentation in lib/redmine/views/builders.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18723 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/WhenThen in lib/redmine/views/builders.rb
Toshi MARUYAMA [Thu, 17 Oct 2019 16:40:20 +0000 (16:40 +0000)]
code cleanup: rubocop: fix Style/WhenThen in lib/redmine/views/builders.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18722 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode layout clean up lib/redmine/wiki_formatting/textile/redcloth3.rb
Toshi MARUYAMA [Thu, 17 Oct 2019 16:40:08 +0000 (16:40 +0000)]
code layout clean up lib/redmine/wiki_formatting/textile/redcloth3.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18721 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/CharacterLiteral and Style/ParenthesesAroundConditio...
Toshi MARUYAMA [Thu, 17 Oct 2019 16:39:55 +0000 (16:39 +0000)]
code cleanup: rubocop: fix Style/CharacterLiteral and Style/ParenthesesAroundCondition in lib/redmine/wiki_formatting/textile/redcloth3.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18720 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/CharacterLiteral and Style/ParenthesesAroundConditio...
Toshi MARUYAMA [Thu, 17 Oct 2019 16:39:43 +0000 (16:39 +0000)]
code cleanup: rubocop: fix Style/CharacterLiteral and Style/ParenthesesAroundCondition in lib/redmine/wiki_formatting.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18719 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode layout clean up app/controllers/issues_controller.rb
Toshi MARUYAMA [Thu, 17 Oct 2019 16:39:31 +0000 (16:39 +0000)]
code layout clean up app/controllers/issues_controller.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18718 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/WhileUntilModifier in lib/redmine/export/pdf/issues_...
Toshi MARUYAMA [Thu, 17 Oct 2019 16:15:09 +0000 (16:15 +0000)]
code cleanup: rubocop: fix Style/WhileUntilModifier in lib/redmine/export/pdf/issues_pdf_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18717 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/SpaceAroundBlockParameters in app/controllers/issue...
Toshi MARUYAMA [Thu, 17 Oct 2019 16:14:56 +0000 (16:14 +0000)]
code cleanup: rubocop: fix Layout/SpaceAroundBlockParameters in app/controllers/issues_controller.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18716 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/SpaceAroundBlockParameters in lib/redmine/plugin.rb
Toshi MARUYAMA [Thu, 17 Oct 2019 16:14:45 +0000 (16:14 +0000)]
code cleanup: rubocop: fix Layout/SpaceAroundBlockParameters in lib/redmine/plugin.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18715 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/CommentIndentation and Style/NestedTernaryOperator...
Toshi MARUYAMA [Thu, 17 Oct 2019 15:28:57 +0000 (15:28 +0000)]
code cleanup: rubocop: fix Layout/CommentIndentation and Style/NestedTernaryOperator in app/helpers/versions_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18714 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ElseAlignment in app/helpers/attachments_helper.rb
Toshi MARUYAMA [Thu, 17 Oct 2019 15:28:46 +0000 (15:28 +0000)]
code cleanup: rubocop: fix Layout/ElseAlignment in app/helpers/attachments_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18713 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ElseAlignment in app/helpers/queries_helper.rb
Toshi MARUYAMA [Thu, 17 Oct 2019 15:28:34 +0000 (15:28 +0000)]
code cleanup: rubocop: fix Layout/ElseAlignment in app/helpers/queries_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18712 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ElseAlignment in app/models/issue_query.rb
Toshi MARUYAMA [Thu, 17 Oct 2019 15:28:23 +0000 (15:28 +0000)]
code cleanup: rubocop: fix Layout/ElseAlignment in app/models/issue_query.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18711 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUpdate Rouge to 3.12.0 (#31556).
Go MAEDA [Thu, 17 Oct 2019 14:47:36 +0000 (14:47 +0000)]
Update Rouge to 3.12.0 (#31556).

git-svn-id: http://svn.redmine.org/redmine/trunk@18710 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFix typo in Russian translation for label_in_the_next_days (#32290).
Go MAEDA [Thu, 17 Oct 2019 14:04:42 +0000 (14:04 +0000)]
Fix typo in Russian translation for label_in_the_next_days (#32290).

Patch by Roman Yagodin.

git-svn-id: http://svn.redmine.org/redmine/trunk@18707 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/MultilineTernaryOperator in lib/redmine/wiki_formatt...
Toshi MARUYAMA [Thu, 17 Oct 2019 11:22:41 +0000 (11:22 +0000)]
code cleanup: rubocop: fix Style/MultilineTernaryOperator in lib/redmine/wiki_formatting.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18706 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ElseAlignment in lib/redmine/export/pdf/issues_pdf_...
Toshi MARUYAMA [Thu, 17 Oct 2019 11:22:30 +0000 (11:22 +0000)]
code cleanup: rubocop: fix Layout/ElseAlignment in lib/redmine/export/pdf/issues_pdf_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18705 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ElseAlignment in lib/redmine/i18n.rb
Toshi MARUYAMA [Thu, 17 Oct 2019 11:22:17 +0000 (11:22 +0000)]
code cleanup: rubocop: fix Layout/ElseAlignment in lib/redmine/i18n.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18704 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ElseAlignment in lib/redmine/plugin.rb
Toshi MARUYAMA [Thu, 17 Oct 2019 11:22:06 +0000 (11:22 +0000)]
code cleanup: rubocop: fix Layout/ElseAlignment in lib/redmine/plugin.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18703 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ElseAlignment in lib/redmine/wiki_formatting.rb
Toshi MARUYAMA [Thu, 17 Oct 2019 11:21:54 +0000 (11:21 +0000)]
code cleanup: rubocop: fix Layout/ElseAlignment in lib/redmine/wiki_formatting.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18702 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove test/unit/lib/redmine/wiki_formatting/textile_formatter_test.rb from...
Toshi MARUYAMA [Thu, 17 Oct 2019 04:15:58 +0000 (04:15 +0000)]
rubocop: remove test/unit/lib/redmine/wiki_formatting/textile_formatter_test.rb from Layout/EmptyLines fixed by previous revisions

git-svn-id: http://svn.redmine.org/redmine/trunk@18701 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove test/unit/lib/redmine/wiki_formatting/textile_formatter_test.rb from...
Toshi MARUYAMA [Thu, 17 Oct 2019 04:15:47 +0000 (04:15 +0000)]
rubocop: remove test/unit/lib/redmine/wiki_formatting/textile_formatter_test.rb from Layout/CommentIndentation and Layout/MultilineArrayBraceLayout fixed by previous revision

git-svn-id: http://svn.redmine.org/redmine/trunk@18700 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/CommentIndentation and Layout/MultilineArrayBraceLa...
Toshi MARUYAMA [Thu, 17 Oct 2019 04:15:37 +0000 (04:15 +0000)]
code cleanup: rubocop: fix Layout/CommentIndentation and Layout/MultilineArrayBraceLayout of STR_WITH_PRE in test/unit/lib/redmine/wiki_formatting/textile_formatter_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18699 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/CommentIndentation and Layout/MultilineArrayBraceLa...
Toshi MARUYAMA [Thu, 17 Oct 2019 04:15:26 +0000 (04:15 +0000)]
code cleanup: rubocop: fix Layout/CommentIndentation and Layout/MultilineArrayBraceLayout of STR_WITHOUT_PRE in test/unit/lib/redmine/wiki_formatting/textile_formatter_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18698 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agofix MailHandler#assign_string_attribute_with_limit is not private
Toshi MARUYAMA [Thu, 17 Oct 2019 04:15:16 +0000 (04:15 +0000)]
fix MailHandler#assign_string_attribute_with_limit is not private

git-svn-id: http://svn.redmine.org/redmine/trunk@18697 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLinesAroundMethodBody in lib/redmine/wiki_form...
Toshi MARUYAMA [Wed, 16 Oct 2019 14:36:55 +0000 (14:36 +0000)]
code cleanup: rubocop: fix Layout/EmptyLinesAroundMethodBody in lib/redmine/wiki_formatting/textile/redcloth3.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18696 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/AccessModifierIndentation and Layout/EmptyLinesArou...
Toshi MARUYAMA [Wed, 16 Oct 2019 14:36:43 +0000 (14:36 +0000)]
code cleanup: rubocop: fix Layout/AccessModifierIndentation and Layout/EmptyLinesAroundAccessModifier in app/models/tracker.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18695 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agofix Setting#find_or_default is not private
Toshi MARUYAMA [Wed, 16 Oct 2019 14:36:31 +0000 (14:36 +0000)]
fix Setting#find_or_default is not private

git-svn-id: http://svn.redmine.org/redmine/trunk@18694 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agofix Role#find_or_create_system_role is not private
Toshi MARUYAMA [Wed, 16 Oct 2019 14:36:20 +0000 (14:36 +0000)]
fix Role#find_or_create_system_role is not private

git-svn-id: http://svn.redmine.org/redmine/trunk@18693 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agofix AuthSourceLdap#get_attr is not private
Toshi MARUYAMA [Wed, 16 Oct 2019 14:36:10 +0000 (14:36 +0000)]
fix AuthSourceLdap#get_attr is not private

git-svn-id: http://svn.redmine.org/redmine/trunk@18692 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/LeadingCommentSpace in lib/diff.rb
Toshi MARUYAMA [Wed, 16 Oct 2019 13:00:52 +0000 (13:00 +0000)]
code cleanup: rubocop: fix Layout/LeadingCommentSpace in lib/diff.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18691 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/LeadingCommentSpace in lib/redmine/wiki_formatting...
Toshi MARUYAMA [Wed, 16 Oct 2019 13:00:41 +0000 (13:00 +0000)]
code cleanup: rubocop: fix Layout/LeadingCommentSpace in lib/redmine/wiki_formatting/textile/redcloth3.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18690 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: disable Style/TrailingCommaInArrayLiteral
Toshi MARUYAMA [Wed, 16 Oct 2019 13:00:29 +0000 (13:00 +0000)]
rubocop: disable Style/TrailingCommaInArrayLiteral

git-svn-id: http://svn.redmine.org/redmine/trunk@18689 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: add db/schema.rb to global exclude
Toshi MARUYAMA [Wed, 16 Oct 2019 13:00:18 +0000 (13:00 +0000)]
rubocop: add db/schema.rb to global exclude

git-svn-id: http://svn.redmine.org/redmine/trunk@18688 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: move Style/IdenticalConditionalBranches files from .rubocop_todo.yml to...
Toshi MARUYAMA [Tue, 15 Oct 2019 17:25:53 +0000 (17:25 +0000)]
rubocop: move Style/IdenticalConditionalBranches files from .rubocop_todo.yml to .rubocop.yml

git-svn-id: http://svn.redmine.org/redmine/trunk@18687 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/AccessModifierIndentation in lib/redmine/wiki_forma...
Toshi MARUYAMA [Tue, 15 Oct 2019 17:25:42 +0000 (17:25 +0000)]
code cleanup: rubocop: fix Layout/AccessModifierIndentation in lib/redmine/wiki_formatting/textile/formatter.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18686 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/AccessModifierIndentation and Layout/EmptyLinesArou...
Toshi MARUYAMA [Tue, 15 Oct 2019 17:25:31 +0000 (17:25 +0000)]
code cleanup: rubocop: fix Layout/AccessModifierIndentation and Layout/EmptyLinesAroundAccessModifier in lib/redmine/wiki_formatting/textile/redcloth3.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18685 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/SpaceInsideStringInterpolation in lib/redmine/wiki_...
Toshi MARUYAMA [Tue, 15 Oct 2019 17:25:19 +0000 (17:25 +0000)]
code cleanup: rubocop: fix Layout/SpaceInsideStringInterpolation in lib/redmine/wiki_formatting/textile/redcloth3.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18684 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/BlockAlignment in test/unit/lib/redmine/menu_manage...
Toshi MARUYAMA [Tue, 15 Oct 2019 12:11:00 +0000 (12:11 +0000)]
code cleanup: rubocop: fix Layout/BlockAlignment in test/unit/lib/redmine/menu_manager/menu_helper_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18683 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove lib/redmine/wiki_formatting/textile/redcloth3.rb from Layout/EmptyLin...
Toshi MARUYAMA [Tue, 15 Oct 2019 12:10:48 +0000 (12:10 +0000)]
rubocop: remove lib/redmine/wiki_formatting/textile/redcloth3.rb from Layout/EmptyLinesAroundArguments fixed by r18678

git-svn-id: http://svn.redmine.org/redmine/trunk@18682 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove lib/redmine/wiki_formatting/textile/redcloth3.rb from Style/OneLineCo...
Toshi MARUYAMA [Tue, 15 Oct 2019 12:10:37 +0000 (12:10 +0000)]
rubocop: remove lib/redmine/wiki_formatting/textile/redcloth3.rb from Style/OneLineConditional fixed by r18680

git-svn-id: http://svn.redmine.org/redmine/trunk@18681 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/IfWithSemicolon in lib/redmine/wiki_formatting/texti...
Toshi MARUYAMA [Tue, 15 Oct 2019 11:48:37 +0000 (11:48 +0000)]
code cleanup: rubocop: fix Style/IfWithSemicolon in lib/redmine/wiki_formatting/textile/redcloth3.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18680 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/IndentAssignment in lib/redmine/wiki_formatting...
Toshi MARUYAMA [Tue, 15 Oct 2019 11:48:25 +0000 (11:48 +0000)]
code cleanup: rubocop: fix Layout/IndentAssignment in lib/redmine/wiki_formatting/textile/redcloth3.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18679 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in lib/redmine/wiki_forma...
Toshi MARUYAMA [Tue, 15 Oct 2019 11:48:13 +0000 (11:48 +0000)]
code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in lib/redmine/wiki_formatting/textile/redcloth3.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18678 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/BlockAlignment in test/unit/lib/redmine/menu_manage...
Toshi MARUYAMA [Tue, 15 Oct 2019 05:07:51 +0000 (05:07 +0000)]
code cleanup: rubocop: fix Layout/BlockAlignment in test/unit/lib/redmine/menu_manager/mapper_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18677 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode layout clean up test/unit/project_test.rb
Toshi MARUYAMA [Tue, 15 Oct 2019 05:07:40 +0000 (05:07 +0000)]
code layout clean up test/unit/project_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18676 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in app/models/version.rb
Toshi MARUYAMA [Tue, 15 Oct 2019 05:07:29 +0000 (05:07 +0000)]
code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in app/models/version.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18675 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLineBetweenDefs and Layout/EmptyLines in app...
Toshi MARUYAMA [Tue, 15 Oct 2019 05:07:17 +0000 (05:07 +0000)]
code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs and Layout/EmptyLines in app/models/version.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18674 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in test/unit/mailer_test.rb
Toshi MARUYAMA [Tue, 15 Oct 2019 05:07:06 +0000 (05:07 +0000)]
code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in test/unit/mailer_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18673 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: use AllowAdjacentOneLineDefs of Layout/EmptyLineBetweenDefs
Toshi MARUYAMA [Mon, 14 Oct 2019 18:57:13 +0000 (18:57 +0000)]
rubocop: use AllowAdjacentOneLineDefs of Layout/EmptyLineBetweenDefs

git-svn-id: http://svn.redmine.org/redmine/trunk@18672 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove files from Layout/EmptyLines fixed by previous revisions
Toshi MARUYAMA [Mon, 14 Oct 2019 18:57:02 +0000 (18:57 +0000)]
rubocop: remove files from Layout/EmptyLines fixed by previous revisions

git-svn-id: http://svn.redmine.org/redmine/trunk@18671 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove app/helpers/application_helper.rb from Style/WhenThen fixed by r18664
Toshi MARUYAMA [Mon, 14 Oct 2019 18:56:51 +0000 (18:56 +0000)]
rubocop: remove app/helpers/application_helper.rb from Style/WhenThen fixed by r18664

git-svn-id: http://svn.redmine.org/redmine/trunk@18670 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ElseAlignment in app/models/issue_priority.rb
Toshi MARUYAMA [Mon, 14 Oct 2019 18:11:44 +0000 (18:11 +0000)]
code cleanup: rubocop: fix Layout/ElseAlignment in app/models/issue_priority.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18669 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ElseAlignment in app/models/issue_import.rb
Toshi MARUYAMA [Mon, 14 Oct 2019 18:11:33 +0000 (18:11 +0000)]
code cleanup: rubocop: fix Layout/ElseAlignment in app/models/issue_import.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18668 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode layout clean up ApplicationHelper#parse_wiki_links
Toshi MARUYAMA [Mon, 14 Oct 2019 18:11:21 +0000 (18:11 +0000)]
code layout clean up ApplicationHelper#parse_wiki_links

git-svn-id: http://svn.redmine.org/redmine/trunk@18667 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove app/helpers/application_helper.rb from Layout/ElseAlignment fixed...
Toshi MARUYAMA [Mon, 14 Oct 2019 17:48:02 +0000 (17:48 +0000)]
rubocop: remove app/helpers/application_helper.rb from Layout/ElseAlignment fixed by previous revisions

git-svn-id: http://svn.redmine.org/redmine/trunk@18666 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ElseAlignment in ApplicationHelper#parse_redmine_links
Toshi MARUYAMA [Mon, 14 Oct 2019 17:47:51 +0000 (17:47 +0000)]
code cleanup: rubocop: fix Layout/ElseAlignment in ApplicationHelper#parse_redmine_links

git-svn-id: http://svn.redmine.org/redmine/trunk@18665 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ElseAlignment in ApplicationHelper#parse_wiki_links
Toshi MARUYAMA [Mon, 14 Oct 2019 17:47:40 +0000 (17:47 +0000)]
code cleanup: rubocop: fix Layout/ElseAlignment in ApplicationHelper#parse_wiki_links

git-svn-id: http://svn.redmine.org/redmine/trunk@18664 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/CaseIndentation in app/helpers/versions_helper.rb
Toshi MARUYAMA [Mon, 14 Oct 2019 17:47:28 +0000 (17:47 +0000)]
code cleanup: rubocop: fix Layout/CaseIndentation in app/helpers/versions_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18663 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/CaseIndentation in test/test_helper.rb
Toshi MARUYAMA [Mon, 14 Oct 2019 17:47:17 +0000 (17:47 +0000)]
code cleanup: rubocop: fix Layout/CaseIndentation in test/test_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18662 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agouse full text in fill_in at Issue system "update issue with form update" test
Toshi MARUYAMA [Mon, 14 Oct 2019 17:47:05 +0000 (17:47 +0000)]
use full text in fill_in at Issue system "update issue with form update" test

git-svn-id: http://svn.redmine.org/redmine/trunk@18661 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in test/functional/users_contr...
Toshi MARUYAMA [Mon, 14 Oct 2019 14:52:23 +0000 (14:52 +0000)]
code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in test/functional/users_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18660 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in test/functional/settings_co...
Toshi MARUYAMA [Mon, 14 Oct 2019 14:52:11 +0000 (14:52 +0000)]
code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in test/functional/settings_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18659 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in test/functional/email_addre...
Toshi MARUYAMA [Mon, 14 Oct 2019 14:51:59 +0000 (14:51 +0000)]
code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in test/functional/email_addresses_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18658 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/SpaceAfterSemicolon in app/models/mail_handler.rb
Toshi MARUYAMA [Mon, 14 Oct 2019 14:51:48 +0000 (14:51 +0000)]
code cleanup: rubocop: fix Layout/SpaceAfterSemicolon in app/models/mail_handler.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18657 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoadd new "update issue status" test to Issue system test
Toshi MARUYAMA [Mon, 14 Oct 2019 14:51:35 +0000 (14:51 +0000)]
add new "update issue status" test to Issue system test

git-svn-id: http://svn.redmine.org/redmine/trunk@18656 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agouse "test do" syntax for Issue system test "update issue with form update"
Toshi MARUYAMA [Mon, 14 Oct 2019 14:51:25 +0000 (14:51 +0000)]
use "test do" syntax for Issue system test "update issue with form update"

git-svn-id: http://svn.redmine.org/redmine/trunk@18655 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/LeadingCommentSpace in test/unit/user_test.rb
Toshi MARUYAMA [Mon, 14 Oct 2019 11:14:24 +0000 (11:14 +0000)]
code cleanup: rubocop: fix Layout/LeadingCommentSpace in test/unit/user_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18654 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/LeadingCommentSpace in test/unit/query_test.rb
Toshi MARUYAMA [Mon, 14 Oct 2019 11:14:12 +0000 (11:14 +0000)]
code cleanup: rubocop: fix Layout/LeadingCommentSpace in test/unit/query_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18653 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/integration/api_t...
Toshi MARUYAMA [Mon, 14 Oct 2019 11:14:00 +0000 (11:14 +0000)]
code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/integration/api_test/my_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18652 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/integration/api_t...
Toshi MARUYAMA [Mon, 14 Oct 2019 11:13:49 +0000 (11:13 +0000)]
code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/integration/api_test/attachments_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18651 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/IndentHeredoc in test/integration/api_test/files_te...
Toshi MARUYAMA [Mon, 14 Oct 2019 11:13:38 +0000 (11:13 +0000)]
code cleanup: rubocop: fix Layout/IndentHeredoc in test/integration/api_test/files_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18650 e93f8b46-1217-0410-a6f0-8f06a7374b81