]> source.dussan.org Git - poi.git/log
poi.git
10 years agoWhen deleting a document in NPOIFS, free the underlying blocks
Nick Burch [Fri, 25 Apr 2014 22:00:30 +0000 (22:00 +0000)]
When deleting a document in NPOIFS, free the underlying blocks

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590160 13f79535-47bb-0310-9956-ffa450edef68

10 years agoMore progress with the write/read npoifs tests, but one bug still to go....
Nick Burch [Fri, 25 Apr 2014 21:23:10 +0000 (21:23 +0000)]
More progress with the write/read npoifs tests, but one bug still to go....

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590153 13f79535-47bb-0310-9956-ffa450edef68

10 years agoRefactor some of the NPOIFS write tests, and begin on the last missing write test
Nick Burch [Fri, 25 Apr 2014 21:11:26 +0000 (21:11 +0000)]
Refactor some of the NPOIFS write tests, and begin on the last missing write test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590149 13f79535-47bb-0310-9956-ffa450edef68

10 years agoAdd a getEntryNames() method to POIFS/NPOIFS directory entries, to make listing easier
Nick Burch [Fri, 25 Apr 2014 21:10:52 +0000 (21:10 +0000)]
Add a getEntryNames() method to POIFS/NPOIFS directory entries, to make listing easier

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590148 13f79535-47bb-0310-9956-ffa450edef68

10 years agoFinish off the next NPOIFS write text
Nick Burch [Fri, 25 Apr 2014 20:38:55 +0000 (20:38 +0000)]
Finish off the next NPOIFS write text

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590133 13f79535-47bb-0310-9956-ffa450edef68

10 years agoMore NPOIFS mini stream improvements, and more tests for it all
Nick Burch [Fri, 25 Apr 2014 18:39:31 +0000 (18:39 +0000)]
More NPOIFS mini stream improvements, and more tests for it all

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590098 13f79535-47bb-0310-9956-ffa450edef68

10 years agoCorrect mini stream initialisation, and enable more npoifs write tests
Nick Burch [Fri, 25 Apr 2014 18:14:28 +0000 (18:14 +0000)]
Correct mini stream initialisation, and enable more npoifs write tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590088 13f79535-47bb-0310-9956-ffa450edef68

10 years agoMore NPOIFS tests, and a partial mini-stream fix
Nick Burch [Fri, 25 Apr 2014 17:06:10 +0000 (17:06 +0000)]
More NPOIFS tests, and a partial mini-stream fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590083 13f79535-47bb-0310-9956-ffa450edef68

10 years agoMore npoifs write tests, some disabled as failing
Nick Burch [Fri, 25 Apr 2014 10:57:15 +0000 (10:57 +0000)]
More npoifs write tests, some disabled as failing

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589987 13f79535-47bb-0310-9956-ffa450edef68

10 years agoAdd common code for writing out and reading NPOIFS again, and add a disabled roundtri...
Nick Burch [Thu, 24 Apr 2014 22:22:06 +0000 (22:22 +0000)]
Add common code for writing out and reading NPOIFS again, and add a disabled roundtrip test (currently failing...)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589895 13f79535-47bb-0310-9956-ffa450edef68

10 years agoCorrect NPOIFS mini stream first write bug, and add more NPOIFS stream write tests
Nick Burch [Thu, 24 Apr 2014 21:08:34 +0000 (21:08 +0000)]
Correct NPOIFS mini stream first write bug, and add more NPOIFS stream write tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589881 13f79535-47bb-0310-9956-ffa450edef68

10 years agoAdd TODOs for the next set of NPOIFS write tests we need
Nick Burch [Thu, 24 Apr 2014 20:23:43 +0000 (20:23 +0000)]
Add TODOs for the next set of NPOIFS write tests we need

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589868 13f79535-47bb-0310-9956-ffa450edef68

10 years agoMore NPOIFS write testing, and fix a problem with writing xbat details out
Nick Burch [Thu, 24 Apr 2014 17:44:10 +0000 (17:44 +0000)]
More NPOIFS write testing, and fix a problem with writing xbat details out

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589806 13f79535-47bb-0310-9956-ffa450edef68

10 years agoUpdate a test to use the existing EntryUtils to copy with, rather than duplciating...
Nick Burch [Thu, 24 Apr 2014 17:32:47 +0000 (17:32 +0000)]
Update a test to use the existing EntryUtils to copy with, rather than duplciating the logic, and tweak naming/javadocs to clarify what the test does

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589802 13f79535-47bb-0310-9956-ffa450edef68

10 years agoMore unit tests for NPOIFS writing, and correct a bug in how bats get allocated in...
Nick Burch [Thu, 24 Apr 2014 17:25:10 +0000 (17:25 +0000)]
More unit tests for NPOIFS writing, and correct a bug in how bats get allocated in xbats. (Some issues still remain)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589800 13f79535-47bb-0310-9956-ffa450edef68

10 years agoMore int/long sizing fixes for >2gb NPOIFS files, see bug #56447
Nick Burch [Thu, 24 Apr 2014 16:15:21 +0000 (16:15 +0000)]
More int/long sizing fixes for >2gb NPOIFS files, see bug #56447

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589783 13f79535-47bb-0310-9956-ffa450edef68

10 years agoFix bug #56450 - Avoid a NPE if a comment has no associated NoteRecord (but we still...
Nick Burch [Thu, 24 Apr 2014 15:42:53 +0000 (15:42 +0000)]
Fix bug #56450 - Avoid a NPE if a comment has no associated NoteRecord (but we still don't know where it belongs)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589770 13f79535-47bb-0310-9956-ffa450edef68

10 years agoFix some Eclipse identified warnings
Nick Burch [Thu, 24 Apr 2014 15:07:20 +0000 (15:07 +0000)]
Fix some Eclipse identified warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589765 13f79535-47bb-0310-9956-ffa450edef68

10 years agoTwo more test files from Stefan Kopf for bug #56164, and unit tests which use them
Nick Burch [Thu, 24 Apr 2014 14:52:09 +0000 (14:52 +0000)]
Two more test files from Stefan Kopf for bug #56164, and unit tests which use them

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589759 13f79535-47bb-0310-9956-ffa450edef68

10 years agoCorrect an eclipse warning around close(), and a related bug that this identified
Nick Burch [Thu, 24 Apr 2014 14:50:52 +0000 (14:50 +0000)]
Correct an eclipse warning around close(), and a related bug that this identified

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589756 13f79535-47bb-0310-9956-ffa450edef68

10 years agoBug 56437 - [PATCH] Streaming write support in NPOIFS
Andreas Beeker [Mon, 21 Apr 2014 14:37:33 +0000 (14:37 +0000)]
Bug 56437 - [PATCH] Streaming write support in NPOIFS

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588887 13f79535-47bb-0310-9956-ffa450edef68

10 years agoSome encryption fixes:
Andreas Beeker [Mon, 21 Apr 2014 12:16:54 +0000 (12:16 +0000)]
Some encryption fixes:
- don't rely on SecretKey object having the right algorithm set
- leave encryption-description parsing of string/stream to xmlbeans and refactor it to one location
- use namespaces of schema instead of hard-coded strings
- use CryptoFunctions.getMessageDigest() instead of code duplication

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588874 13f79535-47bb-0310-9956-ffa450edef68

10 years agoTweak 'assertAlmostEquals' bast on Jenkins results
Nick Burch [Fri, 18 Apr 2014 23:44:08 +0000 (23:44 +0000)]
Tweak 'assertAlmostEquals' bast on Jenkins results

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588595 13f79535-47bb-0310-9956-ffa450edef68

10 years agoUnit test for column autosizing of % values
Nick Burch [Fri, 18 Apr 2014 20:46:57 +0000 (20:46 +0000)]
Unit test for column autosizing of % values

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588562 13f79535-47bb-0310-9956-ffa450edef68

10 years agoBug 56315: Make rounding in MathX.round() behave equal to Excel, adjust/enhance some...
Dominik Stadler [Fri, 18 Apr 2014 18:20:15 +0000 (18:20 +0000)]
Bug 56315: Make rounding in MathX.round() behave equal to Excel, adjust/enhance some more tests in MathX

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588538 13f79535-47bb-0310-9956-ffa450edef68

10 years agoTry to exclude some generated files from Sonar runs
Dominik Stadler [Fri, 18 Apr 2014 18:19:17 +0000 (18:19 +0000)]
Try to exclude some generated files from Sonar runs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588537 13f79535-47bb-0310-9956-ffa450edef68

10 years agoRather than having lots of classes all create their own XML DocumentBuilderFactory...
Nick Burch [Tue, 15 Apr 2014 21:59:52 +0000 (21:59 +0000)]
Rather than having lots of classes all create their own XML DocumentBuilderFactory instance, push that logic to a helper which sets all the right defaults

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1587739 13f79535-47bb-0310-9956-ffa450edef68

10 years agoMore stax jar removal for Java 6
Nick Burch [Tue, 15 Apr 2014 16:29:05 +0000 (16:29 +0000)]
More stax jar removal for Java 6

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1587631 13f79535-47bb-0310-9956-ffa450edef68

10 years agoNow that we require Java 1.6, we no longer need to include the STAX-API jar as JRE...
Nick Burch [Tue, 15 Apr 2014 15:19:30 +0000 (15:19 +0000)]
Now that we require Java 1.6, we no longer need to include the STAX-API jar as JRE 1.6 has it build in

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1587605 13f79535-47bb-0310-9956-ffa450edef68

10 years agoFix some Eclipse warnings
Dominik Stadler [Fri, 4 Apr 2014 07:26:53 +0000 (07:26 +0000)]
Fix some Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1584544 13f79535-47bb-0310-9956-ffa450edef68

10 years agoexclude new broken test-file for this test
Dominik Stadler [Fri, 4 Apr 2014 07:26:24 +0000 (07:26 +0000)]
exclude new broken test-file for this test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1584543 13f79535-47bb-0310-9956-ffa450edef68

10 years agoAdd another test file for bug #47251, from Joe Yuan, and a disabled test
Nick Burch [Tue, 1 Apr 2014 23:27:05 +0000 (23:27 +0000)]
Add another test file for bug #47251, from Joe Yuan, and a disabled test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583825 13f79535-47bb-0310-9956-ffa450edef68

10 years agoFix two javadoc warnings reported in Jenkins build and add some @Overrides
Dominik Stadler [Tue, 1 Apr 2014 10:40:13 +0000 (10:40 +0000)]
Fix two javadoc warnings reported in Jenkins build and add some @Overrides

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583598 13f79535-47bb-0310-9956-ffa450edef68

10 years agoUndo a toString() removal for a case where it is actually necessary.
Dominik Stadler [Tue, 1 Apr 2014 08:28:52 +0000 (08:28 +0000)]
Undo a toString() removal for a case where it is actually necessary.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583571 13f79535-47bb-0310-9956-ffa450edef68

10 years agoperformance issue: removed instantiation of new String object by copying an existing...
Cédric Walter [Mon, 31 Mar 2014 16:16:52 +0000 (16:16 +0000)]
performance issue: removed instantiation of new String object by copying an existing string.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583366 13f79535-47bb-0310-9956-ffa450edef68

10 years agoperformance issue: call toString() on a String object. This is entirely redundant.
Cédric Walter [Mon, 31 Mar 2014 16:01:39 +0000 (16:01 +0000)]
performance issue: call toString() on a String object. This is entirely redundant.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583358 13f79535-47bb-0310-9956-ffa450edef68

10 years agoperformance issue logging calls are expensive because of the objects created when...
Cédric Walter [Mon, 31 Mar 2014 15:54:52 +0000 (15:54 +0000)]
performance issue logging calls are expensive because of the objects created when assembling the log messages. Using the check() method of the logging sub-system can prevent object creation

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583357 13f79535-47bb-0310-9956-ffa450edef68

10 years agoPatch from bug #56328 from David North - the maximum row number in a formula depends...
Nick Burch [Fri, 28 Mar 2014 21:54:30 +0000 (21:54 +0000)]
Patch from bug #56328 from David North - the maximum row number in a formula depends on HSSF vs XSSF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1582892 13f79535-47bb-0310-9956-ffa450edef68

10 years agoUpdate Yegor's gpg key in the Keys file, with the latest version from the key servers...
Nick Burch [Wed, 26 Mar 2014 19:03:03 +0000 (19:03 +0000)]
Update Yegor's gpg key in the Keys file, with the latest version from the key servers (more signatures, correct expiry etc)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1582014 13f79535-47bb-0310-9956-ffa450edef68

10 years agoPatch for #55594 from Paul Vonnahme - Fix SXSSF encodings on EBC
Nick Burch [Sat, 22 Mar 2014 20:48:58 +0000 (20:48 +0000)]
Patch for #55594 from Paul Vonnahme - Fix SXSSF encodings on EBC
IDIC platforms, by setting the required encoding explicitly

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1580314 13f79535-47bb-0310-9956-ffa450edef68

10 years agoAvoid an IndexOutOfBoundsException if there are no property nodes when searching...
Nick Burch [Tue, 18 Mar 2014 14:40:27 +0000 (14:40 +0000)]
Avoid an IndexOutOfBoundsException if there are no property nodes when searching for the start index, return -1 instead

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1578929 13f79535-47bb-0310-9956-ffa450edef68

10 years agoSupport adding tabs to a XWPFRun, and add unit tests on toString() for addTab and...
Nick Burch [Tue, 18 Mar 2014 14:26:28 +0000 (14:26 +0000)]
Support adding tabs to a XWPFRun, and add unit tests on toString() for addTab and addCarriageReturn

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1578921 13f79535-47bb-0310-9956-ffa450edef68

10 years agoFix whitespace
Nick Burch [Tue, 18 Mar 2014 14:17:36 +0000 (14:17 +0000)]
Fix whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1578915 13f79535-47bb-0310-9956-ffa450edef68

10 years agoFix bug #56278 - Support loading .xlsx files with no Styles Table
Nick Burch [Mon, 17 Mar 2014 19:02:21 +0000 (19:02 +0000)]
Fix bug #56278 - Support loading .xlsx files with no Styles Table

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1578518 13f79535-47bb-0310-9956-ffa450edef68

10 years agoBug 56195: replace System.err with propert logging
Dominik Stadler [Sun, 16 Mar 2014 19:46:56 +0000 (19:46 +0000)]
Bug 56195: replace System.err with propert logging

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1578147 13f79535-47bb-0310-9956-ffa450edef68

10 years agoExclude some generated classes from coverage measurements, now instruction coverage...
Dominik Stadler [Sun, 16 Mar 2014 19:46:46 +0000 (19:46 +0000)]
Exclude some generated classes from coverage measurements, now instruction coverage is at around 72%, also update JaCoCo to latest version 0.6.5

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1578146 13f79535-47bb-0310-9956-ffa450edef68

10 years agoRemove two files added inadvertedely
Dominik Stadler [Sat, 15 Mar 2014 17:31:43 +0000 (17:31 +0000)]
Remove two files added inadvertedely

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577909 13f79535-47bb-0310-9956-ffa450edef68

10 years agoAdd missing test-file for bug 56169
Dominik Stadler [Sat, 15 Mar 2014 17:31:25 +0000 (17:31 +0000)]
Add missing test-file for bug 56169

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577908 13f79535-47bb-0310-9956-ffa450edef68

10 years agoBug 56169: Fix NPE during export to XML with xs:all
Dominik Stadler [Sat, 15 Mar 2014 17:29:17 +0000 (17:29 +0000)]
Bug 56169: Fix NPE during export to XML with xs:all

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577907 13f79535-47bb-0310-9956-ffa450edef68

10 years agoBug 56114: Add testcase to verify that the flag is correctly stored in the XLS
Dominik Stadler [Sat, 15 Mar 2014 17:00:22 +0000 (17:00 +0000)]
Bug 56114: Add testcase to verify that the flag is correctly stored in the XLS

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577901 13f79535-47bb-0310-9956-ffa450edef68

10 years agoWhen looking for text run related records after a TextHeaderAtom, provide a cleaner...
Nick Burch [Sat, 15 Mar 2014 08:16:43 +0000 (08:16 +0000)]
When looking for text run related records after a TextHeaderAtom, provide a cleaner way to skip ones we don't care about, and a cleaner way to find the StyleTextPropAtom. Should fix #56260

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577803 13f79535-47bb-0310-9956-ffa450edef68

10 years agoImplement MasterTextPropAtom, which provides the indents for a run of text, needed...
Nick Burch [Sat, 15 Mar 2014 08:14:36 +0000 (08:14 +0000)]
Implement MasterTextPropAtom, which provides the indents for a run of text, needed for #56260

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577802 13f79535-47bb-0310-9956-ffa450edef68

10 years ago#56260 Partial fix for a slide with a TextHeaderAtom but no other atoms related to...
Nick Burch [Fri, 14 Mar 2014 13:59:24 +0000 (13:59 +0000)]
#56260 Partial fix for a slide with a TextHeaderAtom but no other atoms related to it, which is followed by another TextHeaderAtom straight away

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577537 13f79535-47bb-0310-9956-ffa450edef68

10 years agoSample file for #56260, provided by Atlassian in CONF-18721
Nick Burch [Fri, 14 Mar 2014 13:59:08 +0000 (13:59 +0000)]
Sample file for #56260, provided by Atlassian in CONF-18721

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577536 13f79535-47bb-0310-9956-ffa450edef68

10 years agoBug 56075 - Add Change Tracking support to XWPF
Andreas Beeker [Thu, 13 Mar 2014 00:16:56 +0000 (00:16 +0000)]
Bug 56075 - Add Change Tracking support to XWPF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577010 13f79535-47bb-0310-9956-ffa450edef68

10 years agoTry one more way of excluding generated sources in the Maven pom.xml files for Sonar...
Dominik Stadler [Mon, 10 Mar 2014 19:35:25 +0000 (19:35 +0000)]
Try one more way of excluding generated sources in the Maven pom.xml files for Sonar analysis

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1576063 13f79535-47bb-0310-9956-ffa450edef68

10 years agoFix inconsistent whitespace, and add a close call in the main method to avoid a resou...
Nick Burch [Sun, 9 Mar 2014 09:53:25 +0000 (09:53 +0000)]
Fix inconsistent whitespace, and add a close call in the main method to avoid a resource-leak warning

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575684 13f79535-47bb-0310-9956-ffa450edef68

10 years agoPatch from Shaun Kalley from bug #56023 - On CellReference, implement hashCode, fix...
Nick Burch [Sun, 9 Mar 2014 09:49:06 +0000 (09:49 +0000)]
Patch from Shaun Kalley from bug #56023 - On CellReference, implement hashCode, fix the equals(Object) logic, and fix inconsistent whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575683 13f79535-47bb-0310-9956-ffa450edef68

10 years agoFix the inconsistent indents in the test file
Nick Burch [Sat, 8 Mar 2014 20:03:40 +0000 (20:03 +0000)]
Fix the inconsistent indents in the test file

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575600 13f79535-47bb-0310-9956-ffa450edef68

10 years agoAdd more unit tests for XWPF Headers and Footers
Nick Burch [Sat, 8 Mar 2014 20:01:38 +0000 (20:01 +0000)]
Add more unit tests for XWPF Headers and Footers

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575599 13f79535-47bb-0310-9956-ffa450edef68

10 years agoWhen adding a new XPWFRun to a paragraph, update both the Runs and IRuns lists with it
Nick Burch [Sat, 8 Mar 2014 19:52:09 +0000 (19:52 +0000)]
When adding a new XPWFRun to a paragraph, update both the Runs and IRuns lists with it

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575597 13f79535-47bb-0310-9956-ffa450edef68

10 years agoAdd some javadocs for the XWPF Header/Footer creation methods
Nick Burch [Sat, 8 Mar 2014 19:33:07 +0000 (19:33 +0000)]
Add some javadocs for the XWPF Header/Footer creation methods

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575594 13f79535-47bb-0310-9956-ffa450edef68

10 years agoAdjust for JDK 8 where an empty locale is added to the array returned by DateFormat...
Dominik Stadler [Sat, 8 Mar 2014 16:46:59 +0000 (16:46 +0000)]
Adjust for JDK 8 where an empty locale is added to the array returned by DateFormat.getAvailableLocales()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575563 13f79535-47bb-0310-9956-ffa450edef68

10 years agoFix Sonar issues about finalize() usage
Dominik Stadler [Sat, 8 Mar 2014 08:41:25 +0000 (08:41 +0000)]
Fix Sonar issues about finalize() usage

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575501 13f79535-47bb-0310-9956-ffa450edef68

10 years agoEnhance test to print out more information, it seems to fail on Apache Jenkins JDK8...
Dominik Stadler [Sat, 8 Mar 2014 08:41:08 +0000 (08:41 +0000)]
Enhance test to print out more information, it seems to fail on Apache Jenkins JDK8 build

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575500 13f79535-47bb-0310-9956-ffa450edef68

10 years agoAdjust TestExtractorFactory to provide more output to see why it fails on Maven build...
Dominik Stadler [Sat, 8 Mar 2014 08:22:03 +0000 (08:22 +0000)]
Adjust TestExtractorFactory to provide more output to see why it fails on Maven builds on nemo.sonarsource.org

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575497 13f79535-47bb-0310-9956-ffa450edef68

10 years agoAdded MD4-option and some cleanups
Andreas Beeker [Thu, 6 Mar 2014 00:53:09 +0000 (00:53 +0000)]
Added MD4-option and some cleanups

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1574732 13f79535-47bb-0310-9956-ffa450edef68

10 years agodisable font downloading, because of Jenkins connection (download) problems
Andreas Beeker [Tue, 4 Mar 2014 22:23:29 +0000 (22:23 +0000)]
disable font downloading, because of Jenkins connection (download) problems

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1574226 13f79535-47bb-0310-9956-ffa450edef68

10 years agoPOI is now on JDK 1.6, so remove 1.5 workaround
Nick Burch [Tue, 4 Mar 2014 11:57:44 +0000 (11:57 +0000)]
POI is now on JDK 1.6, so remove 1.5 workaround

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1574049 13f79535-47bb-0310-9956-ffa450edef68

10 years agoTry to set the Sonar-Exclusion property differently to see if that makes the exclusio...
Dominik Stadler [Mon, 3 Mar 2014 20:43:09 +0000 (20:43 +0000)]
Try to set the Sonar-Exclusion property differently to see if that makes the exclusions work

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1573741 13f79535-47bb-0310-9956-ffa450edef68

10 years agoSonar-pom: Add some metadata, try to add Sonar exclusions for generated sources
Dominik Stadler [Fri, 28 Feb 2014 16:10:22 +0000 (16:10 +0000)]
Sonar-pom: Add some metadata, try to add Sonar exclusions for generated sources

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1572979 13f79535-47bb-0310-9956-ffa450edef68

10 years agoTry to improve Maven files for Sonar: Copy in (test)sources instead of linking to...
Dominik Stadler [Thu, 27 Feb 2014 14:03:27 +0000 (14:03 +0000)]
Try to improve Maven files for Sonar: Copy in (test)sources instead of linking to sources outside the sonar-directory which confuses Sonar, remove source-dir setting for ooxml-schema and ooxml-schema-encryption as both have generate sources and not actual ones, scratchpad is not needed for ooxml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1572580 13f79535-47bb-0310-9956-ffa450edef68

10 years agoReport how long the CSV conversion took, helpful for a quick read performance test
Nick Burch [Thu, 27 Feb 2014 13:32:27 +0000 (13:32 +0000)]
Report how long the CSV conversion took, helpful for a quick read performance test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1572555 13f79535-47bb-0310-9956-ffa450edef68

10 years agoBug 56076 - Add document protection with password support to XWPF
Andreas Beeker [Fri, 21 Feb 2014 23:19:57 +0000 (23:19 +0000)]
Bug 56076 - Add document protection with password support to XWPF
Bug 56077 - Add password hash function to HWPF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1570750 13f79535-47bb-0310-9956-ffa450edef68

10 years agoZero length code page fix has been committed, so this file can once again be included...
Nick Burch [Thu, 20 Feb 2014 23:37:20 +0000 (23:37 +0000)]
Zero length code page fix has been committed, so this file can once again be included in the overall test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1570390 13f79535-47bb-0310-9956-ffa450edef68

10 years agoMore helpful visio v5 exception, see bug #56171
Nick Burch [Thu, 20 Feb 2014 23:20:19 +0000 (23:20 +0000)]
More helpful visio v5 exception, see bug #56171

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1570388 13f79535-47bb-0310-9956-ffa450edef68

10 years agoAnother content types test, for #55026
Nick Burch [Thu, 20 Feb 2014 00:06:34 +0000 (00:06 +0000)]
Another content types test, for #55026

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1570002 13f79535-47bb-0310-9956-ffa450edef68

10 years agoThe junit test failed with the original test-file (CDT_Data_Retention-PPT.ppt), so...
Andreas Beeker [Thu, 20 Feb 2014 00:03:42 +0000 (00:03 +0000)]
The junit test failed with the original test-file (CDT_Data_Retention-PPT.ppt), so another check was necessary

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569999 13f79535-47bb-0310-9956-ffa450edef68

10 years agoFix bug #56164 - Tidy up the OPC SAX setup code with a new common Helper
Nick Burch [Wed, 19 Feb 2014 23:54:46 +0000 (23:54 +0000)]
Fix bug #56164 - Tidy up the OPC SAX setup code with a new common Helper

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569991 13f79535-47bb-0310-9956-ffa450edef68

10 years agoBug 55732 - PPT can't open, fails with "Couldn't instantiate .... StyleTextProp9Atom...
Andreas Beeker [Wed, 19 Feb 2014 23:45:07 +0000 (23:45 +0000)]
Bug 55732 - PPT can't open, fails with "Couldn't instantiate .... StyleTextProp9Atom : java.lang.ArrayIndexOutOfBoundsException: 56"

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569984 13f79535-47bb-0310-9956-ffa450edef68

10 years agoComplete support for OOXML content types with parameters, including parts of the...
Nick Burch [Wed, 19 Feb 2014 23:34:53 +0000 (23:34 +0000)]
Complete support for OOXML content types with parameters, including parts of the patch from Sebastien Schneider from bug #55026

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569976 13f79535-47bb-0310-9956-ffa450edef68

10 years agoupgraded to junit4 (before other changes)
Andreas Beeker [Wed, 19 Feb 2014 23:30:12 +0000 (23:30 +0000)]
upgraded to junit4 (before other changes)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569972 13f79535-47bb-0310-9956-ffa450edef68

10 years agoBegin to implement some of the tests and logic for content types with parameters...
Nick Burch [Wed, 19 Feb 2014 23:12:56 +0000 (23:12 +0000)]
Begin to implement some of the tests and logic for content types with parameters, based on the test file for bug #55026

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569965 13f79535-47bb-0310-9956-ffa450edef68

10 years agolink forrest.properties from https://svn.apache.org/repos/asf/poi/site/forrest.properties
Andreas Beeker [Wed, 19 Feb 2014 22:51:08 +0000 (22:51 +0000)]
link forrest.properties from https://svn.apache.org/repos/asf/poi/site/forrest.properties

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569947 13f79535-47bb-0310-9956-ffa450edef68

10 years agoDowngrade the replacer plugin to 1.5.1, otherwise replacing does not find any files...
Dominik Stadler [Mon, 17 Feb 2014 22:11:57 +0000 (22:11 +0000)]
Downgrade the replacer plugin to 1.5.1, otherwise replacing does not find any files sometimes
Also svn-ignore the maven-target directories

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569118 13f79535-47bb-0310-9956-ffa450edef68

10 years agoFindBugs fix
Andreas Beeker [Sun, 16 Feb 2014 23:36:32 +0000 (23:36 +0000)]
FindBugs fix
- fixed "Equals method should not assume anything about the type of its argument"
- see http://findbugs.sourceforge.net/bugDescriptions.html#BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568861 13f79535-47bb-0310-9956-ffa450edef68

10 years agoPatch and test from Jon Iles from bug #56138 - HPSF code page strings can be zero...
Nick Burch [Sun, 16 Feb 2014 19:35:55 +0000 (19:35 +0000)]
Patch and test from Jon Iles from bug #56138 - HPSF code page strings can be zero length

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568813 13f79535-47bb-0310-9956-ffa450edef68

10 years agoFindBugs fix
Andreas Beeker [Sun, 16 Feb 2014 19:35:16 +0000 (19:35 +0000)]
FindBugs fix
- fixed "equals() method does not check for null argument"
- see http://findbugs.sourceforge.net/bugDescriptions.html#NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568812 13f79535-47bb-0310-9956-ffa450edef68

10 years agoSweeping is also needed for empty column-list ...
Andreas Beeker [Sun, 16 Feb 2014 17:00:53 +0000 (17:00 +0000)]
Sweeping is also needed for empty column-list ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568791 13f79535-47bb-0310-9956-ffa450edef68

10 years agoFindBugs fix
Andreas Beeker [Sun, 16 Feb 2014 16:30:24 +0000 (16:30 +0000)]
FindBugs fix
- fixed/checked various null pointer related entries
- see http://findbugs.sourceforge.net/bugDescriptions.html#NP_NULL_PARAM_DEREF
- ... NP_NULL_ON_SOME_PATH, NP_NULL_ON_SOME_PATH_EXCEPTION

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568789 13f79535-47bb-0310-9956-ffa450edef68

10 years ago- Changed status/changes xdocs/xslt, to link to the bug entry
Andreas Beeker [Sun, 16 Feb 2014 13:04:47 +0000 (13:04 +0000)]
- Changed status/changes xdocs/xslt, to link to the bug entry
  todo at the bottom of status was out of date anyway
- references to changes-v13.dtd results in a processing error in forest 0.5, so removed it and any references to it

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568757 13f79535-47bb-0310-9956-ffa450edef68

10 years agoFix unit tests broken by newly added test-file, ignore TestFontRendering as it is...
Dominik Stadler [Sun, 16 Feb 2014 09:11:28 +0000 (09:11 +0000)]
Fix unit tests broken by newly added test-file, ignore TestFontRendering as it is inherently unstable currently

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568744 13f79535-47bb-0310-9956-ffa450edef68

10 years agoFix unit test which failed after new corrupted file was added.
Dominik Stadler [Sun, 16 Feb 2014 08:39:47 +0000 (08:39 +0000)]
Fix unit test which failed after new corrupted file was added.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568741 13f79535-47bb-0310-9956-ffa450edef68

10 years agoAdjust test to write the failing PNG in case expected and actual do not match
Dominik Stadler [Sun, 16 Feb 2014 08:39:17 +0000 (08:39 +0000)]
Adjust test to write the failing PNG in case expected and actual do not match

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568740 13f79535-47bb-0310-9956-ffa450edef68

10 years agoTest file from bug #56138 from Jon Iles, with a zero length codepage string
Nick Burch [Sat, 15 Feb 2014 13:29:32 +0000 (13:29 +0000)]
Test file from bug #56138 from Jon Iles, with a zero length codepage string

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568634 13f79535-47bb-0310-9956-ffa450edef68

10 years agoInstead of using initCause() when re-throwing exceptions, it leads to better stacktra...
Dominik Stadler [Sat, 15 Feb 2014 10:43:58 +0000 (10:43 +0000)]
Instead of using initCause() when re-throwing exceptions, it leads to better stacktraces if a simple constructor-argument is used

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568614 13f79535-47bb-0310-9956-ffa450edef68

10 years agoAdd a set of maven pom.xml files for Sonar, a few workaround are
Dominik Stadler [Sat, 15 Feb 2014 10:42:43 +0000 (10:42 +0000)]
Add a set of maven pom.xml files for Sonar, a few workaround are
necessary, but overall this now allows to compile and run test for
all Apache POI components using Maven, which is a pre-requisite to
be analyzed at http://nemo.sonarqube.org/

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568613 13f79535-47bb-0310-9956-ffa450edef68

10 years agoProvide more output on test that failed for me locally
Dominik Stadler [Sat, 15 Feb 2014 00:21:19 +0000 (00:21 +0000)]
Provide more output on test that failed for me locally

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568558 13f79535-47bb-0310-9956-ffa450edef68

10 years agoAdjust some tests to not hardcode the 'test-data' directory. This breaks the Sonar...
Dominik Stadler [Sat, 15 Feb 2014 00:20:24 +0000 (00:20 +0000)]
Adjust some tests to not hardcode the 'test-data' directory. This breaks the Sonar-maven build that I am working on locally

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568557 13f79535-47bb-0310-9956-ffa450edef68

10 years agobuild.xml: Add missing depends on init for compile-main target
Dominik Stadler [Sat, 15 Feb 2014 00:19:50 +0000 (00:19 +0000)]
build.xml: Add missing depends on init for compile-main target

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568556 13f79535-47bb-0310-9956-ffa450edef68