source.dussan.org Git

Dominik Stadler [Thu, 26 Jan 2017 19:59:10 +0000 (19:59 +0000)]

Need a fifth addopens-parameter for JDK 9

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780457 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Thu, 26 Jan 2017 19:59:05 +0000 (19:59 +0000)]

Finally enable test for bug 44937, we got the requested missing test-documents a long time ago already.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780456 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Thu, 26 Jan 2017 19:58:58 +0000 (19:58 +0000)]

Don't wrap RuntimeException

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780455 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Thu, 26 Jan 2017 19:58:52 +0000 (19:58 +0000)]

Move test to base-test-class to run it for (S)XSSF as well
Also had to increase the numbers a bit as it fails locally for me otherwise

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780454 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Thu, 26 Jan 2017 19:58:46 +0000 (19:58 +0000)]

IntelliJ warnings, Javadoc, Formatting
Changes for the RecordFormatException deprecation

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780453 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Thu, 26 Jan 2017 19:58:29 +0000 (19:58 +0000)]

Jenkins DSL: Run all tests in no-scratchpad to try to get similar coverage-numbers

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780452 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Thu, 26 Jan 2017 19:58:25 +0000 (19:58 +0000)]

Cover some dev-tools with a few simple tests, close resources correctly

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780451 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Thu, 26 Jan 2017 19:58:18 +0000 (19:58 +0000)]

Bug 60031: Enhance test some more

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780450 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Mon, 23 Jan 2017 00:31:27 +0000 (00:31 +0000)]

fix eclipse warnings - close resources

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779869 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 22 Jan 2017 22:01:22 +0000 (22:01 +0000)]

#59836 - Tracker: Replace primitives with enums
preparation for removing those many HSSFColor subclasses with an enum

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779866 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Tim Allison [Fri, 20 Jan 2017 12:10:29 +0000 (12:10 +0000)]

Bug 60608 -- improve charset handling in Hwmf -- remove deprecated drawString(String...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779613 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 20 Jan 2017 05:40:49 +0000 (05:40 +0000)]

fix assert message typo

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779567 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 20 Jan 2017 05:37:12 +0000 (05:37 +0000)]

fix copy-paste typo in unit test found by Andrzej Witecki

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779565 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 20 Jan 2017 05:35:57 +0000 (05:35 +0000)]

bug 60031: DataFormatter parses months incorrectly when put at the end of date segment. Thanks to Andrzej Witecki

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779564 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 20 Jan 2017 05:04:57 +0000 (05:04 +0000)]

remove unused imports

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779563 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 20 Jan 2017 05:00:29 +0000 (05:00 +0000)]

bug 60605: replace Workbook.SHEET_STATE_VERY_HIDDEN with SheetVisibility.VERY_HIDDEN

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779562 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 20 Jan 2017 04:55:06 +0000 (04:55 +0000)]

bug 60605: remove code for enforcing rule that active sheet cannot be hidden

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779561 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 20 Jan 2017 04:38:18 +0000 (04:38 +0000)]

pull out loop invariants, use List.indexOf to look up sheet index

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779560 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 20 Jan 2017 04:23:42 +0000 (04:23 +0000)]

bug 60605: convert Workbook.SHEET_STATE_* to SheetVisibility enum

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779558 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 20 Jan 2017 04:20:20 +0000 (04:20 +0000)]

javadocs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779557 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 20 Jan 2017 02:16:58 +0000 (02:16 +0000)]

make instance variable final

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779551 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Tim Allison [Thu, 19 Jan 2017 20:19:26 +0000 (20:19 +0000)]

Bug 60608 -- improve charset handling in Hwmf

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779519 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Tim Allison [Thu, 19 Jan 2017 16:22:29 +0000 (16:22 +0000)]

Bug 60570 - Add rudimentary EMF read-only capability

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779493 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 19 Jan 2017 09:01:39 +0000 (09:01 +0000)]

bug 60601: unset hyperlinks after removing them individually from the DOM

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779437 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 19 Jan 2017 08:51:04 +0000 (08:51 +0000)]

bug 60601: allow SXSSFITestDataProvider.writeOutAndReadBack(Workbook wb) to work on SXSSFWorkbooks and XSSFWorkbooks

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779433 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 19 Jan 2017 08:09:11 +0000 (08:09 +0000)]

bug 60601: hyperlinks have to be removed one by one to avoid other errors

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779429 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 19 Jan 2017 07:44:25 +0000 (07:44 +0000)]

bug 60601: unlink hyperlinks from a sheet if all hyperlinks have been removed. Patch from Joachim Piketz

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779426 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Wed, 18 Jan 2017 00:59:19 +0000 (00:59 +0000)]

SonarQube fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779285 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Mon, 16 Jan 2017 01:18:46 +0000 (01:18 +0000)]

fix eclipse warnings / close resources in tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778958 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 15 Jan 2017 23:08:47 +0000 (23:08 +0000)]

fix eclipse warnings - close resources / type generics
cleanup sources - add parenthesis to statements

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778955 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 15 Jan 2017 19:03:17 +0000 (19:03 +0000)]

remove test output

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778940 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 15 Jan 2017 19:02:48 +0000 (19:02 +0000)]

Java9 fix - resource not found

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778939 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 15 Jan 2017 02:04:57 +0000 (02:04 +0000)]

#60586 - Support embedding OLE1.0 package in XSSF / SS Common

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778869 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Tim Allison [Fri, 13 Jan 2017 20:55:04 +0000 (20:55 +0000)]

bug 60584 -- avoid NPE by checking for null/missing image in XSSFReader's getShapes().

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778664 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 12 Jan 2017 10:39:26 +0000 (10:39 +0000)]

bug 60260: parse unicode sheet names

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778418 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Tim Allison [Wed, 11 Jan 2017 16:01:32 +0000 (16:01 +0000)]

Bug 60574 prevent rare NPE in ListTables

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778320 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 8 Jan 2017 00:38:41 +0000 (00:38 +0000)]

SonarQube fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777855 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sat, 7 Jan 2017 00:26:46 +0000 (00:26 +0000)]

SonarQube fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777739 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Fri, 6 Jan 2017 17:51:22 +0000 (17:51 +0000)]

SonarQube fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777669 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Fri, 6 Jan 2017 09:05:14 +0000 (09:05 +0000)]

SonarQube fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777541 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Thu, 5 Jan 2017 23:40:57 +0000 (23:40 +0000)]

SonarQube fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777526 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Thu, 5 Jan 2017 22:49:14 +0000 (22:49 +0000)]

Rename example class (typo)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777518 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 5 Jan 2017 12:46:28 +0000 (12:46 +0000)]

add unit tests for MAPIMessage.get*Body()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777463 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 5 Jan 2017 11:26:42 +0000 (11:26 +0000)]

junit improvements: assertEquals(null|true|false, ...) -> assertNull, assertTrue, assertFalse

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777450 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 5 Jan 2017 11:17:44 +0000 (11:17 +0000)]

bug 60331: remove deprecated OutlookTextExtractor constructor

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777447 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 5 Jan 2017 10:41:23 +0000 (10:41 +0000)]

bug 60331: remove deprecated constructor and method in scratchpad o.a.p.hsmf.MAPIMessage

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777444 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 5 Jan 2017 08:36:06 +0000 (08:36 +0000)]

revert accidental commits in r1777435

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777436 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 5 Jan 2017 08:32:07 +0000 (08:32 +0000)]

junit3 -> junit4

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777435 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 5 Jan 2017 08:01:58 +0000 (08:01 +0000)]

bug 60550: read ContentID chunks from mail attachments; unit test and test-data/hsmf/attachmet_msg_inlineImg.msg contributed by maoblackberry@gmail.com

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777429 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 5 Jan 2017 07:59:27 +0000 (07:59 +0000)]

bug 60550: read ContentID chunks from mail attachments

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777428 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 5 Jan 2017 07:26:02 +0000 (07:26 +0000)]

whitespace: 3/4sp -> 4sp

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777427 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 5 Jan 2017 07:16:27 +0000 (07:16 +0000)]

junit improvements:
assertEquals(null, ...) -> assertNull(...)
attachment.getAttachFileName().toString() -> attachment.getAttachFileName().getValue()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777423 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Thu, 5 Jan 2017 01:10:45 +0000 (01:10 +0000)]

EmbeddedExtractor (for *SSF) - added OOXML support

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777394 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 4 Jan 2017 07:00:24 +0000 (07:00 +0000)]

github-44: reference BuiltinFormats in javadocs for CellStyle.getDataFormat and setDataFormat
This closes #44 github pull request from sixinli

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777260 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Wed, 4 Jan 2017 01:24:19 +0000 (01:24 +0000)]

relax timeout on performance test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777254 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Wed, 4 Jan 2017 01:06:30 +0000 (01:06 +0000)]

SonarQube fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777252 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David North [Tue, 3 Jan 2017 15:41:41 +0000 (15:41 +0000)]

Fix poor XPath performance when importing XSSF from XML

https://bz.apache.org/bugzilla/show_bug.cgi?id=60498

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777146 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 3 Jan 2017 04:35:54 +0000 (04:35 +0000)]

bug 60484: avoid NPE

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777063 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 3 Jan 2017 03:52:58 +0000 (03:52 +0000)]

use Collections.singletonList and Collections.emptyList where appropriate

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777056 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 3 Jan 2017 02:14:29 +0000 (02:14 +0000)]

refactor duplicated code in TestXSSFSheet#setColumnGroupCollapsed; remove unnecessary int to short casts

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777052 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Tue, 3 Jan 2017 01:02:33 +0000 (01:02 +0000)]

SonarQube fixes
add Iterable interface to EscherContainerRecord / deprecate getChildIterator()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777046 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 2 Jan 2017 23:23:16 +0000 (23:23 +0000)]

convert TestColumnHelper from junit3 to junit4

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777038 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 2 Jan 2017 23:14:53 +0000 (23:14 +0000)]

assertEquals(false, ...) -> assertFalse(...)
assertEquals(true, ...) -> assertTrue(...)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777037 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 2 Jan 2017 22:23:56 +0000 (22:23 +0000)]

use case-insensitive string startsWith/endsWith utility function

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777031 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Mon, 2 Jan 2017 00:55:49 +0000 (00:55 +0000)]

Sonarqube fixes
- replace RuntimeException with application specific runtime exception
- clean-up sources - add braces to if statements and add override annotations
- fix a few hslf blockers

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776896 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 1 Jan 2017 22:59:35 +0000 (22:59 +0000)]

Sonarqube fixes - Cast one of the operands of this multiplication operation to a ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776894 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 1 Jan 2017 06:58:01 +0000 (06:58 +0000)]

md5hash should not fail silently

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776828 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 1 Jan 2017 06:57:42 +0000 (06:57 +0000)]

use last file extension if multiple extensions; close opened stream; extract String constants

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776827 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 1 Jan 2017 00:56:51 +0000 (00:56 +0000)]

fix content-type handling in *SSF-EmbeddedExtractor

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776823 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sat, 31 Dec 2016 21:54:32 +0000 (21:54 +0000)]

#60521 - Enable nested XSSF GroupShapes and fix calculation of Client-/ChildAnchor

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776820 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sat, 31 Dec 2016 21:50:47 +0000 (21:50 +0000)]

#60519 - Extractor for *SSF embeddings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776819 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sat, 31 Dec 2016 21:47:23 +0000 (21:47 +0000)]

#60520 - Provide *SSF functionality via Common SS

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776818 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sat, 31 Dec 2016 21:37:14 +0000 (21:37 +0000)]

fix forbidden-apis-check error

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776817 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 31 Dec 2016 17:55:52 +0000 (17:55 +0000)]

Fix missing license-headers

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776806 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 31 Dec 2016 16:53:33 +0000 (16:53 +0000)]

Cover some dev-tools with a few simple tests, close resources correctly

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776798 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 31 Dec 2016 16:53:20 +0000 (16:53 +0000)]

Allow to pass --add-modules to javadoc as well as we get lots of missing code reported otherwise, we cannot use the existing property java9addmods as we need to use a different default-value for non-JDK9 builds

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776797 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 31 Dec 2016 16:53:16 +0000 (16:53 +0000)]

Bug 60219: FormulaParser can't parse external references when sheet name is quoted

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776796 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 31 Dec 2016 09:43:13 +0000 (09:43 +0000)]

Coverage:
* Exclude "examples" from coverage in Jenkins, add some comments
* Fix warning in newer Gradle versions
* Adjust coverage-excludes in build.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776715 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 31 Dec 2016 09:43:08 +0000 (09:43 +0000)]

Fix some Findbugs reports

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776714 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Fri, 30 Dec 2016 22:19:12 +0000 (22:19 +0000)]

Jenkins DSL: IBM JDK should not use noScratchpad, set coverage-flag for no-scratchpad-job

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776650 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Fri, 30 Dec 2016 22:12:14 +0000 (22:12 +0000)]

Jenkins DLS: Remove support for multiple JDKs, it was not used and did not work anyway due to name-clashes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776649 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Fri, 30 Dec 2016 22:12:10 +0000 (22:12 +0000)]

Send emails for builds with JDK 9 to dev@ now after it ran green for the first time

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776648 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Fri, 30 Dec 2016 22:12:06 +0000 (22:12 +0000)]

Ensure streams are closed always, reformat code somewhat

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776647 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Fri, 30 Dec 2016 22:11:55 +0000 (22:11 +0000)]

Bug 60369: Adjust pattern to better handle non-ASCII characters in Month-names which can appear since Java 8

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776646 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Fri, 30 Dec 2016 22:11:48 +0000 (22:11 +0000)]

Fix some compilation warnings
Update Javadoc
Reformat code somewhat
Supress IntelliJ warnings in findbugs-filters.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776645 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Fri, 30 Dec 2016 20:35:13 +0000 (20:35 +0000)]

Set --add-modules as environment-variable as well as we need to enable it in Ant itself for the forbidden-api-checks

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776634 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Fri, 30 Dec 2016 20:35:08 +0000 (20:35 +0000)]

Fix an api-violations introduced in a test-case

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776633 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Fri, 30 Dec 2016 19:03:44 +0000 (19:03 +0000)]

Update JaCoCo to 0.7.8 to allow to run it when using JDK 9

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776623 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Fri, 30 Dec 2016 18:54:47 +0000 (18:54 +0000)]

Add test provided via bug 60536 for bug 60526, remove some warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776622 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Fri, 30 Dec 2016 18:37:24 +0000 (18:37 +0000)]

Add full support for using file-leak-detector, will be added to CI to report missing close() calls in test-runs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776617 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Fri, 30 Dec 2016 17:00:13 +0000 (17:00 +0000)]

Allow to set the new --add-opens argument for JDK 9, scratchpad tests require slightly more memory on JDK 9 now, also adjust the Jenkins DSL accordingly.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776608 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Fri, 30 Dec 2016 16:55:19 +0000 (16:55 +0000)]

Bug 60512: Add missing XSSFRelation.CUSTOM_PROPERTY

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776606 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Fri, 30 Dec 2016 15:05:14 +0000 (15:05 +0000)]

Bug 60452: WorkdayCalculator calculateWorkdays does return wrong value for same day input
deprecate unused method isNonWorkday

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776588 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Fri, 30 Dec 2016 13:09:28 +0000 (13:09 +0000)]

bug 60526: Make loggers final and make throttled log actually work

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776555 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Wed, 28 Dec 2016 19:47:40 +0000 (19:47 +0000)]

Disable Sonar in Gradle build for now, it requires Java 8, but we should still be able to compile with Java 7

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776317 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 26 Dec 2016 20:47:29 +0000 (20:47 +0000)]

Add sonar-plugin to Gradle build

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776072 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 26 Dec 2016 19:51:47 +0000 (19:51 +0000)]

Maven: Add jacoco plugin and adjust to apply argLine correctly when calling "mvn jacoco:prepare-agent package jacoco:report jacoco:report-aggregate", however report-aggregate does not seem to work yet

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776068 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 26 Dec 2016 19:51:42 +0000 (19:51 +0000)]

Add some throttling to the log for failed SAXHelper features to not spam the log on JDK 9 with restricted reflection

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776067 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 26 Dec 2016 19:51:37 +0000 (19:51 +0000)]

Use one redirection less when downloading findbugs jar

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776066 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 26 Dec 2016 19:51:32 +0000 (19:51 +0000)]

Add mising @Override and other warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776065 13f79535-47bb-0310-9956-ffa450edef68